* [PATCH net-next] ath11k: Fix possible memleak in ath11k_qmi_init_service
@ 2020-07-20 9:36 Wang Yufen
2020-08-18 9:51 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Wang Yufen @ 2020-07-20 9:36 UTC (permalink / raw)
To: netdev, linux-kernel, brcm80211-dev-list, linux-wireless, davem,
kvalo, kuba, franky.lin, wright.feng
Cc: Wang Yufen
When qmi_add_lookup fail, we should destroy the workqueue
Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Yufen <wangyufen@huawei.com>
---
drivers/net/wireless/ath/ath11k/qmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ath/ath11k/qmi.c b/drivers/net/wireless/ath/ath11k/qmi.c
index c00a99a..497cff7 100644
--- a/drivers/net/wireless/ath/ath11k/qmi.c
+++ b/drivers/net/wireless/ath/ath11k/qmi.c
@@ -2419,6 +2419,7 @@ int ath11k_qmi_init_service(struct ath11k_base *ab)
ATH11K_QMI_WLFW_SERVICE_INS_ID_V01);
if (ret < 0) {
ath11k_warn(ab, "failed to add qmi lookup\n");
+ destroy_workqueue(ab->qmi.event_wq);
return ret;
}
--
1.8.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] ath11k: Fix possible memleak in ath11k_qmi_init_service
2020-07-20 9:36 [PATCH net-next] ath11k: Fix possible memleak in ath11k_qmi_init_service Wang Yufen
@ 2020-08-18 9:51 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2020-08-18 9:51 UTC (permalink / raw)
To: Wang Yufen
Cc: netdev, linux-kernel, brcm80211-dev-list, linux-wireless, davem,
kuba, franky.lin, wright.feng, Wang Yufen
Wang Yufen <wangyufen@huawei.com> wrote:
> When qmi_add_lookup fail, we should destroy the workqueue
>
> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
28f163211881 ath11k: Fix possible memleak in ath11k_qmi_init_service
--
https://patchwork.kernel.org/patch/11673293/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-18 9:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-20 9:36 [PATCH net-next] ath11k: Fix possible memleak in ath11k_qmi_init_service Wang Yufen
2020-08-18 9:51 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).