* [PATCH net-next] net: Enabled MPLS support for devices of type ARPHRD_NONE.
@ 2020-07-22 16:13 Martin Varghese
2020-07-23 22:00 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Martin Varghese @ 2020-07-22 16:13 UTC (permalink / raw)
To: netdev, davem, kuba; +Cc: Martin Varghese
From: Martin Varghese <martin.varghese@nokia.com>
This change enables forwarding of MPLS packets from bareudp tunnel
device which is of type ARPHRD_NONE.
Signed-off-by: Martin Varghese <martin.varghese@nokia.com>
---
net/mpls/af_mpls.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
index fd30ea61336e..37b6731a4576 100644
--- a/net/mpls/af_mpls.c
+++ b/net/mpls/af_mpls.c
@@ -1594,7 +1594,8 @@ static int mpls_dev_notify(struct notifier_block *this, unsigned long event,
dev->type == ARPHRD_IP6GRE ||
dev->type == ARPHRD_SIT ||
dev->type == ARPHRD_TUNNEL ||
- dev->type == ARPHRD_TUNNEL6) {
+ dev->type == ARPHRD_TUNNEL6 ||
+ dev->type == ARPHRD_NONE) {
mdev = mpls_add_dev(dev);
if (IS_ERR(mdev))
return notifier_from_errno(PTR_ERR(mdev));
--
2.18.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: Enabled MPLS support for devices of type ARPHRD_NONE.
2020-07-22 16:13 [PATCH net-next] net: Enabled MPLS support for devices of type ARPHRD_NONE Martin Varghese
@ 2020-07-23 22:00 ` David Miller
2020-07-27 6:57 ` Varghese, Martin (Nokia - IN/Bangalore)
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2020-07-23 22:00 UTC (permalink / raw)
To: martinvarghesenokia; +Cc: netdev, kuba, martin.varghese
From: Martin Varghese <martinvarghesenokia@gmail.com>
Date: Wed, 22 Jul 2020 21:43:21 +0530
> From: Martin Varghese <martin.varghese@nokia.com>
>
> This change enables forwarding of MPLS packets from bareudp tunnel
> device which is of type ARPHRD_NONE.
>
> Signed-off-by: Martin Varghese <martin.varghese@nokia.com>
This restriction looks just like a massive guessing game.
What is needed by MPLS by a device specifically, and can therefore
this restrictive test be removed entirely?
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH net-next] net: Enabled MPLS support for devices of type ARPHRD_NONE.
2020-07-23 22:00 ` David Miller
@ 2020-07-27 6:57 ` Varghese, Martin (Nokia - IN/Bangalore)
0 siblings, 0 replies; 3+ messages in thread
From: Varghese, Martin (Nokia - IN/Bangalore) @ 2020-07-27 6:57 UTC (permalink / raw)
To: David Miller, martinvarghesenokia; +Cc: netdev, kuba
>> From: Martin Varghese <martin.varghese@nokia.com>
>>
>> This change enables forwarding of MPLS packets from bareudp tunnel
>> device which is of type ARPHRD_NONE.
>>
>> Signed-off-by: Martin Varghese <martin.varghese@nokia.com>
> This restriction looks just like a massive guessing game.
> What is needed by MPLS by a device specifically, and can therefore this restrictive test be removed entirely?
I think so . I will send out a different patch which removes the complete check.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-27 6:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-22 16:13 [PATCH net-next] net: Enabled MPLS support for devices of type ARPHRD_NONE Martin Varghese
2020-07-23 22:00 ` David Miller
2020-07-27 6:57 ` Varghese, Martin (Nokia - IN/Bangalore)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).