* [PATCH] net: qede: use eth_zero_addr() to clear mac address
@ 2020-08-01 9:13 linmiaohe
2020-08-03 22:38 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: linmiaohe @ 2020-08-01 9:13 UTC (permalink / raw)
To: aelior, GR-everest-linux-l2, davem, kuba; +Cc: netdev, linux-kernel, linmiaohe
From: Miaohe Lin <linmiaohe@huawei.com>
Use eth_zero_addr() to clear mac address instead of memset().
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
drivers/net/ethernet/qlogic/qede/qede_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c
index 29e285430f99..e1617a67a714 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_main.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_main.c
@@ -2678,8 +2678,8 @@ static void qede_get_generic_tlv_data(void *dev, struct qed_generic_tlvs *data)
data->feat_flags |= QED_TLV_LSO;
ether_addr_copy(data->mac[0], edev->ndev->dev_addr);
- memset(data->mac[1], 0, ETH_ALEN);
- memset(data->mac[2], 0, ETH_ALEN);
+ eth_zero_addr(data->mac[1]);
+ eth_zero_addr(data->mac[2]);
/* Copy the first two UC macs */
netif_addr_lock_bh(edev->ndev);
i = 1;
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: qede: use eth_zero_addr() to clear mac address
2020-08-01 9:13 [PATCH] net: qede: use eth_zero_addr() to clear mac address linmiaohe
@ 2020-08-03 22:38 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-08-03 22:38 UTC (permalink / raw)
To: linmiaohe; +Cc: aelior, GR-everest-linux-l2, kuba, netdev, linux-kernel
From: linmiaohe <linmiaohe@huawei.com>
Date: Sat, 1 Aug 2020 17:13:54 +0800
> From: Miaohe Lin <linmiaohe@huawei.com>
>
> Use eth_zero_addr() to clear mac address instead of memset().
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-03 22:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-01 9:13 [PATCH] net: qede: use eth_zero_addr() to clear mac address linmiaohe
2020-08-03 22:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).