* [PATCH v2] tg3: Avoid NULL pointer dereference in netif_device_attach()
@ 2020-10-21 7:33 Defang Bo
0 siblings, 0 replies; only message in thread
From: Defang Bo @ 2020-10-21 7:33 UTC (permalink / raw)
To: siva.kallam; +Cc: prashant, mchan, davem, kuba, netdev, linux-kernel, Defang Bo
Similar to commit<1b0ff89852d7>("tg3: Avoid NULL pointer dereference in tg3_io_error_detected()")
This patch avoids NULL pointer dereference add a check for netdev being NULL on tg3_resume().
Signed-off-by: Defang Bo <bodefang@126.com>
---
drivers/net/ethernet/broadcom/tg3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index ae756dd..345c6aa 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -18099,7 +18099,7 @@ static int tg3_resume(struct device *device)
rtnl_lock();
- if (!netdev || !netif_running(dev))
+ if (!dev || !netif_running(dev))
goto unlock;
netif_device_attach(dev);
--
1.9.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-10-21 8:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-21 7:33 [PATCH v2] tg3: Avoid NULL pointer dereference in netif_device_attach() Defang Bo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).