* [PATCH net V3] net: Disable NETIF_F_HW_TLS_TX when HW_CSUM is disabled
@ 2020-12-13 14:39 Tariq Toukan
2020-12-15 3:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Tariq Toukan @ 2020-12-13 14:39 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski
Cc: netdev, Saeed Mahameed, Moshe Shemesh, Boris Pismenny,
Tariq Toukan, Tariq Toukan
With NETIF_F_HW_TLS_TX packets are encrypted in HW. This cannot be
logically done when HW_CSUM offload is off.
Fixes: 2342a8512a1e ("net: Add TLS TX offload features")
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Reviewed-by: Boris Pismenny <borisp@nvidia.com>
---
Documentation/networking/tls-offload.rst | 8 +++++++-
net/core/dev.c | 5 +++++
2 files changed, 12 insertions(+), 1 deletion(-)
Hi,
Please queue to -stable >= v4.18.
Thanks.
v3:
- Describe expected behavior for already opened connections.
v2:
- Documented the change in tls-offload.rst.
diff --git a/Documentation/networking/tls-offload.rst b/Documentation/networking/tls-offload.rst
index 37773da2bee5..0f55c6d540f9 100644
--- a/Documentation/networking/tls-offload.rst
+++ b/Documentation/networking/tls-offload.rst
@@ -524,7 +524,13 @@ on TCP retransmissions to handle corner cases is not acceptable.
TLS device features
-------------------
-Drivers should ignore the changes to TLS the device feature flags.
+Drivers should ignore the changes to the TLS device feature flags.
These flags will be acted upon accordingly by the core ``ktls`` code.
TLS device feature flags only control adding of new TLS connection
offloads, old connections will remain active after flags are cleared.
+
+TLS encryption cannot be offloaded to devices without checksum calculation
+offload. Hence, TLS TX device feature flag requires NETIF_F_HW_CSUM being set.
+Disabling the latter implies clearing the former. Disabling TX checksum offload
+should not affect old connections, and drivers should make sure checksum
+calculation does not break for them.
diff --git a/net/core/dev.c b/net/core/dev.c
index 38412e70f761..bd06c270ad57 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -9602,6 +9602,11 @@ static netdev_features_t netdev_fix_features(struct net_device *dev,
}
}
+ if ((features & NETIF_F_HW_TLS_TX) && !(features & NETIF_F_HW_CSUM)) {
+ netdev_dbg(dev, "Dropping TLS TX HW offload feature since no CSUM feature.\n");
+ features &= ~NETIF_F_HW_TLS_TX;
+ }
+
return features;
}
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net V3] net: Disable NETIF_F_HW_TLS_TX when HW_CSUM is disabled
2020-12-13 14:39 [PATCH net V3] net: Disable NETIF_F_HW_TLS_TX when HW_CSUM is disabled Tariq Toukan
@ 2020-12-15 3:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2020-12-15 3:40 UTC (permalink / raw)
To: Tariq Toukan; +Cc: davem, kuba, netdev, saeedm, moshe, borisp, ttoukan.linux
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Sun, 13 Dec 2020 16:39:29 +0200 you wrote:
> With NETIF_F_HW_TLS_TX packets are encrypted in HW. This cannot be
> logically done when HW_CSUM offload is off.
>
> Fixes: 2342a8512a1e ("net: Add TLS TX offload features")
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
> Reviewed-by: Boris Pismenny <borisp@nvidia.com>
>
> [...]
Here is the summary with links:
- [net,V3] net: Disable NETIF_F_HW_TLS_TX when HW_CSUM is disabled
https://git.kernel.org/netdev/net-next/c/ae0b04b238e2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-15 3:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-13 14:39 [PATCH net V3] net: Disable NETIF_F_HW_TLS_TX when HW_CSUM is disabled Tariq Toukan
2020-12-15 3:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).