[PATCH net] ch_ipsec: Remove initialization of rxq related data

[PATCH net] ch_ipsec: Remove initialization of rxq related data

[Ayush Sawal]

Removing initialization of nrxq and rxq_size in uld_info. As
ipsec uses nic queues only, there is no need to create uld
rx queues for ipsec.

Fixes: 1b77be463929e ("crypto/chcr: Moving chelsio's inline ipsec functionality to /drivers/net")
Signed-off-by: Ayush Sawal <ayush.sawal@chelsio.com>
---
 .../net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c   | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c b/drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c
index 47d9268a7e3c..585590520076 100644
--- a/drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c
+++ b/drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c
@@ -92,9 +92,6 @@ static const struct xfrmdev_ops ch_ipsec_xfrmdev_ops = {
 
 static struct cxgb4_uld_info ch_ipsec_uld_info = {
 	.name = CHIPSEC_DRV_MODULE_NAME,
-	.nrxq = MAX_ULD_QSETS,
-	/* Max ntxq will be derived from fw config file*/
-	.rxq_size = 1024,
 	.add = ch_ipsec_uld_add,
 	.state_change = ch_ipsec_uld_state_change,
 	.tx_handler = ch_ipsec_xmit,
-- 
2.28.0.rc1.6.gae46588

Re: [PATCH net] ch_ipsec: Remove initialization of rxq related data

[Jakub Kicinski]

On Wed, 13 Jan 2021 10:13:02 +0530 Ayush Sawal wrote:
> Removing initialization of nrxq and rxq_size in uld_info. As
> ipsec uses nic queues only, there is no need to create uld
> rx queues for ipsec.

Why is this a fix? Does it break something or just wastes resources?
If it's just about efficient use of resources I'll apply to net-next.

Re: [PATCH net] ch_ipsec: Remove initialization of rxq related data

[Ayush Sawal]

Hi Jakub,

On 1/15/2021 12:12 AM, Jakub Kicinski wrote:
> On Wed, 13 Jan 2021 10:13:02 +0530 Ayush Sawal wrote:
>> Removing initialization of nrxq and rxq_size in uld_info. As
>> ipsec uses nic queues only, there is no need to create uld
>> rx queues for ipsec.
> Why is this a fix? Does it break something or just wastes resources?
> If it's just about efficient use of resources I'll apply to net-next.

yes this patch is about efficient use of resources, please apply it to 
net-next.

Thanks,
Ayush

Re: [PATCH net] ch_ipsec: Remove initialization of rxq related data

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 13 Jan 2021 10:13:02 +0530 you wrote:
> Removing initialization of nrxq and rxq_size in uld_info. As
> ipsec uses nic queues only, there is no need to create uld
> rx queues for ipsec.
> 
> Fixes: 1b77be463929e ("crypto/chcr: Moving chelsio's inline ipsec functionality to /drivers/net")
> Signed-off-by: Ayush Sawal <ayush.sawal@chelsio.com>
> 
> [...]

Here is the summary with links:
  - [net] ch_ipsec: Remove initialization of rxq related data
    https://git.kernel.org/netdev/net-next/c/e3a7670737ec

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html