netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] NFC: fix possible resource leak
@ 2021-01-21 15:37 Pan Bian
  2021-01-23 21:40 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Pan Bian @ 2021-01-21 15:37 UTC (permalink / raw)
  To: David S. Miller, Jakub Kicinski, Kees Cook, Francis Laniel,
	Defang Bo, Samuel Ortiz
  Cc: netdev, linux-kernel, Pan Bian

Put the device to avoid resource leak on path that the polling flag is
invalid.

Fixes: a831b9132065 ("NFC: Do not return EBUSY when stopping a poll that's already stopped")
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
 net/nfc/netlink.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c
index 573b38ad2f8e..e161ef2d4720 100644
--- a/net/nfc/netlink.c
+++ b/net/nfc/netlink.c
@@ -852,6 +852,7 @@ static int nfc_genl_stop_poll(struct sk_buff *skb, struct genl_info *info)
 
 	if (!dev->polling) {
 		device_unlock(&dev->dev);
+		nfc_put_device(dev);
 		return -EINVAL;
 	}
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] NFC: fix possible resource leak
  2021-01-21 15:37 [PATCH] NFC: fix possible resource leak Pan Bian
@ 2021-01-23 21:40 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-01-23 21:40 UTC (permalink / raw)
  To: Pan Bian
  Cc: davem, kuba, keescook, laniel_francis, bodefang, sameo, netdev,
	linux-kernel

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Thu, 21 Jan 2021 07:37:45 -0800 you wrote:
> Put the device to avoid resource leak on path that the polling flag is
> invalid.
> 
> Fixes: a831b9132065 ("NFC: Do not return EBUSY when stopping a poll that's already stopped")
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> ---
>  net/nfc/netlink.c | 1 +
>  1 file changed, 1 insertion(+)

Here is the summary with links:
  - NFC: fix possible resource leak
    https://git.kernel.org/netdev/net/c/d8f923c3ab96

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-23 21:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-21 15:37 [PATCH] NFC: fix possible resource leak Pan Bian
2021-01-23 21:40 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).