netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RESEND net-next] rxrpc: Fix dependency on IPv6 in udp tunnel config
@ 2021-02-12 10:48 Vadim Fedorenko
  2021-02-12 17:19 ` David Howells
  2021-02-13  0:50 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Vadim Fedorenko @ 2021-02-12 10:48 UTC (permalink / raw)
  To: Jakub Kicinski, David Howells, Willem de Bruijn, David S . Miller
  Cc: Vadim Fedorenko, netdev

As udp_port_cfg struct changes its members with dependency on IPv6
configuration, the code in rxrpc should also check for IPv6.

Fixes: 1a9b86c9fd95 ("rxrpc: use udp tunnel APIs instead of open code in rxrpc_open_socket")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru>
---
 net/rxrpc/local_object.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/rxrpc/local_object.c b/net/rxrpc/local_object.c
index 546fd237a649..a4111408ffd0 100644
--- a/net/rxrpc/local_object.c
+++ b/net/rxrpc/local_object.c
@@ -120,9 +120,11 @@ static int rxrpc_open_socket(struct rxrpc_local *local, struct net *net)
 	if (udp_conf.family == AF_INET) {
 		udp_conf.local_ip = srx->transport.sin.sin_addr;
 		udp_conf.local_udp_port = srx->transport.sin.sin_port;
+#if IS_ENABLED(CONFIG_AF_RXRPC_IPV6)
 	} else {
 		udp_conf.local_ip6 = srx->transport.sin6.sin6_addr;
 		udp_conf.local_udp_port = srx->transport.sin6.sin6_port;
+#endif
 	}
 	ret = udp_sock_create(net, &udp_conf, &local->socket);
 	if (ret < 0) {
-- 
2.18.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [RESEND net-next] rxrpc: Fix dependency on IPv6 in udp tunnel config
  2021-02-12 10:48 [RESEND net-next] rxrpc: Fix dependency on IPv6 in udp tunnel config Vadim Fedorenko
@ 2021-02-12 17:19 ` David Howells
  2021-02-13  0:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: David Howells @ 2021-02-12 17:19 UTC (permalink / raw)
  To: Vadim Fedorenko
  Cc: dhowells, Jakub Kicinski, Willem de Bruijn, David S . Miller, netdev

Vadim Fedorenko <vfedorenko@novek.ru> wrote:

> As udp_port_cfg struct changes its members with dependency on IPv6
> configuration, the code in rxrpc should also check for IPv6.
> 
> Fixes: 1a9b86c9fd95 ("rxrpc: use udp tunnel APIs instead of open code in rxrpc_open_socket")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru>

Looks reasonable.

Acked-by: David Howells <dhowells@redhat.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RESEND net-next] rxrpc: Fix dependency on IPv6 in udp tunnel config
  2021-02-12 10:48 [RESEND net-next] rxrpc: Fix dependency on IPv6 in udp tunnel config Vadim Fedorenko
  2021-02-12 17:19 ` David Howells
@ 2021-02-13  0:50 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-02-13  0:50 UTC (permalink / raw)
  To: Vadim Fedorenko; +Cc: kuba, dhowells, willemdebruijn.kernel, davem, netdev

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Fri, 12 Feb 2021 13:48:14 +0300 you wrote:
> As udp_port_cfg struct changes its members with dependency on IPv6
> configuration, the code in rxrpc should also check for IPv6.
> 
> Fixes: 1a9b86c9fd95 ("rxrpc: use udp tunnel APIs instead of open code in rxrpc_open_socket")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru>
> 
> [...]

Here is the summary with links:
  - [RESEND,net-next] rxrpc: Fix dependency on IPv6 in udp tunnel config
    https://git.kernel.org/netdev/net-next/c/295f830e53f4

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-02-13  0:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-12 10:48 [RESEND net-next] rxrpc: Fix dependency on IPv6 in udp tunnel config Vadim Fedorenko
2021-02-12 17:19 ` David Howells
2021-02-13  0:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).