netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next 0/4] Add 5gbase-r PHY interface mode
@ 2021-02-16 19:20 Marek Behún
  2021-02-16 19:20 ` [PATCH net-next 1/4] dt-bindings: net: Add 5GBASER phy interface Marek Behún
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Marek Behún @ 2021-02-16 19:20 UTC (permalink / raw)
  To: netdev, Russell King - ARM Linux admin, davem, kuba
  Cc: pavana.sharma, vivien.didelot, f.fainelli, lkp, ashkan.boldaji,
	andrew, Chris Packham, olteanv, Marek Behún

Hello,

there is still some testing needed for Amethyst patches, so I have
split the part adding support for 5gbase-r interface mode and am sending
it alone.

The first two patches are already reviewed.

Changes since last patches (Amethyst v16):
- added phylink 5gbase-r handler
- added SFP support for 5gbase-r mode

Marek

Marek Behún (2):
  net: phylink: Add 5gbase-r support
  sfp: add support for 5gbase-t SFPs

Pavana Sharma (2):
  dt-bindings: net: Add 5GBASER phy interface
  net: phy: Add 5GBASER interface mode

 .../devicetree/bindings/net/ethernet-controller.yaml        | 1 +
 Documentation/networking/phy.rst                            | 6 ++++++
 drivers/net/phy/phylink.c                                   | 4 ++++
 drivers/net/phy/sfp-bus.c                                   | 3 +++
 include/linux/phy.h                                         | 4 ++++
 5 files changed, 18 insertions(+)

-- 
2.26.2


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH net-next 1/4] dt-bindings: net: Add 5GBASER phy interface
  2021-02-16 19:20 [PATCH net-next 0/4] Add 5gbase-r PHY interface mode Marek Behún
@ 2021-02-16 19:20 ` Marek Behún
  2021-02-16 19:20 ` [PATCH net-next 2/4] net: phy: Add 5GBASER interface mode Marek Behún
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Marek Behún @ 2021-02-16 19:20 UTC (permalink / raw)
  To: netdev, Russell King - ARM Linux admin, davem, kuba
  Cc: pavana.sharma, vivien.didelot, f.fainelli, lkp, ashkan.boldaji,
	andrew, Chris Packham, olteanv, Rob Herring, Marek Behún

From: Pavana Sharma <pavana.sharma@digi.com>

Add 5gbase-r PHY interface mode.

Signed-off-by: Pavana Sharma <pavana.sharma@digi.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Marek Behún <kabel@kernel.org>
---
 Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
index dac4aadb6e2e..f599c1d9c961 100644
--- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml
+++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
@@ -89,6 +89,7 @@ properties:
       - trgmii
       - 1000base-x
       - 2500base-x
+      - 5gbase-r
       - rxaui
       - xaui
 
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH net-next 2/4] net: phy: Add 5GBASER interface mode
  2021-02-16 19:20 [PATCH net-next 0/4] Add 5gbase-r PHY interface mode Marek Behún
  2021-02-16 19:20 ` [PATCH net-next 1/4] dt-bindings: net: Add 5GBASER phy interface Marek Behún
@ 2021-02-16 19:20 ` Marek Behún
  2021-02-16 19:20 ` [PATCH net-next 3/4] net: phylink: Add 5gbase-r support Marek Behún
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Marek Behún @ 2021-02-16 19:20 UTC (permalink / raw)
  To: netdev, Russell King - ARM Linux admin, davem, kuba
  Cc: pavana.sharma, vivien.didelot, f.fainelli, lkp, ashkan.boldaji,
	andrew, Chris Packham, olteanv, Marek Behún

From: Pavana Sharma <pavana.sharma@digi.com>

Add 5GBASE-R phy interface mode

Signed-off-by: Pavana Sharma <pavana.sharma@digi.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Marek Behún <kabel@kernel.org>
---
 Documentation/networking/phy.rst | 6 ++++++
 include/linux/phy.h              | 4 ++++
 2 files changed, 10 insertions(+)

diff --git a/Documentation/networking/phy.rst b/Documentation/networking/phy.rst
index 70136cc9e25e..06adfc2afcf0 100644
--- a/Documentation/networking/phy.rst
+++ b/Documentation/networking/phy.rst
@@ -267,6 +267,12 @@ Some of the interface modes are described below:
     duplex, pause or other settings.  This is dependent on the MAC and/or
     PHY behaviour.
 
+``PHY_INTERFACE_MODE_5GBASER``
+    This is the IEEE 802.3 Clause 129 defined 5GBASE-R protocol. It is
+    identical to the 10GBASE-R protocol defined in Clause 49, with the
+    exception that it operates at half the frequency. Please refer to the
+    IEEE standard for the definition.
+
 ``PHY_INTERFACE_MODE_10GBASER``
     This is the IEEE 802.3 Clause 49 defined 10GBASE-R protocol used with
     various different mediums. Please refer to the IEEE standard for a
diff --git a/include/linux/phy.h b/include/linux/phy.h
index 5d7c4084ade9..0d537f59b77f 100644
--- a/include/linux/phy.h
+++ b/include/linux/phy.h
@@ -107,6 +107,7 @@ extern const int phy_10gbit_features_array[1];
  * @PHY_INTERFACE_MODE_100BASEX: 100 BaseX
  * @PHY_INTERFACE_MODE_1000BASEX: 1000 BaseX
  * @PHY_INTERFACE_MODE_2500BASEX: 2500 BaseX
+ * @PHY_INTERFACE_MODE_5GBASER: 5G BaseR
  * @PHY_INTERFACE_MODE_RXAUI: Reduced XAUI
  * @PHY_INTERFACE_MODE_XAUI: 10 Gigabit Attachment Unit Interface
  * @PHY_INTERFACE_MODE_10GBASER: 10G BaseR
@@ -139,6 +140,7 @@ typedef enum {
 	PHY_INTERFACE_MODE_100BASEX,
 	PHY_INTERFACE_MODE_1000BASEX,
 	PHY_INTERFACE_MODE_2500BASEX,
+	PHY_INTERFACE_MODE_5GBASER,
 	PHY_INTERFACE_MODE_RXAUI,
 	PHY_INTERFACE_MODE_XAUI,
 	/* 10GBASE-R, XFI, SFI - single lane 10G Serdes */
@@ -209,6 +211,8 @@ static inline const char *phy_modes(phy_interface_t interface)
 		return "1000base-x";
 	case PHY_INTERFACE_MODE_2500BASEX:
 		return "2500base-x";
+	case PHY_INTERFACE_MODE_5GBASER:
+		return "5gbase-r";
 	case PHY_INTERFACE_MODE_RXAUI:
 		return "rxaui";
 	case PHY_INTERFACE_MODE_XAUI:
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH net-next 3/4] net: phylink: Add 5gbase-r support
  2021-02-16 19:20 [PATCH net-next 0/4] Add 5gbase-r PHY interface mode Marek Behún
  2021-02-16 19:20 ` [PATCH net-next 1/4] dt-bindings: net: Add 5GBASER phy interface Marek Behún
  2021-02-16 19:20 ` [PATCH net-next 2/4] net: phy: Add 5GBASER interface mode Marek Behún
@ 2021-02-16 19:20 ` Marek Behún
  2021-02-16 19:20 ` [PATCH net-next 4/4] sfp: add support for 5gbase-t SFPs Marek Behún
  2021-02-16 22:20 ` [PATCH net-next 0/4] Add 5gbase-r PHY interface mode patchwork-bot+netdevbpf
  4 siblings, 0 replies; 6+ messages in thread
From: Marek Behún @ 2021-02-16 19:20 UTC (permalink / raw)
  To: netdev, Russell King - ARM Linux admin, davem, kuba
  Cc: pavana.sharma, vivien.didelot, f.fainelli, lkp, ashkan.boldaji,
	andrew, Chris Packham, olteanv, Marek Behún

Add 5GBASER interface type and speed to phylink.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 drivers/net/phy/phylink.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index 84f6e197f965..053c92e02cd8 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -306,6 +306,10 @@ static int phylink_parse_mode(struct phylink *pl, struct fwnode_handle *fwnode)
 			phylink_set(pl->supported, 2500baseX_Full);
 			break;
 
+		case PHY_INTERFACE_MODE_5GBASER:
+			phylink_set(pl->supported, 5000baseT_Full);
+			break;
+
 		case PHY_INTERFACE_MODE_USXGMII:
 		case PHY_INTERFACE_MODE_10GKR:
 		case PHY_INTERFACE_MODE_10GBASER:
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH net-next 4/4] sfp: add support for 5gbase-t SFPs
  2021-02-16 19:20 [PATCH net-next 0/4] Add 5gbase-r PHY interface mode Marek Behún
                   ` (2 preceding siblings ...)
  2021-02-16 19:20 ` [PATCH net-next 3/4] net: phylink: Add 5gbase-r support Marek Behún
@ 2021-02-16 19:20 ` Marek Behún
  2021-02-16 22:20 ` [PATCH net-next 0/4] Add 5gbase-r PHY interface mode patchwork-bot+netdevbpf
  4 siblings, 0 replies; 6+ messages in thread
From: Marek Behún @ 2021-02-16 19:20 UTC (permalink / raw)
  To: netdev, Russell King - ARM Linux admin, davem, kuba
  Cc: pavana.sharma, vivien.didelot, f.fainelli, lkp, ashkan.boldaji,
	andrew, Chris Packham, olteanv, Marek Behún

The sfp_parse_support() function is setting 5000baseT_Full in some cases.
Now that we have PHY_INTERFACE_MODE_5GBASER interface mode available,
change sfp_select_interface() to return PHY_INTERFACE_MODE_5GBASER if
5000baseT_Full is set in the link mode mask.

Signed-off-by: Marek Behún <kabel@kernel.org>
---
 drivers/net/phy/sfp-bus.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/phy/sfp-bus.c b/drivers/net/phy/sfp-bus.c
index 3cfd773ae5f4..2e11176c6b94 100644
--- a/drivers/net/phy/sfp-bus.c
+++ b/drivers/net/phy/sfp-bus.c
@@ -400,6 +400,9 @@ phy_interface_t sfp_select_interface(struct sfp_bus *bus,
 	    phylink_test(link_modes, 10000baseT_Full))
 		return PHY_INTERFACE_MODE_10GBASER;
 
+	if (phylink_test(link_modes, 5000baseT_Full))
+		return PHY_INTERFACE_MODE_5GBASER;
+
 	if (phylink_test(link_modes, 2500baseX_Full))
 		return PHY_INTERFACE_MODE_2500BASEX;
 
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH net-next 0/4] Add 5gbase-r PHY interface mode
  2021-02-16 19:20 [PATCH net-next 0/4] Add 5gbase-r PHY interface mode Marek Behún
                   ` (3 preceding siblings ...)
  2021-02-16 19:20 ` [PATCH net-next 4/4] sfp: add support for 5gbase-t SFPs Marek Behún
@ 2021-02-16 22:20 ` patchwork-bot+netdevbpf
  4 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-02-16 22:20 UTC (permalink / raw)
  To: =?utf-8?q?Marek_Beh=C3=BAn_=3Ckabel=40kernel=2Eorg=3E?=
  Cc: netdev, linux, davem, kuba, pavana.sharma, vivien.didelot,
	f.fainelli, lkp, ashkan.boldaji, andrew, chris.packham, olteanv

Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Tue, 16 Feb 2021 20:20:51 +0100 you wrote:
> Hello,
> 
> there is still some testing needed for Amethyst patches, so I have
> split the part adding support for 5gbase-r interface mode and am sending
> it alone.
> 
> The first two patches are already reviewed.
> 
> [...]

Here is the summary with links:
  - [net-next,1/4] dt-bindings: net: Add 5GBASER phy interface
    https://git.kernel.org/netdev/net-next/c/4b08de909061
  - [net-next,2/4] net: phy: Add 5GBASER interface mode
    https://git.kernel.org/netdev/net-next/c/7331d1d4622b
  - [net-next,3/4] net: phylink: Add 5gbase-r support
    https://git.kernel.org/netdev/net-next/c/f6813bdafdb3
  - [net-next,4/4] sfp: add support for 5gbase-t SFPs
    https://git.kernel.org/netdev/net-next/c/cfb971dec56b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-02-16 22:21 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-16 19:20 [PATCH net-next 0/4] Add 5gbase-r PHY interface mode Marek Behún
2021-02-16 19:20 ` [PATCH net-next 1/4] dt-bindings: net: Add 5GBASER phy interface Marek Behún
2021-02-16 19:20 ` [PATCH net-next 2/4] net: phy: Add 5GBASER interface mode Marek Behún
2021-02-16 19:20 ` [PATCH net-next 3/4] net: phylink: Add 5gbase-r support Marek Behún
2021-02-16 19:20 ` [PATCH net-next 4/4] sfp: add support for 5gbase-t SFPs Marek Behún
2021-02-16 22:20 ` [PATCH net-next 0/4] Add 5gbase-r PHY interface mode patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).