* [PATCH net-next] net: xilinx: drivers need/depend on HAS_IOMEM
@ 2021-04-17 6:55 Randy Dunlap
2021-04-19 22:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2021-04-17 6:55 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, kernel test robot, Radhey Shyam Pandey, Gary Guo,
Zhang Changzhong, Andre Przywara, stable, Daniel Borkmann,
David S. Miller, Jakub Kicinski, netdev
kernel test robot reports build errors in 3 Xilinx ethernet drivers.
They all use ioremap functions that are only available when HAS_IOMEM
is set/enabled. If it is not enabled, they all have build errors,
so make these 3 drivers depend on HAS_IOMEM.
ld: drivers/net/ethernet/xilinx/xilinx_emaclite.o: in function `xemaclite_of_probe':
xilinx_emaclite.c:(.text+0x9fc): undefined reference to `devm_ioremap_resource'
ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.o: in function `axienet_probe':
xilinx_axienet_main.c:(.text+0x942): undefined reference to `devm_ioremap_resource'
ld: drivers/net/ethernet/xilinx/ll_temac_main.o: in function `temac_probe':
ll_temac_main.c:(.text+0x1283): undefined reference to `devm_platform_ioremap_resource_byname'
ld: ll_temac_main.c:(.text+0x13ad): undefined reference to `devm_of_iomap'
ld: ll_temac_main.c:(.text+0x162e): undefined reference to `devm_platform_ioremap_resource'
Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <lkp@intel.com>
Cc: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Cc: Gary Guo <gary@garyguo.net>
Cc: Zhang Changzhong <zhangchangzhong@huawei.com>
Cc: Andre Przywara <andre.przywara@arm.com>
Cc: stable@vger.kernel.org
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
---
drivers/net/ethernet/xilinx/Kconfig | 3 +++
1 file changed, 3 insertions(+)
--- linux-next-20210416.orig/drivers/net/ethernet/xilinx/Kconfig
+++ linux-next-20210416/drivers/net/ethernet/xilinx/Kconfig
@@ -18,12 +18,14 @@ if NET_VENDOR_XILINX
config XILINX_EMACLITE
tristate "Xilinx 10/100 Ethernet Lite support"
+ depends on HAS_IOMEM
select PHYLIB
help
This driver supports the 10/100 Ethernet Lite from Xilinx.
config XILINX_AXI_EMAC
tristate "Xilinx 10/100/1000 AXI Ethernet support"
+ depends on HAS_IOMEM
select PHYLINK
help
This driver supports the 10/100/1000 Ethernet from Xilinx for the
@@ -31,6 +33,7 @@ config XILINX_AXI_EMAC
config XILINX_LL_TEMAC
tristate "Xilinx LL TEMAC (LocalLink Tri-mode Ethernet MAC) driver"
+ depends on HAS_IOMEM
select PHYLIB
help
This driver supports the Xilinx 10/100/1000 LocalLink TEMAC
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: xilinx: drivers need/depend on HAS_IOMEM
2021-04-17 6:55 [PATCH net-next] net: xilinx: drivers need/depend on HAS_IOMEM Randy Dunlap
@ 2021-04-19 22:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-04-19 22:40 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, lkp, radhey.shyam.pandey, gary, zhangchangzhong,
andre.przywara, stable, daniel, davem, kuba, netdev
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Fri, 16 Apr 2021 23:55:54 -0700 you wrote:
> kernel test robot reports build errors in 3 Xilinx ethernet drivers.
> They all use ioremap functions that are only available when HAS_IOMEM
> is set/enabled. If it is not enabled, they all have build errors,
> so make these 3 drivers depend on HAS_IOMEM.
>
> ld: drivers/net/ethernet/xilinx/xilinx_emaclite.o: in function `xemaclite_of_probe':
> xilinx_emaclite.c:(.text+0x9fc): undefined reference to `devm_ioremap_resource'
>
> [...]
Here is the summary with links:
- [net-next] net: xilinx: drivers need/depend on HAS_IOMEM
https://git.kernel.org/netdev/net-next/c/46fd4471615c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-19 22:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-17 6:55 [PATCH net-next] net: xilinx: drivers need/depend on HAS_IOMEM Randy Dunlap
2021-04-19 22:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).