netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net 0/3] bnxt_en: Bug fixes
@ 2021-06-18  6:07 Michael Chan
  2021-06-18  6:07 ` [PATCH net 1/3] bnxt_en: Rediscover PHY capabilities after firmware reset Michael Chan
                   ` (3 more replies)
  0 siblings, 4 replies; 29+ messages in thread
From: Michael Chan @ 2021-06-18  6:07 UTC (permalink / raw)
  To: davem; +Cc: netdev, kuba, gospo

This patchset includes 3 small bug fixes to reinitialize PHY capabilities
after firmware reset, setup the chip's internal TQM fastpath ring
backing memory properly for RoCE traffic, and to free ethtool related
memory if driver probe fails.

Michael Chan (1):
  bnxt_en: Rediscover PHY capabilities after firmware reset

Rukhsana Ansari (1):
  bnxt_en: Fix TQM fastpath ring backing store computation

Somnath Kotur (1):
  bnxt_en: Call bnxt_ethtool_free() in bnxt_init_one() error path

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

-- 
2.18.1


^ permalink raw reply	[flat|nested] 29+ messages in thread

* [PATCH net 1/3] bnxt_en: Rediscover PHY capabilities after firmware reset
  2021-06-18  6:07 [PATCH net 0/3] bnxt_en: Bug fixes Michael Chan
@ 2021-06-18  6:07 ` Michael Chan
  2021-06-18  6:07 ` [PATCH net 2/3] bnxt_en: Fix TQM fastpath ring backing store computation Michael Chan
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 29+ messages in thread
From: Michael Chan @ 2021-06-18  6:07 UTC (permalink / raw)
  To: davem; +Cc: netdev, kuba, gospo

There is a missing bnxt_probe_phy() call in bnxt_fw_init_one() to
rediscover the PHY capabilities after a firmware reset.  This can cause
some PHY related functionalities to fail after a firmware reset.  For
example, in multi-host, the ability for any host to configure the PHY
settings may be lost after a firmware reset.

Fixes: ec5d31e3c15d ("bnxt_en: Handle firmware reset status during IF_UP.")
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index fcc729d52b17..3685db6dc93d 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -11750,6 +11750,8 @@ static void bnxt_fw_init_one_p3(struct bnxt *bp)
 	bnxt_hwrm_coal_params_qcaps(bp);
 }
 
+static int bnxt_probe_phy(struct bnxt *bp, bool fw_dflt);
+
 static int bnxt_fw_init_one(struct bnxt *bp)
 {
 	int rc;
@@ -11764,6 +11766,9 @@ static int bnxt_fw_init_one(struct bnxt *bp)
 		netdev_err(bp->dev, "Firmware init phase 2 failed\n");
 		return rc;
 	}
+	rc = bnxt_probe_phy(bp, false);
+	if (rc)
+		return rc;
 	rc = bnxt_approve_mac(bp, bp->dev->dev_addr, false);
 	if (rc)
 		return rc;
-- 
2.18.1


^ permalink raw reply related	[flat|nested] 29+ messages in thread

* [PATCH net 2/3] bnxt_en: Fix TQM fastpath ring backing store computation
  2021-06-18  6:07 [PATCH net 0/3] bnxt_en: Bug fixes Michael Chan
  2021-06-18  6:07 ` [PATCH net 1/3] bnxt_en: Rediscover PHY capabilities after firmware reset Michael Chan
@ 2021-06-18  6:07 ` Michael Chan
  2021-06-18  6:07 ` [PATCH net 3/3] bnxt_en: Call bnxt_ethtool_free() in bnxt_init_one() error path Michael Chan
  2021-06-18 19:10 ` [PATCH net 0/3] bnxt_en: Bug fixes patchwork-bot+netdevbpf
  3 siblings, 0 replies; 29+ messages in thread
From: Michael Chan @ 2021-06-18  6:07 UTC (permalink / raw)
  To: davem; +Cc: netdev, kuba, gospo

From: Rukhsana Ansari <rukhsana.ansari@broadcom.com>

TQM fastpath ring needs to be sized to store both the requester
and responder side of RoCE QPs in TQM for supporting bi-directional
tests.  Fix bnxt_alloc_ctx_mem() to multiply the RoCE QPs by a factor of
2 when computing the number of entries for TQM fastpath ring.  This
fixes an RX pipeline stall issue when running bi-directional max
RoCE QP tests.

Fixes: c7dd7ab4b204 ("bnxt_en: Improve TQM ring context memory sizing formulas.")
Signed-off-by: Rukhsana Ansari <rukhsana.ansari@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 3685db6dc93d..c913cb1f2a72 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -7308,7 +7308,7 @@ static int bnxt_alloc_ctx_mem(struct bnxt *bp)
 	entries_sp = ctx->vnic_max_vnic_entries + ctx->qp_max_l2_entries +
 		     2 * (extra_qps + ctx->qp_min_qp1_entries) + min;
 	entries_sp = roundup(entries_sp, ctx->tqm_entries_multiple);
-	entries = ctx->qp_max_l2_entries + extra_qps + ctx->qp_min_qp1_entries;
+	entries = ctx->qp_max_l2_entries + 2 * (extra_qps + ctx->qp_min_qp1_entries);
 	entries = roundup(entries, ctx->tqm_entries_multiple);
 	entries = clamp_t(u32, entries, min, ctx->tqm_max_entries_per_ring);
 	for (i = 0; i < ctx->tqm_fp_rings_count + 1; i++) {
-- 
2.18.1


^ permalink raw reply related	[flat|nested] 29+ messages in thread

* [PATCH net 3/3] bnxt_en: Call bnxt_ethtool_free() in bnxt_init_one() error path
  2021-06-18  6:07 [PATCH net 0/3] bnxt_en: Bug fixes Michael Chan
  2021-06-18  6:07 ` [PATCH net 1/3] bnxt_en: Rediscover PHY capabilities after firmware reset Michael Chan
  2021-06-18  6:07 ` [PATCH net 2/3] bnxt_en: Fix TQM fastpath ring backing store computation Michael Chan
@ 2021-06-18  6:07 ` Michael Chan
  2021-06-18 19:10 ` [PATCH net 0/3] bnxt_en: Bug fixes patchwork-bot+netdevbpf
  3 siblings, 0 replies; 29+ messages in thread
From: Michael Chan @ 2021-06-18  6:07 UTC (permalink / raw)
  To: davem; +Cc: netdev, kuba, gospo

From: Somnath Kotur <somnath.kotur@broadcom.com>

bnxt_ethtool_init() may have allocated some memory and we need to
call bnxt_ethtool_free() to properly unwind if bnxt_init_one()
fails.

Fixes: 7c3809181468 ("bnxt_en: Refactor bnxt_init_one() and turn on TPA support on 57500 chips.")
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index c913cb1f2a72..aef3fccc27a9 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -13160,6 +13160,7 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 	bnxt_hwrm_func_drv_unrgtr(bp);
 	bnxt_free_hwrm_short_cmd_req(bp);
 	bnxt_free_hwrm_resources(bp);
+	bnxt_ethtool_free(bp);
 	kfree(bp->fw_health);
 	bp->fw_health = NULL;
 	bnxt_cleanup_pci(bp);
-- 
2.18.1


^ permalink raw reply related	[flat|nested] 29+ messages in thread

* Re: [PATCH net 0/3] bnxt_en: Bug fixes
  2021-06-18  6:07 [PATCH net 0/3] bnxt_en: Bug fixes Michael Chan
                   ` (2 preceding siblings ...)
  2021-06-18  6:07 ` [PATCH net 3/3] bnxt_en: Call bnxt_ethtool_free() in bnxt_init_one() error path Michael Chan
@ 2021-06-18 19:10 ` patchwork-bot+netdevbpf
  3 siblings, 0 replies; 29+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-18 19:10 UTC (permalink / raw)
  To: Michael Chan; +Cc: davem, netdev, kuba, gospo

Hello:

This series was applied to netdev/net.git (refs/heads/master):

On Fri, 18 Jun 2021 02:07:24 -0400 you wrote:
> This patchset includes 3 small bug fixes to reinitialize PHY capabilities
> after firmware reset, setup the chip's internal TQM fastpath ring
> backing memory properly for RoCE traffic, and to free ethtool related
> memory if driver probe fails.
> 
> Michael Chan (1):
>   bnxt_en: Rediscover PHY capabilities after firmware reset
> 
> [...]

Here is the summary with links:
  - [net,1/3] bnxt_en: Rediscover PHY capabilities after firmware reset
    https://git.kernel.org/netdev/net/c/0afd6a4e8028
  - [net,2/3] bnxt_en: Fix TQM fastpath ring backing store computation
    https://git.kernel.org/netdev/net/c/c12e1643d273
  - [net,3/3] bnxt_en: Call bnxt_ethtool_free() in bnxt_init_one() error path
    https://git.kernel.org/netdev/net/c/03400aaa69f9

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PATCH net 0/3] bnxt_en: Bug fixes
  2024-04-05 23:55 Michael Chan
@ 2024-04-08 13:00 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 29+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-04-08 13:00 UTC (permalink / raw)
  To: Michael Chan
  Cc: davem, netdev, edumazet, kuba, pabeni, pavan.chebbi, andrew.gospodarek

Hello:

This series was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Fri,  5 Apr 2024 16:55:10 -0700 you wrote:
> The first 2 patches fix 2 potential issues in the aux bus initialization
> and error recovery paths.  The 3rd patch fixes a potential PTP TX
> timestamp issue during error recovery.
> 
> Pavan Chebbi (1):
>   bnxt_en: Reset PTP tx_avail after possible firmware reset
> 
> [...]

Here is the summary with links:
  - [net,1/3] bnxt_en: Fix possible memory leak in bnxt_rdma_aux_device_init()
    https://git.kernel.org/netdev/net/c/7ac10c7d728d
  - [net,2/3] bnxt_en: Fix error recovery for RoCE ulp client
    https://git.kernel.org/netdev/net/c/b5ea7d33ba2a
  - [net,3/3] bnxt_en: Reset PTP tx_avail after possible firmware reset
    https://git.kernel.org/netdev/net/c/faa12ca24558

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 29+ messages in thread

* [PATCH net 0/3] bnxt_en: Bug fixes
@ 2024-04-05 23:55 Michael Chan
  2024-04-08 13:00 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 29+ messages in thread
From: Michael Chan @ 2024-04-05 23:55 UTC (permalink / raw)
  To: davem; +Cc: netdev, edumazet, kuba, pabeni, pavan.chebbi, andrew.gospodarek

[-- Attachment #1: Type: text/plain, Size: 567 bytes --]

The first 2 patches fix 2 potential issues in the aux bus initialization
and error recovery paths.  The 3rd patch fixes a potential PTP TX
timestamp issue during error recovery.

Pavan Chebbi (1):
  bnxt_en: Reset PTP tx_avail after possible firmware reset

Vikas Gupta (2):
  bnxt_en: Fix possible memory leak in bnxt_rdma_aux_device_init()
  bnxt_en: Fix error recovery for RoCE ulp client

 drivers/net/ethernet/broadcom/bnxt/bnxt.c     | 2 ++
 drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 6 +++++-
 2 files changed, 7 insertions(+), 1 deletion(-)

-- 
2.30.1


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PATCH net 0/3] bnxt_en: Bug fixes
  2022-05-03  1:13 Michael Chan
@ 2022-05-04  1:00 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 29+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-05-04  1:00 UTC (permalink / raw)
  To: Michael Chan; +Cc: davem, netdev, kuba, gospo

Hello:

This series was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Mon,  2 May 2022 21:13:09 -0400 you wrote:
> This patch series includes 3 fixes:
> 
> 1. Fix an occasional VF open failure.
> 2. Fix a PTP spinlock usage before initialization
> 3. Fix unnecesary RX packet drops under high TX traffic load.
> 
> Michael Chan (2):
>   bnxt_en: Initiallize bp->ptp_lock first before using it
>   bnxt_en: Fix unnecessary dropping of RX packets
> 
> [...]

Here is the summary with links:
  - [net,1/3] bnxt_en: Fix possible bnxt_open() failure caused by wrong RFS flag
    https://git.kernel.org/netdev/net/c/13ba794397e4
  - [net,2/3] bnxt_en: Initiallize bp->ptp_lock first before using it
    https://git.kernel.org/netdev/net/c/2b156fb57d8f
  - [net,3/3] bnxt_en: Fix unnecessary dropping of RX packets
    https://git.kernel.org/netdev/net/c/195af57914d1

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 29+ messages in thread

* [PATCH net 0/3] bnxt_en: Bug fixes
@ 2022-05-03  1:13 Michael Chan
  2022-05-04  1:00 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 29+ messages in thread
From: Michael Chan @ 2022-05-03  1:13 UTC (permalink / raw)
  To: davem; +Cc: netdev, kuba, gospo

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

This patch series includes 3 fixes:

1. Fix an occasional VF open failure.
2. Fix a PTP spinlock usage before initialization
3. Fix unnecesary RX packet drops under high TX traffic load. 

Michael Chan (2):
  bnxt_en: Initiallize bp->ptp_lock first before using it
  bnxt_en: Fix unnecessary dropping of RX packets

Somnath Kotur (1):
  bnxt_en: Fix possible bnxt_open() failure caused by wrong RFS flag

 drivers/net/ethernet/broadcom/bnxt/bnxt.c     | 13 ++++++++-----
 drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 15 +++++++--------
 2 files changed, 15 insertions(+), 13 deletions(-)

-- 
2.18.1


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PATCH net 0/3] bnxt_en: Bug fixes
  2021-11-15  7:37 Michael Chan
@ 2021-11-15 14:20 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 29+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-11-15 14:20 UTC (permalink / raw)
  To: Michael Chan; +Cc: davem, netdev, kuba, edwin.peer, gospo

Hello:

This series was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Mon, 15 Nov 2021 02:37:58 -0500 you wrote:
> This series includes 3 fixes.  The first one fixes a race condition
> between devlink reload and SR-IOV configuration.  The second one
> fixes a type mismatch warning in devlink fw live patching.  The
> last one fixes unwanted OVS TC dmesg error logs when tc-hw-offload is
> disabled on bnxt_en.
> 
> Edwin Peer (2):
>   bnxt_en: extend RTNL to VF check in devlink driver_reinit
>   bnxt_en: fix format specifier in live patch error message
> 
> [...]

Here is the summary with links:
  - [net,1/3] bnxt_en: extend RTNL to VF check in devlink driver_reinit
    https://git.kernel.org/netdev/net/c/46d08f55d24e
  - [net,2/3] bnxt_en: fix format specifier in live patch error message
    https://git.kernel.org/netdev/net/c/b68a1a933fe4
  - [net,3/3] bnxt_en: reject indirect blk offload when hw-tc-offload is off
    https://git.kernel.org/netdev/net/c/b0757491a118

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 29+ messages in thread

* [PATCH net 0/3] bnxt_en: Bug fixes
@ 2021-11-15  7:37 Michael Chan
  2021-11-15 14:20 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 29+ messages in thread
From: Michael Chan @ 2021-11-15  7:37 UTC (permalink / raw)
  To: davem; +Cc: netdev, kuba, edwin.peer, gospo

[-- Attachment #1: Type: text/plain, Size: 705 bytes --]

This series includes 3 fixes.  The first one fixes a race condition
between devlink reload and SR-IOV configuration.  The second one
fixes a type mismatch warning in devlink fw live patching.  The
last one fixes unwanted OVS TC dmesg error logs when tc-hw-offload is
disabled on bnxt_en.

Edwin Peer (2):
  bnxt_en: extend RTNL to VF check in devlink driver_reinit
  bnxt_en: fix format specifier in live patch error message

Sriharsha Basavapatna (1):
  bnxt_en: reject indirect blk offload when hw-tc-offload is off

 drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 9 +++++----
 drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c      | 2 +-
 2 files changed, 6 insertions(+), 5 deletions(-)

-- 
2.18.1


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PATCH net 0/3] bnxt_en: Bug fixes.
  2021-09-12 16:34 Michael Chan
@ 2021-09-13 11:40 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 29+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-09-13 11:40 UTC (permalink / raw)
  To: Michael Chan; +Cc: davem, netdev, kuba, edwin.peer, gospo

Hello:

This series was applied to netdev/net.git (refs/heads/master):

On Sun, 12 Sep 2021 12:34:46 -0400 you wrote:
> The first patch fixes an error recovery regression just introduced
> about a week ago.  The other two patches fix issues related to
> freeing rings in the bnxt_close() path under error conditions.
> 
> Edwin Peer (1):
>   bnxt_en: make bnxt_free_skbs() safe to call after bnxt_free_mem()
> 
> [...]

Here is the summary with links:
  - [net,1/3] bnxt_en: Fix error recovery regression
    https://git.kernel.org/netdev/net/c/eca4cf12acda
  - [net,2/3] bnxt_en: make bnxt_free_skbs() safe to call after bnxt_free_mem()
    https://git.kernel.org/netdev/net/c/1affc01fdc60
  - [net,3/3] bnxt_en: Clean up completion ring page arrays completely
    https://git.kernel.org/netdev/net/c/985941e1dd5e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 29+ messages in thread

* [PATCH net 0/3] bnxt_en: Bug fixes.
@ 2021-09-12 16:34 Michael Chan
  2021-09-13 11:40 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 29+ messages in thread
From: Michael Chan @ 2021-09-12 16:34 UTC (permalink / raw)
  To: davem; +Cc: netdev, kuba, edwin.peer, gospo

[-- Attachment #1: Type: text/plain, Size: 533 bytes --]

The first patch fixes an error recovery regression just introduced
about a week ago.  The other two patches fix issues related to
freeing rings in the bnxt_close() path under error conditions.

Edwin Peer (1):
  bnxt_en: make bnxt_free_skbs() safe to call after bnxt_free_mem()

Michael Chan (2):
  bnxt_en: Fix error recovery regression
  bnxt_en: Clean up completion ring page arrays completely

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 33 ++++++++++++++++++++---
 1 file changed, 29 insertions(+), 4 deletions(-)

-- 
2.18.1


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PATCH net 0/3] bnxt_en: Bug fixes.
  2020-05-25 21:41 Michael Chan
@ 2020-05-27  3:31 ` David Miller
  0 siblings, 0 replies; 29+ messages in thread
From: David Miller @ 2020-05-27  3:31 UTC (permalink / raw)
  To: michael.chan; +Cc: netdev

From: Michael Chan <michael.chan@broadcom.com>
Date: Mon, 25 May 2020 17:41:16 -0400

> 3 bnxt_en driver fixes, covering a bug in preserving the counters during
> some resets, proper error code when flashing NVRAM fails, and an
> endian bug when extracting the firmware response message length.

Series applied.

> Please also queue these for -stable.  Thanks.

Queued up.

Thanks.

^ permalink raw reply	[flat|nested] 29+ messages in thread

* [PATCH net 0/3] bnxt_en: Bug fixes.
@ 2020-05-25 21:41 Michael Chan
  2020-05-27  3:31 ` David Miller
  0 siblings, 1 reply; 29+ messages in thread
From: Michael Chan @ 2020-05-25 21:41 UTC (permalink / raw)
  To: davem; +Cc: netdev

3 bnxt_en driver fixes, covering a bug in preserving the counters during
some resets, proper error code when flashing NVRAM fails, and an
endian bug when extracting the firmware response message length.

Please also queue these for -stable.  Thanks.

Edwin Peer (1):
  bnxt_en: fix firmware message length endianness

Michael Chan (1):
  bnxt_en: Fix accumulation of bp->net_stats_prev.

Vasundhara Volam (1):
  bnxt_en: Fix return code to "flash_device".

 drivers/net/ethernet/broadcom/bnxt/bnxt.c         | 16 +++++-----------
 drivers/net/ethernet/broadcom/bnxt/bnxt.h         |  5 -----
 drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c |  9 +++++----
 3 files changed, 10 insertions(+), 20 deletions(-)

-- 
2.5.1


^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PATCH net 0/3] bnxt_en: Bug fixes.
  2020-01-17  5:32 Michael Chan
@ 2020-01-18 13:48 ` David Miller
  0 siblings, 0 replies; 29+ messages in thread
From: David Miller @ 2020-01-18 13:48 UTC (permalink / raw)
  To: michael.chan; +Cc: netdev

From: Michael Chan <michael.chan@broadcom.com>
Date: Fri, 17 Jan 2020 00:32:44 -0500

> 3 small bug fix patches.  The 1st two are aRFS fixes and the last one
> fixes a fatal driver load failure on some kernels without PCIe
> extended config space support enabled.

Applied.

> Please also queue these for -stable.  Thanks.

Done.

^ permalink raw reply	[flat|nested] 29+ messages in thread

* [PATCH net 0/3] bnxt_en: Bug fixes.
@ 2020-01-17  5:32 Michael Chan
  2020-01-18 13:48 ` David Miller
  0 siblings, 1 reply; 29+ messages in thread
From: Michael Chan @ 2020-01-17  5:32 UTC (permalink / raw)
  To: davem; +Cc: netdev

3 small bug fix patches.  The 1st two are aRFS fixes and the last one
fixes a fatal driver load failure on some kernels without PCIe
extended config space support enabled.

Please also queue these for -stable.  Thanks.

Michael Chan (3):
  bnxt_en: Fix NTUPLE firmware command failures.
  bnxt_en: Fix ipv6 RFS filter matching logic.
  bnxt_en: Do not treat DSN (Digital Serial Number) read failure as
    fatal.

 drivers/net/ethernet/broadcom/bnxt/bnxt.c     | 29 ++++++++++++++++++---------
 drivers/net/ethernet/broadcom/bnxt/bnxt.h     |  4 +---
 drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c |  3 +++
 3 files changed, 24 insertions(+), 12 deletions(-)

-- 
2.5.1


^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PATCH net 0/3] bnxt_en: Bug fixes.
  2018-09-04  5:50   ` Michael Chan
@ 2018-09-04  6:30     ` Michael Chan
  0 siblings, 0 replies; 29+ messages in thread
From: Michael Chan @ 2018-09-04  6:30 UTC (permalink / raw)
  To: David Miller; +Cc: Netdev

On Mon, Sep 3, 2018 at 10:50 PM, Michael Chan <michael.chan@broadcom.com> wrote:
> On Mon, Sep 3, 2018 at 10:01 PM, David Miller <davem@davemloft.net> wrote:
>>
>> From: Michael Chan <michael.chan@broadcom.com>
>> Date: Mon,  3 Sep 2018 04:23:16 -0400
>>
>> > This short series fixes resource related logic in the driver, mostly
>> > affecting the RDMA driver under corner cases.
>>
>> Series applied, thanks Michael.
>>
>> Do you want patch #3 queued up for -stable?
>
> Yes, please go ahead.  Thanks.

But there is a dependency on patch #2 though.  So #2 needs to be queued as well.

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PATCH net 0/3] bnxt_en: Bug fixes.
  2018-09-04  5:01 ` David Miller
@ 2018-09-04  5:50   ` Michael Chan
  2018-09-04  6:30     ` Michael Chan
  0 siblings, 1 reply; 29+ messages in thread
From: Michael Chan @ 2018-09-04  5:50 UTC (permalink / raw)
  To: David Miller; +Cc: Netdev

On Mon, Sep 3, 2018 at 10:01 PM, David Miller <davem@davemloft.net> wrote:
>
> From: Michael Chan <michael.chan@broadcom.com>
> Date: Mon,  3 Sep 2018 04:23:16 -0400
>
> > This short series fixes resource related logic in the driver, mostly
> > affecting the RDMA driver under corner cases.
>
> Series applied, thanks Michael.
>
> Do you want patch #3 queued up for -stable?

Yes, please go ahead.  Thanks.

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PATCH net 0/3] bnxt_en: Bug fixes.
  2018-09-03  8:23 Michael Chan
@ 2018-09-04  5:01 ` David Miller
  2018-09-04  5:50   ` Michael Chan
  0 siblings, 1 reply; 29+ messages in thread
From: David Miller @ 2018-09-04  5:01 UTC (permalink / raw)
  To: michael.chan; +Cc: netdev

From: Michael Chan <michael.chan@broadcom.com>
Date: Mon,  3 Sep 2018 04:23:16 -0400

> This short series fixes resource related logic in the driver, mostly
> affecting the RDMA driver under corner cases.

Series applied, thanks Michael.

Do you want patch #3 queued up for -stable?

^ permalink raw reply	[flat|nested] 29+ messages in thread

* [PATCH net 0/3] bnxt_en: Bug fixes.
@ 2018-09-03  8:23 Michael Chan
  2018-09-04  5:01 ` David Miller
  0 siblings, 1 reply; 29+ messages in thread
From: Michael Chan @ 2018-09-03  8:23 UTC (permalink / raw)
  To: davem; +Cc: netdev

This short series fixes resource related logic in the driver, mostly
affecting the RDMA driver under corner cases.

Michael Chan (3):
  bnxt_en: Fix firmware signaled resource change logic in open.
  bnxt_en: Clean up unused functions.
  bnxt_en: Do not adjust max_cp_rings by the ones used by RDMA.

 drivers/net/ethernet/broadcom/bnxt/bnxt.c       | 22 +++++++++++++++-------
 drivers/net/ethernet/broadcom/bnxt/bnxt.h       |  3 +--
 drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c |  7 ++++---
 drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c   | 20 --------------------
 drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.h   |  1 -
 5 files changed, 20 insertions(+), 33 deletions(-)

-- 
2.5.1

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PATCH net 0/3] bnxt_en: bug fixes.
  2017-08-23 23:34 [PATCH net 0/3] bnxt_en: bug fixes Michael Chan
@ 2017-08-24  5:42 ` David Miller
  0 siblings, 0 replies; 29+ messages in thread
From: David Miller @ 2017-08-24  5:42 UTC (permalink / raw)
  To: michael.chan; +Cc: netdev

From: Michael Chan <michael.chan@broadcom.com>
Date: Wed, 23 Aug 2017 19:34:02 -0400

> 3 bug fixes related to XDP ring accounting in bnxt_setup_tc(), freeing
> MSIX vectors when bnxt_re unregisters, and preserving the user-administered
> PF MAC address when disabling SRIOV.

Series applied, thanks.

^ permalink raw reply	[flat|nested] 29+ messages in thread

* [PATCH net 0/3] bnxt_en: bug fixes.
@ 2017-08-23 23:34 Michael Chan
  2017-08-24  5:42 ` David Miller
  0 siblings, 1 reply; 29+ messages in thread
From: Michael Chan @ 2017-08-23 23:34 UTC (permalink / raw)
  To: davem; +Cc: netdev

3 bug fixes related to XDP ring accounting in bnxt_setup_tc(), freeing
MSIX vectors when bnxt_re unregisters, and preserving the user-administered
PF MAC address when disabling SRIOV.

Michael Chan (3):
  bnxt_en: Fix .ndo_setup_tc() to include XDP rings.
  bnxt_en: Free MSIX vectors when unregistering the device from bnxt_re.
  bnxt_en: Do not setup MAC address in bnxt_hwrm_func_qcaps().

 drivers/net/ethernet/broadcom/bnxt/bnxt.c     | 41 +++++++++++++++++++--------
 drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c |  2 ++
 2 files changed, 31 insertions(+), 12 deletions(-)

-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PATCH net 0/3] bnxt_en: Bug fixes.
  2017-07-11 17:05 [PATCH net 0/3] bnxt_en: Bug fixes Michael Chan
@ 2017-07-11 17:32 ` David Miller
  0 siblings, 0 replies; 29+ messages in thread
From: David Miller @ 2017-07-11 17:32 UTC (permalink / raw)
  To: michael.chan; +Cc: netdev

From: Michael Chan <michael.chan@broadcom.com>
Date: Tue, 11 Jul 2017 13:05:33 -0400

> 3 bug fixes in this series.  Fix a crash in bnxt_get_stats64() that can
> happen if the device is closing and freeing the statistics block at the
> same time.  The 2nd one fixes ethtool -L failing when changing from
> combined to non-combined mode or vice versa.  The last one fixes SRIOV
> failure on big-endian systems because we were setting a bitmap wrong in
> a firmware message.

Series applied, thanks Michael.

We really should look into generically taking care of the ->ndo_close()
vs. statistics pulling synchronization so that every driver doesn't
need to have code like this.

^ permalink raw reply	[flat|nested] 29+ messages in thread

* [PATCH net 0/3] bnxt_en: Bug fixes.
@ 2017-07-11 17:05 Michael Chan
  2017-07-11 17:32 ` David Miller
  0 siblings, 1 reply; 29+ messages in thread
From: Michael Chan @ 2017-07-11 17:05 UTC (permalink / raw)
  To: davem; +Cc: netdev

3 bug fixes in this series.  Fix a crash in bnxt_get_stats64() that can
happen if the device is closing and freeing the statistics block at the
same time.  The 2nd one fixes ethtool -L failing when changing from
combined to non-combined mode or vice versa.  The last one fixes SRIOV
failure on big-endian systems because we were setting a bitmap wrong in
a firmware message.

Michael Chan (3):
  bnxt_en: Fix race conditions in .ndo_get_stats64().
  bnxt_en: Fix bug in ethtool -L.
  bnxt_en: Fix SRIOV on big-endian architecture.

 drivers/net/ethernet/broadcom/bnxt/bnxt.c         | 42 ++++++++++++++++-------
 drivers/net/ethernet/broadcom/bnxt/bnxt.h         |  4 ++-
 drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c |  3 +-
 drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c     |  2 +-
 4 files changed, 35 insertions(+), 16 deletions(-)

-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PATCH net 0/3] bnxt_en: Bug fixes.
  2016-06-06  6:37 Michael Chan
@ 2016-06-07 23:02 ` David Miller
  0 siblings, 0 replies; 29+ messages in thread
From: David Miller @ 2016-06-07 23:02 UTC (permalink / raw)
  To: michael.chan; +Cc: netdev

From: Michael Chan <michael.chan@broadcom.com>
Date: Mon,  6 Jun 2016 02:37:13 -0400

> Fix a race condition and VLAN rx acceleration logic.

Series applied.

^ permalink raw reply	[flat|nested] 29+ messages in thread

* [PATCH net 0/3] bnxt_en: Bug fixes.
@ 2016-06-06  6:37 Michael Chan
  2016-06-07 23:02 ` David Miller
  0 siblings, 1 reply; 29+ messages in thread
From: Michael Chan @ 2016-06-06  6:37 UTC (permalink / raw)
  To: davem; +Cc: netdev

Fix a race condition and VLAN rx acceleration logic.

Michael Chan (3):
  bnxt_en: Fix tx push race condition.
  bnxt_en: Enable and disable RX CTAG and RX STAG VLAN acceleration
    together.
  bnxt_en: Simplify VLAN receive logic.

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 47 +++++++++++++++++--------------
 1 file changed, 26 insertions(+), 21 deletions(-)

-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PATCH net 0/3] bnxt_en: Bug fixes.
  2016-01-28  8:11 Michael Chan
@ 2016-01-30  1:28 ` David Miller
  0 siblings, 0 replies; 29+ messages in thread
From: David Miller @ 2016-01-30  1:28 UTC (permalink / raw)
  To: mchan; +Cc: netdev

From: Michael Chan <mchan@broadcom.com>
Date: Thu, 28 Jan 2016 03:11:19 -0500

> 3 small bug fix patches for net.

Series applied, thanks Michael.

^ permalink raw reply	[flat|nested] 29+ messages in thread

* [PATCH net 0/3] bnxt_en: Bug fixes.
@ 2016-01-28  8:11 Michael Chan
  2016-01-30  1:28 ` David Miller
  0 siblings, 1 reply; 29+ messages in thread
From: Michael Chan @ 2016-01-28  8:11 UTC (permalink / raw)
  To: davem; +Cc: netdev

3 small bug fix patches for net.

Michael Chan (3):
  bnxt_en: Ring free response from close path should use completion ring
  bnxt_en: Exclude rx_drop_pkts hw counter from the stack's rx_dropped
    counter.
  bnxt_en: Fix crash in bnxt_free_tx_skbs() during tx timeout.

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 29+ messages in thread

end of thread, other threads:[~2024-04-08 13:00 UTC | newest]

Thread overview: 29+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-18  6:07 [PATCH net 0/3] bnxt_en: Bug fixes Michael Chan
2021-06-18  6:07 ` [PATCH net 1/3] bnxt_en: Rediscover PHY capabilities after firmware reset Michael Chan
2021-06-18  6:07 ` [PATCH net 2/3] bnxt_en: Fix TQM fastpath ring backing store computation Michael Chan
2021-06-18  6:07 ` [PATCH net 3/3] bnxt_en: Call bnxt_ethtool_free() in bnxt_init_one() error path Michael Chan
2021-06-18 19:10 ` [PATCH net 0/3] bnxt_en: Bug fixes patchwork-bot+netdevbpf
  -- strict thread matches above, loose matches on Subject: below --
2024-04-05 23:55 Michael Chan
2024-04-08 13:00 ` patchwork-bot+netdevbpf
2022-05-03  1:13 Michael Chan
2022-05-04  1:00 ` patchwork-bot+netdevbpf
2021-11-15  7:37 Michael Chan
2021-11-15 14:20 ` patchwork-bot+netdevbpf
2021-09-12 16:34 Michael Chan
2021-09-13 11:40 ` patchwork-bot+netdevbpf
2020-05-25 21:41 Michael Chan
2020-05-27  3:31 ` David Miller
2020-01-17  5:32 Michael Chan
2020-01-18 13:48 ` David Miller
2018-09-03  8:23 Michael Chan
2018-09-04  5:01 ` David Miller
2018-09-04  5:50   ` Michael Chan
2018-09-04  6:30     ` Michael Chan
2017-08-23 23:34 [PATCH net 0/3] bnxt_en: bug fixes Michael Chan
2017-08-24  5:42 ` David Miller
2017-07-11 17:05 [PATCH net 0/3] bnxt_en: Bug fixes Michael Chan
2017-07-11 17:32 ` David Miller
2016-06-06  6:37 Michael Chan
2016-06-07 23:02 ` David Miller
2016-01-28  8:11 Michael Chan
2016-01-30  1:28 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).