netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] gve: report 64bit tx_bytes counter from gve_handle_report_stats()
@ 2021-10-06  1:01 Eric Dumazet
  2021-10-06 14:20 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2021-10-06  1:01 UTC (permalink / raw)
  To: David S . Miller, Jakub Kicinski
  Cc: netdev, Eric Dumazet, Eric Dumazet, Yangchun Fu, Kuo Zhao,
	David Awogbemila

From: Eric Dumazet <edumazet@google.com>

Each tx queue maintains a 64bit counter for bytes, there is
no reason to truncate this to 32bit (or this has not been
documented)

Fixes: 24aeb56f2d38 ("gve: Add Gvnic stats AQ command and ethtool show/set-priv-flags.")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Yangchun Fu <yangchun@google.com>
Cc: Kuo Zhao <kuozhao@google.com>
Cc: David Awogbemila <awogbemila@google.com>
---
 drivers/net/ethernet/google/gve/gve_main.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ethernet/google/gve/gve_main.c
index 99837c9d2cba698ada900229330cb10bc1606a6b..fc7cdf934ddc6cb336a86ef05b1a4fcdf73cb69a 100644
--- a/drivers/net/ethernet/google/gve/gve_main.c
+++ b/drivers/net/ethernet/google/gve/gve_main.c
@@ -1190,9 +1190,10 @@ static void gve_handle_reset(struct gve_priv *priv)
 
 void gve_handle_report_stats(struct gve_priv *priv)
 {
-	int idx, stats_idx = 0, tx_bytes;
-	unsigned int start = 0;
 	struct stats *stats = priv->stats_report->stats;
+	int idx, stats_idx = 0;
+	unsigned int start = 0;
+	u64 tx_bytes;
 
 	if (!gve_get_report_stats(priv))
 		return;
-- 
2.33.0.800.g4c38ced690-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net] gve: report 64bit tx_bytes counter from gve_handle_report_stats()
  2021-10-06  1:01 [PATCH net] gve: report 64bit tx_bytes counter from gve_handle_report_stats() Eric Dumazet
@ 2021-10-06 14:20 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-10-06 14:20 UTC (permalink / raw)
  To: Eric Dumazet; +Cc: davem, kuba, netdev, edumazet, yangchun, kuozhao, awogbemila

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Tue,  5 Oct 2021 18:01:38 -0700 you wrote:
> From: Eric Dumazet <edumazet@google.com>
> 
> Each tx queue maintains a 64bit counter for bytes, there is
> no reason to truncate this to 32bit (or this has not been
> documented)
> 
> Fixes: 24aeb56f2d38 ("gve: Add Gvnic stats AQ command and ethtool show/set-priv-flags.")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Yangchun Fu <yangchun@google.com>
> Cc: Kuo Zhao <kuozhao@google.com>
> Cc: David Awogbemila <awogbemila@google.com>
> 
> [...]

Here is the summary with links:
  - [net] gve: report 64bit tx_bytes counter from gve_handle_report_stats()
    https://git.kernel.org/netdev/net/c/17c37d748f2b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-06 14:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-06  1:01 [PATCH net] gve: report 64bit tx_bytes counter from gve_handle_report_stats() Eric Dumazet
2021-10-06 14:20 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).