netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Fix coverity issue 'Uninitialized scalar variable"
@ 2021-11-21 15:02 Yacov Simhony
  2021-11-22 14:30 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Yacov Simhony @ 2021-11-21 15:02 UTC (permalink / raw)
  To: Nicolas Ferre, Claudiu Beznea, David S. Miller, Jakub Kicinski,
	netdev, linux-kernel

There are three boolean variable which were not initialized and later
being used in the code.

Signed-off-by: Yacov Simhony <ysimhony@gmail.com>
---
 drivers/net/ethernet/cadence/macb_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 57c5f48..d23c3f6 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -513,7 +513,7 @@ static void macb_validate(struct phylink_config *config,
 	struct net_device *ndev = to_net_dev(config->dev);
 	__ETHTOOL_DECLARE_LINK_MODE_MASK(mask) = { 0, };
 	struct macb *bp = netdev_priv(ndev);
-	bool have_1g, have_sgmii, have_10g;
+	bool have_1g=false, have_sgmii=false, have_10g=false;
 
 	/* Determine what modes are supported */
 	if (macb_is_gem(bp) &&
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix coverity issue 'Uninitialized scalar variable"
  2021-11-21 15:02 [PATCH] Fix coverity issue 'Uninitialized scalar variable" Yacov Simhony
@ 2021-11-22 14:30 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-11-22 14:30 UTC (permalink / raw)
  To: Yacov Simhony
  Cc: nicolas.ferre, claudiu.beznea, davem, kuba, netdev, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Sun, 21 Nov 2021 17:02:53 +0200 you wrote:
> There are three boolean variable which were not initialized and later
> being used in the code.
> 
> Signed-off-by: Yacov Simhony <ysimhony@gmail.com>
> ---
>  drivers/net/ethernet/cadence/macb_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - Fix coverity issue 'Uninitialized scalar variable"
    https://git.kernel.org/netdev/net-next/c/ac9f66ff04a9

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-22 14:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-21 15:02 [PATCH] Fix coverity issue 'Uninitialized scalar variable" Yacov Simhony
2021-11-22 14:30 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).