* [PATCH net-next] net: sparx5: remove phylink_config.pcs_poll usage
@ 2022-02-04 11:47 Russell King (Oracle)
2022-02-05 15:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Russell King (Oracle) @ 2022-02-04 11:47 UTC (permalink / raw)
To: Lars Povlsen, Steen Hegelund, UNGLinuxDriver
Cc: David S. Miller, Jakub Kicinski, netdev, linux-arm-kernel
Phylink will use PCS polling whenever phylink_config.pcs_poll or the
phylink_pcs poll member is set. As this driver sets both, remove the
former.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/ethernet/microchip/sparx5/sparx5_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_main.c b/drivers/net/ethernet/microchip/sparx5/sparx5_main.c
index 35689b5e212c..394de85d360d 100644
--- a/drivers/net/ethernet/microchip/sparx5/sparx5_main.c
+++ b/drivers/net/ethernet/microchip/sparx5/sparx5_main.c
@@ -291,7 +291,6 @@ static int sparx5_create_port(struct sparx5 *sparx5,
/* Create a phylink for PHY management. Also handles SFPs */
spx5_port->phylink_config.dev = &spx5_port->ndev->dev;
spx5_port->phylink_config.type = PHYLINK_NETDEV;
- spx5_port->phylink_config.pcs_poll = true;
spx5_port->phylink_config.mac_capabilities = MAC_ASYM_PAUSE |
MAC_SYM_PAUSE | MAC_10 | MAC_100 | MAC_1000FD |
MAC_2500FD | MAC_5000FD | MAC_10000FD | MAC_25000FD;
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: sparx5: remove phylink_config.pcs_poll usage
2022-02-04 11:47 [PATCH net-next] net: sparx5: remove phylink_config.pcs_poll usage Russell King (Oracle)
@ 2022-02-05 15:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-02-05 15:20 UTC (permalink / raw)
To: Russell King
Cc: lars.povlsen, Steen.Hegelund, UNGLinuxDriver, davem, kuba,
netdev, linux-arm-kernel
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Fri, 04 Feb 2022 11:47:53 +0000 you wrote:
> Phylink will use PCS polling whenever phylink_config.pcs_poll or the
> phylink_pcs poll member is set. As this driver sets both, remove the
> former.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---
> drivers/net/ethernet/microchip/sparx5/sparx5_main.c | 1 -
> 1 file changed, 1 deletion(-)
Here is the summary with links:
- [net-next] net: sparx5: remove phylink_config.pcs_poll usage
https://git.kernel.org/netdev/net-next/c/3682e7b841bc
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-05 15:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-04 11:47 [PATCH net-next] net: sparx5: remove phylink_config.pcs_poll usage Russell King (Oracle)
2022-02-05 15:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).