netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH iproute2-next v2] f_flower: fix indentation for enc_key_id and u32
@ 2022-02-10 12:57 Wojciech Drewek
  2022-02-17  3:40 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Wojciech Drewek @ 2022-02-10 12:57 UTC (permalink / raw)
  To: netdev; +Cc: dsahern, stephen

Commit b2450e46b7b2 ("flower: fix clang warnings") caused enc_key_id
and u32 to be printed without indentation. Fix this by printing two
spaces before calling print_uint_name_value.

Signed-off-by: Wojciech Drewek <wojciech.drewek@intel.com>
---
v2: use unsigned int instead of uint in print_uint_indent_name_value
---
 tc/f_flower.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/tc/f_flower.c b/tc/f_flower.c
index 1ff8341d27a6..6c1d0df62255 100644
--- a/tc/f_flower.c
+++ b/tc/f_flower.c
@@ -109,6 +109,12 @@ static void print_indent_name_value(const char *name, const char *value)
 	print_string_name_value(name, value);
 }
 
+static void print_uint_indent_name_value(const char *name, unsigned int value)
+{
+	print_string(PRINT_FP, NULL, "  ", NULL);
+	print_uint_name_value(name, value);
+}
+
 static int flower_parse_eth_addr(char *str, int addr_type, int mask_type,
 				 struct nlmsghdr *n)
 {
@@ -2324,7 +2330,7 @@ static void flower_print_key_id(const char *name, struct rtattr *attr)
 		return;
 
 	print_nl();
-	print_uint_name_value(name, rta_getattr_be32(attr));
+	print_uint_indent_name_value(name, rta_getattr_be32(attr));
 }
 
 static void flower_print_geneve_opts(const char *name, struct rtattr *attr,
@@ -2573,7 +2579,7 @@ static void flower_print_u32(const char *name, struct rtattr *attr)
 		return;
 
 	print_nl();
-	print_uint_name_value(name, rta_getattr_u32(attr));
+	print_uint_indent_name_value(name, rta_getattr_u32(attr));
 }
 
 static void flower_print_mpls_opt_lse(struct rtattr *lse)
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH iproute2-next v2] f_flower: fix indentation for enc_key_id and u32
  2022-02-10 12:57 [PATCH iproute2-next v2] f_flower: fix indentation for enc_key_id and u32 Wojciech Drewek
@ 2022-02-17  3:40 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-02-17  3:40 UTC (permalink / raw)
  To: Wojciech Drewek; +Cc: netdev, dsahern, stephen

Hello:

This patch was applied to iproute2/iproute2-next.git (main)
by David Ahern <dsahern@kernel.org>:

On Thu, 10 Feb 2022 13:57:15 +0100 you wrote:
> Commit b2450e46b7b2 ("flower: fix clang warnings") caused enc_key_id
> and u32 to be printed without indentation. Fix this by printing two
> spaces before calling print_uint_name_value.
> 
> Signed-off-by: Wojciech Drewek <wojciech.drewek@intel.com>
> ---
> v2: use unsigned int instead of uint in print_uint_indent_name_value
> 
> [...]

Here is the summary with links:
  - [iproute2-next,v2] f_flower: fix indentation for enc_key_id and u32
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=4f015972988a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-02-17  3:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-10 12:57 [PATCH iproute2-next v2] f_flower: fix indentation for enc_key_id and u32 Wojciech Drewek
2022-02-17  3:40 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).