* [PATCH net-next 0/2][pull request] 10GbE Intel Wired LAN Driver Updates 2022-05-05
@ 2022-05-05 15:56 Tony Nguyen
2022-05-05 15:56 ` [PATCH net-next 1/2] ixgbe: Fix module_param allow_unsupported_sfp type Tony Nguyen
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tony Nguyen @ 2022-05-05 15:56 UTC (permalink / raw)
To: davem, kuba, pabeni, edumazet; +Cc: Tony Nguyen, netdev
This series contains updates to ixgbe and igb drivers.
Jeff Daly adjusts type for 'allow_unsupported_sfp' to match the
associated struct value for ixgbe.
Alaa Mohamed converts, deprecated, kmap() call to kmap_local_page() for
igb.
The following are changes since commit 1c1ed5a48411e1686997157c21633653fbe045c6:
net: sparx5: Add handling of host MDB entries
and are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue 10GbE
Alaa Mohamed (1):
igb: Convert kmap() to kmap_local_page()
Jeff Daly (1):
ixgbe: Fix module_param allow_unsupported_sfp type
drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++--
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
--
2.35.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net-next 1/2] ixgbe: Fix module_param allow_unsupported_sfp type
2022-05-05 15:56 [PATCH net-next 0/2][pull request] 10GbE Intel Wired LAN Driver Updates 2022-05-05 Tony Nguyen
@ 2022-05-05 15:56 ` Tony Nguyen
2022-05-05 15:56 ` [PATCH net-next 2/2] igb: Convert kmap() to kmap_local_page() Tony Nguyen
2022-05-06 22:50 ` [PATCH net-next 0/2][pull request] 10GbE Intel Wired LAN Driver Updates 2022-05-05 patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Tony Nguyen @ 2022-05-05 15:56 UTC (permalink / raw)
To: davem, kuba, pabeni, edumazet
Cc: Jeff Daly, netdev, anthony.l.nguyen, Gurucharan
From: Jeff Daly <jeffd@silicom-usa.com>
The module_param allow_unsupported_sfp should be a boolean to match the
type in the ixgbe_hw struct.
Signed-off-by: Jeff Daly <jeffd@silicom-usa.com>
Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index c4a4954aa317..e5732a058bec 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -151,8 +151,8 @@ MODULE_PARM_DESC(max_vfs,
"Maximum number of virtual functions to allocate per physical function - default is zero and maximum value is 63. (Deprecated)");
#endif /* CONFIG_PCI_IOV */
-static unsigned int allow_unsupported_sfp;
-module_param(allow_unsupported_sfp, uint, 0);
+static bool allow_unsupported_sfp;
+module_param(allow_unsupported_sfp, bool, 0);
MODULE_PARM_DESC(allow_unsupported_sfp,
"Allow unsupported and untested SFP+ modules on 82599-based adapters");
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH net-next 2/2] igb: Convert kmap() to kmap_local_page()
2022-05-05 15:56 [PATCH net-next 0/2][pull request] 10GbE Intel Wired LAN Driver Updates 2022-05-05 Tony Nguyen
2022-05-05 15:56 ` [PATCH net-next 1/2] ixgbe: Fix module_param allow_unsupported_sfp type Tony Nguyen
@ 2022-05-05 15:56 ` Tony Nguyen
2022-05-06 22:50 ` [PATCH net-next 0/2][pull request] 10GbE Intel Wired LAN Driver Updates 2022-05-05 patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Tony Nguyen @ 2022-05-05 15:56 UTC (permalink / raw)
To: davem, kuba, pabeni, edumazet
Cc: Alaa Mohamed, netdev, anthony.l.nguyen, Ira Weiny, Gurucharan
From: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
kmap() is being deprecated and these usages are all local to the thread
so there is no reason kmap_local_page() can't be used.
Replace kmap() calls with kmap_local_page().
Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
index 2a5782063f4c..c14fc871dd41 100644
--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
@@ -1798,14 +1798,14 @@ static int igb_check_lbtest_frame(struct igb_rx_buffer *rx_buffer,
frame_size >>= 1;
- data = kmap(rx_buffer->page);
+ data = kmap_local_page(rx_buffer->page);
if (data[3] != 0xFF ||
data[frame_size + 10] != 0xBE ||
data[frame_size + 12] != 0xAF)
match = false;
- kunmap(rx_buffer->page);
+ kunmap_local(data);
return match;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next 0/2][pull request] 10GbE Intel Wired LAN Driver Updates 2022-05-05
2022-05-05 15:56 [PATCH net-next 0/2][pull request] 10GbE Intel Wired LAN Driver Updates 2022-05-05 Tony Nguyen
2022-05-05 15:56 ` [PATCH net-next 1/2] ixgbe: Fix module_param allow_unsupported_sfp type Tony Nguyen
2022-05-05 15:56 ` [PATCH net-next 2/2] igb: Convert kmap() to kmap_local_page() Tony Nguyen
@ 2022-05-06 22:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-05-06 22:50 UTC (permalink / raw)
To: Tony Nguyen; +Cc: davem, kuba, pabeni, edumazet, netdev
Hello:
This series was applied to netdev/net-next.git (master)
by Tony Nguyen <anthony.l.nguyen@intel.com>:
On Thu, 5 May 2022 08:56:49 -0700 you wrote:
> This series contains updates to ixgbe and igb drivers.
>
> Jeff Daly adjusts type for 'allow_unsupported_sfp' to match the
> associated struct value for ixgbe.
>
> Alaa Mohamed converts, deprecated, kmap() call to kmap_local_page() for
> igb.
>
> [...]
Here is the summary with links:
- [net-next,1/2] ixgbe: Fix module_param allow_unsupported_sfp type
https://git.kernel.org/netdev/net-next/c/833fbbbbfc8b
- [net-next,2/2] igb: Convert kmap() to kmap_local_page()
https://git.kernel.org/netdev/net-next/c/b35413f415c6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-06 22:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-05 15:56 [PATCH net-next 0/2][pull request] 10GbE Intel Wired LAN Driver Updates 2022-05-05 Tony Nguyen
2022-05-05 15:56 ` [PATCH net-next 1/2] ixgbe: Fix module_param allow_unsupported_sfp type Tony Nguyen
2022-05-05 15:56 ` [PATCH net-next 2/2] igb: Convert kmap() to kmap_local_page() Tony Nguyen
2022-05-06 22:50 ` [PATCH net-next 0/2][pull request] 10GbE Intel Wired LAN Driver Updates 2022-05-05 patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).