[PATCH net-next] eth: dpaa2-mac: remove a dead-code NULL check on fwnode parent

[PATCH net-next] eth: dpaa2-mac: remove a dead-code NULL check on fwnode parent

[Jakub Kicinski]

Since commit 4e30e98c4b4c ("dpaa2-mac: return -EPROBE_DEFER from dpaa2_mac_open in case the fwnode is not set")
@parent can't be NULL after the if. It's either the address
of the ->fwnode of @dpmacs or @fwnode in case of ACPI.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
Right, Ioana? Let's clean this up so the of_node_put() bots
go away.

CC: ioana.ciornei@nxp.com
---
 drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
index c48811d3bcd5..c9bee9a0c9b2 100644
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
@@ -108,9 +108,6 @@ static struct fwnode_handle *dpaa2_mac_get_node(struct device *dev,
 		return ERR_PTR(-EPROBE_DEFER);
 	}
 
-	if (!parent)
-		return NULL;
-
 	fwnode_for_each_child_node(parent, child) {
 		err = -EINVAL;
 		if (is_acpi_device_node(child))
-- 
2.34.1

Re: [PATCH net-next] eth: dpaa2-mac: remove a dead-code NULL check on fwnode parent

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat.com>:

On Fri,  6 May 2022 13:00:29 -0700 you wrote:
> Since commit 4e30e98c4b4c ("dpaa2-mac: return -EPROBE_DEFER from dpaa2_mac_open in case the fwnode is not set")
> @parent can't be NULL after the if. It's either the address
> of the ->fwnode of @dpmacs or @fwnode in case of ACPI.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> Right, Ioana? Let's clean this up so the of_node_put() bots
> go away.
> 
> [...]

Here is the summary with links:
  - [net-next] eth: dpaa2-mac: remove a dead-code NULL check on fwnode parent
    https://git.kernel.org/netdev/net-next/c/b3552d6a3b8b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html