* [PATCH net-next] selftests: forwarding: tc_actions: allow mirred egress test to run on non-offloaded h2
@ 2022-05-10 22:09 Vladimir Oltean
2022-05-11 7:07 ` Ido Schimmel
2022-05-11 22:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Vladimir Oltean @ 2022-05-10 22:09 UTC (permalink / raw)
To: netdev
Cc: Jakub Kicinski, David S. Miller, Paolo Abeni, Eric Dumazet,
Jiri Pirko, Ido Schimmel
The host interfaces $h1 and $h2 don't have to be switchdev interfaces,
but due to the fact that we pass $tcflags which may have the value of
"skip_sw", we force $h2 to offload a drop rule for dst_ip, something
which it may not be able to do.
The selftest only wants to verify the hit count of this rule as a means
of figuring out whether the packet was received, so remove the $tcflags
for it and let it be done in software.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
tools/testing/selftests/net/forwarding/tc_actions.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/forwarding/tc_actions.sh b/tools/testing/selftests/net/forwarding/tc_actions.sh
index de19eb6c38f0..1e0a62f638fe 100755
--- a/tools/testing/selftests/net/forwarding/tc_actions.sh
+++ b/tools/testing/selftests/net/forwarding/tc_actions.sh
@@ -60,7 +60,7 @@ mirred_egress_test()
RET=0
tc filter add dev $h2 ingress protocol ip pref 1 handle 101 flower \
- $tcflags dst_ip 192.0.2.2 action drop
+ dst_ip 192.0.2.2 action drop
$MZ $h1 -c 1 -p 64 -a $h1mac -b $h2mac -A 192.0.2.1 -B 192.0.2.2 \
-t ip -q
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] selftests: forwarding: tc_actions: allow mirred egress test to run on non-offloaded h2
2022-05-10 22:09 [PATCH net-next] selftests: forwarding: tc_actions: allow mirred egress test to run on non-offloaded h2 Vladimir Oltean
@ 2022-05-11 7:07 ` Ido Schimmel
2022-05-11 22:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Ido Schimmel @ 2022-05-11 7:07 UTC (permalink / raw)
To: Vladimir Oltean
Cc: netdev, Jakub Kicinski, David S. Miller, Paolo Abeni,
Eric Dumazet, Jiri Pirko, Ido Schimmel
On Wed, May 11, 2022 at 01:09:04AM +0300, Vladimir Oltean wrote:
> The host interfaces $h1 and $h2 don't have to be switchdev interfaces,
> but due to the fact that we pass $tcflags which may have the value of
> "skip_sw", we force $h2 to offload a drop rule for dst_ip, something
> which it may not be able to do.
>
> The selftest only wants to verify the hit count of this rule as a means
> of figuring out whether the packet was received, so remove the $tcflags
> for it and let it be done in software.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] selftests: forwarding: tc_actions: allow mirred egress test to run on non-offloaded h2
2022-05-10 22:09 [PATCH net-next] selftests: forwarding: tc_actions: allow mirred egress test to run on non-offloaded h2 Vladimir Oltean
2022-05-11 7:07 ` Ido Schimmel
@ 2022-05-11 22:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-05-11 22:30 UTC (permalink / raw)
To: Vladimir Oltean; +Cc: netdev, kuba, davem, pabeni, edumazet, jiri, idosch
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 11 May 2022 01:09:04 +0300 you wrote:
> The host interfaces $h1 and $h2 don't have to be switchdev interfaces,
> but due to the fact that we pass $tcflags which may have the value of
> "skip_sw", we force $h2 to offload a drop rule for dst_ip, something
> which it may not be able to do.
>
> The selftest only wants to verify the hit count of this rule as a means
> of figuring out whether the packet was received, so remove the $tcflags
> for it and let it be done in software.
>
> [...]
Here is the summary with links:
- [net-next] selftests: forwarding: tc_actions: allow mirred egress test to run on non-offloaded h2
https://git.kernel.org/netdev/net-next/c/b57c7e8b76c6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-11 22:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-10 22:09 [PATCH net-next] selftests: forwarding: tc_actions: allow mirred egress test to run on non-offloaded h2 Vladimir Oltean
2022-05-11 7:07 ` Ido Schimmel
2022-05-11 22:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).