* [PATCHv3 net] Documentation: add description for net.core.gro_normal_batch
@ 2022-05-18 16:09 Xin Long
2022-05-18 16:20 ` Jakub Kicinski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Xin Long @ 2022-05-18 16:09 UTC (permalink / raw)
To: network dev; +Cc: davem, kuba, Edward Cree
Describe it in admin-guide/sysctl/net.rst like other Network core options.
Users need to know gro_normal_batch for performance tuning.
Fixes: 323ebb61e32b ("net: use listified RX for handling GRO_NORMAL skbs")
Reported-by: Prijesh Patel <prpatel@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
---
v1->v2:
- improve the description according to the suggestion from Edward
and Jakub.
v2->v3:
- improve more for the description, and drop the default for
gro_normal_batch, suggested by Jakub.
Documentation/admin-guide/sysctl/net.rst | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/Documentation/admin-guide/sysctl/net.rst b/Documentation/admin-guide/sysctl/net.rst
index f86b5e1623c6..46b44fa82fa2 100644
--- a/Documentation/admin-guide/sysctl/net.rst
+++ b/Documentation/admin-guide/sysctl/net.rst
@@ -374,6 +374,15 @@ option is set to SOCK_TXREHASH_DEFAULT (i. e. not overridden by setsockopt).
If set to 1 (default), hash rethink is performed on listening socket.
If set to 0, hash rethink is not performed.
+gro_normal_batch
+----------------
+
+Maximum number of the segments to batch up on output of GRO. When a packet
+exits GRO, either as a coalesced superframe or as an original packet which
+GRO has decided not to coalesce, it is placed on a per-NAPI list. This
+list is then passed to the stack when the number of segments reaches the
+gro_normal_batch limit.
+
2. /proc/sys/net/unix - Parameters for Unix domain sockets
----------------------------------------------------------
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCHv3 net] Documentation: add description for net.core.gro_normal_batch
2022-05-18 16:09 [PATCHv3 net] Documentation: add description for net.core.gro_normal_batch Xin Long
@ 2022-05-18 16:20 ` Jakub Kicinski
2022-05-18 17:07 ` Edward Cree
2022-05-20 0:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2022-05-18 16:20 UTC (permalink / raw)
To: Xin Long; +Cc: network dev, davem, Edward Cree
On Wed, 18 May 2022 12:09:15 -0400 Xin Long wrote:
> Describe it in admin-guide/sysctl/net.rst like other Network core options.
> Users need to know gro_normal_batch for performance tuning.
>
> Fixes: 323ebb61e32b ("net: use listified RX for handling GRO_NORMAL skbs")
> Reported-by: Prijesh Patel <prpatel@redhat.com>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHv3 net] Documentation: add description for net.core.gro_normal_batch
2022-05-18 16:09 [PATCHv3 net] Documentation: add description for net.core.gro_normal_batch Xin Long
2022-05-18 16:20 ` Jakub Kicinski
@ 2022-05-18 17:07 ` Edward Cree
2022-05-20 0:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Edward Cree @ 2022-05-18 17:07 UTC (permalink / raw)
To: Xin Long, network dev; +Cc: davem, kuba
On 18/05/2022 17:09, Xin Long wrote:
> Describe it in admin-guide/sysctl/net.rst like other Network core options.
> Users need to know gro_normal_batch for performance tuning.
>
> Fixes: 323ebb61e32b ("net: use listified RX for handling GRO_NORMAL skbs")
> Reported-by: Prijesh Patel <prpatel@redhat.com>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: Edward Cree <ecree.xilinx@gmail.com>
> ---
> v1->v2:
> - improve the description according to the suggestion from Edward
> and Jakub.
> v2->v3:
> - improve more for the description, and drop the default for
> gro_normal_batch, suggested by Jakub.
>
> Documentation/admin-guide/sysctl/net.rst | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/admin-guide/sysctl/net.rst b/Documentation/admin-guide/sysctl/net.rst
> index f86b5e1623c6..46b44fa82fa2 100644
> --- a/Documentation/admin-guide/sysctl/net.rst
> +++ b/Documentation/admin-guide/sysctl/net.rst
> @@ -374,6 +374,15 @@ option is set to SOCK_TXREHASH_DEFAULT (i. e. not overridden by setsockopt).
> If set to 1 (default), hash rethink is performed on listening socket.
> If set to 0, hash rethink is not performed.
>
> +gro_normal_batch
> +----------------
> +
> +Maximum number of the segments to batch up on output of GRO. When a packet
> +exits GRO, either as a coalesced superframe or as an original packet which
> +GRO has decided not to coalesce, it is placed on a per-NAPI list. This
> +list is then passed to the stack when the number of segments reaches the
> +gro_normal_batch limit.
> +
> 2. /proc/sys/net/unix - Parameters for Unix domain sockets
> ----------------------------------------------------------
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHv3 net] Documentation: add description for net.core.gro_normal_batch
2022-05-18 16:09 [PATCHv3 net] Documentation: add description for net.core.gro_normal_batch Xin Long
2022-05-18 16:20 ` Jakub Kicinski
2022-05-18 17:07 ` Edward Cree
@ 2022-05-20 0:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-05-20 0:50 UTC (permalink / raw)
To: Xin Long; +Cc: netdev, davem, kuba, ecree
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 18 May 2022 12:09:15 -0400 you wrote:
> Describe it in admin-guide/sysctl/net.rst like other Network core options.
> Users need to know gro_normal_batch for performance tuning.
>
> Fixes: 323ebb61e32b ("net: use listified RX for handling GRO_NORMAL skbs")
> Reported-by: Prijesh Patel <prpatel@redhat.com>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
>
> [...]
Here is the summary with links:
- [PATCHv3,net] Documentation: add description for net.core.gro_normal_batch
https://git.kernel.org/netdev/net/c/582a2dbc72ac
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-20 0:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-18 16:09 [PATCHv3 net] Documentation: add description for net.core.gro_normal_batch Xin Long
2022-05-18 16:20 ` Jakub Kicinski
2022-05-18 17:07 ` Edward Cree
2022-05-20 0:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).