* [PATCH v3] vmxnet3: Implement ethtool's get_channels command
@ 2022-07-19 4:29 Andrey Turkin
2022-07-20 9:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Andrey Turkin @ 2022-07-19 4:29 UTC (permalink / raw)
To: netdev; +Cc: Ronak Doshi, VMware PV-Drivers Reviewers, Andrey Turkin
Some tools (e.g. libxdp) use that information.
Signed-off-by: Andrey Turkin <andrey.turkin@gmail.com>
---
Notes:
v2:
- Replaced #ifdef with IS_ENABLED
- Fixed a compilation warning
v3:
- Removed explicit 0 assignments of unused fields.
drivers/net/vmxnet3/vmxnet3_ethtool.c | 29 +++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/drivers/net/vmxnet3/vmxnet3_ethtool.c b/drivers/net/vmxnet3/vmxnet3_ethtool.c
index 3172d46c0335..f2cbf502b76b 100644
--- a/drivers/net/vmxnet3/vmxnet3_ethtool.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethtool.c
@@ -1188,6 +1188,34 @@ static int vmxnet3_set_coalesce(struct net_device *netdev,
return 0;
}
+static void vmxnet3_get_channels(struct net_device *netdev,
+ struct ethtool_channels *ec)
+{
+ struct vmxnet3_adapter *adapter = netdev_priv(netdev);
+
+ if (IS_ENABLED(CONFIG_PCI_MSI) && adapter->intr.type == VMXNET3_IT_MSIX) {
+ if (adapter->share_intr == VMXNET3_INTR_BUDDYSHARE) {
+ ec->combined_count = adapter->num_tx_queues;
+ } else {
+ ec->rx_count = adapter->num_rx_queues;
+ ec->tx_count =
+ adapter->share_intr == VMXNET3_INTR_TXSHARE ?
+ 1 : adapter->num_tx_queues;
+ }
+ } else {
+ ec->combined_count = 1;
+ }
+
+ ec->other_count = 1;
+
+ /* Number of interrupts cannot be changed on the fly */
+ /* Just set maximums to actual values */
+ ec->max_rx = ec->rx_count;
+ ec->max_tx = ec->tx_count;
+ ec->max_combined = ec->combined_count;
+ ec->max_other = ec->other_count;
+}
+
static const struct ethtool_ops vmxnet3_ethtool_ops = {
.supported_coalesce_params = ETHTOOL_COALESCE_RX_USECS |
ETHTOOL_COALESCE_MAX_FRAMES |
@@ -1213,6 +1241,7 @@ static const struct ethtool_ops vmxnet3_ethtool_ops = {
.set_rxfh = vmxnet3_set_rss,
#endif
.get_link_ksettings = vmxnet3_get_link_ksettings,
+ .get_channels = vmxnet3_get_channels,
};
void vmxnet3_set_ethtool_ops(struct net_device *netdev)
base-commit: ca85855bdcae8f84f1512e88b4c75009ea17ea2f
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] vmxnet3: Implement ethtool's get_channels command
2022-07-19 4:29 [PATCH v3] vmxnet3: Implement ethtool's get_channels command Andrey Turkin
@ 2022-07-20 9:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-07-20 9:30 UTC (permalink / raw)
To: Andrey Turkin; +Cc: netdev, doshir, pv-drivers
Hello:
This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:
On Tue, 19 Jul 2022 04:29:55 +0000 you wrote:
> Some tools (e.g. libxdp) use that information.
>
> Signed-off-by: Andrey Turkin <andrey.turkin@gmail.com>
> ---
>
> Notes:
> v2:
> - Replaced #ifdef with IS_ENABLED
> - Fixed a compilation warning
> v3:
> - Removed explicit 0 assignments of unused fields.
>
> [...]
Here is the summary with links:
- [v3] vmxnet3: Implement ethtool's get_channels command
https://git.kernel.org/netdev/net-next/c/ffcdd1197da6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-20 9:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-19 4:29 [PATCH v3] vmxnet3: Implement ethtool's get_channels command Andrey Turkin
2022-07-20 9:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).