[PATCH iproute2-next v1] tc_util: Change datatype for maj to avoid overflow issue

[PATCH iproute2-next v1] tc_util: Change datatype for maj to avoid overflow issue

[Lai Peter Jun Ann]

The return value by stroul() is unsigned long int. Hence the datatype
for maj should defined as unsigned long to avoid overflow issue.

Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Signed-off-by: Lai Peter Jun Ann <jun.ann.lai@intel.com>
---
 tc/tc_util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tc/tc_util.c b/tc/tc_util.c
index 44137ad..f8d9c88 100644
--- a/tc/tc_util.c
+++ b/tc/tc_util.c
@@ -74,7 +74,7 @@ const char *get_tc_lib(void)
 
 int get_qdisc_handle(__u32 *h, const char *str)
 {
-	__u32 maj;
+	unsigned long maj;
 	char *p;
 
 	maj = TC_H_UNSPEC;
-- 
1.9.1

Re: [PATCH iproute2-next v1] tc_util: Change datatype for maj to avoid overflow issue

[Simon Horman]

On Mon, Nov 21, 2022 at 10:29:09AM +0800, Lai Peter Jun Ann wrote:
> [You don't often get email from jun.ann.lai@intel.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> The return value by stroul() is unsigned long int. Hence the datatype
> for maj should defined as unsigned long to avoid overflow issue.
> 
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
> Signed-off-by: Lai Peter Jun Ann <jun.ann.lai@intel.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>

Re: [PATCH iproute2-next v1] tc_util: Change datatype for maj to avoid overflow issue

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@networkplumber.org>:

On Mon, 21 Nov 2022 10:29:09 +0800 you wrote:
> The return value by stroul() is unsigned long int. Hence the datatype
> for maj should defined as unsigned long to avoid overflow issue.
> 
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
> Signed-off-by: Lai Peter Jun Ann <jun.ann.lai@intel.com>
> ---
>  tc/tc_util.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [iproute2-next,v1] tc_util: Change datatype for maj to avoid overflow issue
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=455fa8295298

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html