* [PATCH net-next] net: mdio: cavium: Remove unneeded simicolons
@ 2023-01-15 16:42 Andrew Lunn
2023-01-16 7:58 ` Michael Walle
2023-01-17 12:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Lunn @ 2023-01-15 16:42 UTC (permalink / raw)
To: netdev; +Cc: Michael Walle, Andrew Lunn, kernel test robot
The recent refactoring to split C22 and C45 introduced two unneeded
semiconons which the kernel test bot reported. Remove them.
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 93641ecbaa1f ("net: mdio: cavium: Separate C22 and C45 transactions")
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/mdio/mdio-cavium.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mdio/mdio-cavium.c b/drivers/net/mdio/mdio-cavium.c
index fd81546a4d3d..100e46a702ee 100644
--- a/drivers/net/mdio/mdio-cavium.c
+++ b/drivers/net/mdio/mdio-cavium.c
@@ -67,7 +67,7 @@ int cavium_mdiobus_read_c22(struct mii_bus *bus, int phy_id, int regnum)
cavium_mdiobus_set_mode(p, C22);
smi_cmd.u64 = 0;
- smi_cmd.s.phy_op = 1; /* MDIO_CLAUSE_22_READ */;
+ smi_cmd.s.phy_op = 1; /* MDIO_CLAUSE_22_READ */
smi_cmd.s.phy_adr = phy_id;
smi_cmd.s.reg_adr = regnum;
oct_mdio_writeq(smi_cmd.u64, p->register_base + SMI_CMD);
@@ -136,7 +136,7 @@ int cavium_mdiobus_write_c22(struct mii_bus *bus, int phy_id, int regnum,
oct_mdio_writeq(smi_wr.u64, p->register_base + SMI_WR_DAT);
smi_cmd.u64 = 0;
- smi_cmd.s.phy_op = 0; /* MDIO_CLAUSE_22_WRITE */;
+ smi_cmd.s.phy_op = 0; /* MDIO_CLAUSE_22_WRITE */
smi_cmd.s.phy_adr = phy_id;
smi_cmd.s.reg_adr = regnum;
oct_mdio_writeq(smi_cmd.u64, p->register_base + SMI_CMD);
--
2.39.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: mdio: cavium: Remove unneeded simicolons
2023-01-15 16:42 [PATCH net-next] net: mdio: cavium: Remove unneeded simicolons Andrew Lunn
@ 2023-01-16 7:58 ` Michael Walle
2023-01-17 12:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Michael Walle @ 2023-01-16 7:58 UTC (permalink / raw)
To: Andrew Lunn; +Cc: netdev, kernel test robot
> The recent refactoring to split C22 and C45 introduced two unneeded
> semiconons which the kernel test bot reported. Remove them.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 93641ecbaa1f ("net: mdio: cavium: Separate C22 and C45
> transactions")
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Michael Walle <michael@walle.cc>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: mdio: cavium: Remove unneeded simicolons
2023-01-15 16:42 [PATCH net-next] net: mdio: cavium: Remove unneeded simicolons Andrew Lunn
2023-01-16 7:58 ` Michael Walle
@ 2023-01-17 12:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-01-17 12:30 UTC (permalink / raw)
To: Andrew Lunn; +Cc: netdev, michael, lkp
Hello:
This patch was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Sun, 15 Jan 2023 17:42:03 +0100 you wrote:
> The recent refactoring to split C22 and C45 introduced two unneeded
> semiconons which the kernel test bot reported. Remove them.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 93641ecbaa1f ("net: mdio: cavium: Separate C22 and C45 transactions")
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
>
> [...]
Here is the summary with links:
- [net-next] net: mdio: cavium: Remove unneeded simicolons
https://git.kernel.org/netdev/net-next/c/0c68c8e5ec68
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-17 12:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-15 16:42 [PATCH net-next] net: mdio: cavium: Remove unneeded simicolons Andrew Lunn
2023-01-16 7:58 ` Michael Walle
2023-01-17 12:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).