[PATCH net-next] mlxsw: spectrum_nve_vxlan: Fix unsupported flag regression

[PATCH net-next] mlxsw: spectrum_nve_vxlan: Fix unsupported flag regression

[Petr Machata]

From: Ido Schimmel <idosch@nvidia.com>

The recently added 'VXLAN_F_LOCALBYPASS' flag is set by default on VXLAN
devices and denotes a behavior that is irrelevant for the hardware data
path. Add it to the lists of IPv4 and IPv6 supported flags to avoid
rejecting offload of VXLAN devices which have this flag set.

Fixes: 69474a8a5837 ("net: vxlan: Add nolocalbypass option to vxlan.")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: Petr Machata <petrm@nvidia.com>
---
 drivers/net/ethernet/mellanox/mlxsw/spectrum_nve_vxlan.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_nve_vxlan.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_nve_vxlan.c
index d309b77a0194..bb8eeb86edf7 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_nve_vxlan.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_nve_vxlan.c
@@ -11,10 +11,12 @@
 #include "spectrum_nve.h"
 
 #define MLXSW_SP_NVE_VXLAN_IPV4_SUPPORTED_FLAGS (VXLAN_F_UDP_ZERO_CSUM_TX | \
-						 VXLAN_F_LEARN)
+						 VXLAN_F_LEARN | \
+						 VXLAN_F_LOCALBYPASS)
 #define MLXSW_SP_NVE_VXLAN_IPV6_SUPPORTED_FLAGS (VXLAN_F_IPV6 | \
 						 VXLAN_F_UDP_ZERO_CSUM6_TX | \
-						 VXLAN_F_UDP_ZERO_CSUM6_RX)
+						 VXLAN_F_UDP_ZERO_CSUM6_RX | \
+						 VXLAN_F_LOCALBYPASS)
 
 static bool mlxsw_sp_nve_vxlan_ipv4_flags_check(const struct vxlan_config *cfg,
 						struct netlink_ext_ack *extack)
-- 
2.40.1

Re: [PATCH net-next] mlxsw: spectrum_nve_vxlan: Fix unsupported flag regression

[Simon Horman]

On Wed, Jun 07, 2023 at 02:19:26PM +0200, Petr Machata wrote:
> From: Ido Schimmel <idosch@nvidia.com>
> 
> The recently added 'VXLAN_F_LOCALBYPASS' flag is set by default on VXLAN
> devices and denotes a behavior that is irrelevant for the hardware data
> path. Add it to the lists of IPv4 and IPv6 supported flags to avoid
> rejecting offload of VXLAN devices which have this flag set.
> 
> Fixes: 69474a8a5837 ("net: vxlan: Add nolocalbypass option to vxlan.")
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> Reviewed-by: Petr Machata <petrm@nvidia.com>
> Signed-off-by: Petr Machata <petrm@nvidia.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>

Re: [PATCH net-next] mlxsw: spectrum_nve_vxlan: Fix unsupported flag regression

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 7 Jun 2023 14:19:26 +0200 you wrote:
> From: Ido Schimmel <idosch@nvidia.com>
> 
> The recently added 'VXLAN_F_LOCALBYPASS' flag is set by default on VXLAN
> devices and denotes a behavior that is irrelevant for the hardware data
> path. Add it to the lists of IPv4 and IPv6 supported flags to avoid
> rejecting offload of VXLAN devices which have this flag set.
> 
> [...]

Here is the summary with links:
  - [net-next] mlxsw: spectrum_nve_vxlan: Fix unsupported flag regression
    https://git.kernel.org/netdev/net-next/c/37ff78e977f1

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html