* [PATCH net-next] sfc: Add devlink dev info support for EF10
@ 2023-06-09 7:57 Martin Habets
2023-06-09 13:16 ` Simon Horman
2023-06-12 8:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Martin Habets @ 2023-06-09 7:57 UTC (permalink / raw)
To: davem, kuba, pabeni, edumazet; +Cc: netdev, ecree.xilinx, linux-net-drivers
Reuse the work done for EF100 to add devlink support for EF10.
There is no devlink port support for EF10.
Signed-off-by: Martin Habets <habetsm.xilinx@gmail.com>
---
drivers/net/ethernet/sfc/efx.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index a4f22d8e6ac7..d670a319b379 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -32,6 +32,7 @@
#include "io.h"
#include "selftest.h"
#include "sriov.h"
+#include "efx_devlink.h"
#include "mcdi_port_common.h"
#include "mcdi_pcol.h"
@@ -877,6 +878,7 @@ static void efx_pci_remove(struct pci_dev *pci_dev)
if (efx->type->sriov_fini)
efx->type->sriov_fini(efx);
+ efx_fini_devlink_lock(efx);
efx_unregister_netdev(efx);
efx_mtd_remove(efx);
@@ -886,6 +888,7 @@ static void efx_pci_remove(struct pci_dev *pci_dev)
efx_fini_io(efx);
pci_dbg(efx->pci_dev, "shutdown successful\n");
+ efx_fini_devlink_and_unlock(efx);
efx_fini_struct(efx);
free_netdev(efx->net_dev);
probe_data = container_of(efx, struct efx_probe_data, efx);
@@ -1025,7 +1028,13 @@ static int efx_pci_probe_post_io(struct efx_nic *efx)
NETDEV_XDP_ACT_REDIRECT |
NETDEV_XDP_ACT_NDO_XMIT;
+ /* devlink creation, registration and lock */
+ rc = efx_probe_devlink_and_lock(efx);
+ if (rc)
+ pci_err(efx->pci_dev, "devlink registration failed");
+
rc = efx_register_netdev(efx);
+ efx_probe_devlink_unlock(efx);
if (!rc)
return 0;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] sfc: Add devlink dev info support for EF10
2023-06-09 7:57 [PATCH net-next] sfc: Add devlink dev info support for EF10 Martin Habets
@ 2023-06-09 13:16 ` Simon Horman
2023-06-12 8:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-06-09 13:16 UTC (permalink / raw)
To: Martin Habets
Cc: davem, kuba, pabeni, edumazet, netdev, ecree.xilinx, linux-net-drivers
On Fri, Jun 09, 2023 at 08:57:36AM +0100, Martin Habets wrote:
> Reuse the work done for EF100 to add devlink support for EF10.
> There is no devlink port support for EF10.
>
> Signed-off-by: Martin Habets <habetsm.xilinx@gmail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] sfc: Add devlink dev info support for EF10
2023-06-09 7:57 [PATCH net-next] sfc: Add devlink dev info support for EF10 Martin Habets
2023-06-09 13:16 ` Simon Horman
@ 2023-06-12 8:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-06-12 8:40 UTC (permalink / raw)
To: Martin Habets
Cc: davem, kuba, pabeni, edumazet, netdev, ecree.xilinx, linux-net-drivers
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:
On Fri, 09 Jun 2023 08:57:36 +0100 you wrote:
> Reuse the work done for EF100 to add devlink support for EF10.
> There is no devlink port support for EF10.
>
> Signed-off-by: Martin Habets <habetsm.xilinx@gmail.com>
> ---
> drivers/net/ethernet/sfc/efx.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
Here is the summary with links:
- [net-next] sfc: Add devlink dev info support for EF10
https://git.kernel.org/netdev/net-next/c/998b85f0468f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-12 8:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-09 7:57 [PATCH net-next] sfc: Add devlink dev info support for EF10 Martin Habets
2023-06-09 13:16 ` Simon Horman
2023-06-12 8:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).