* [PATCH net-next] selftests: net: include forwarding lib
@ 2024-02-07 9:42 Paolo Abeni
2024-02-09 21:00 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Abeni @ 2024-02-07 9:42 UTC (permalink / raw)
To: netdev
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Shuah Khan,
linux-kselftest
The altnames test uses the forwarding/lib.sh and that dependency
currently causes failures when running the test after install:
make -C tools/testing/selftests/ TARGETS=net install
./tools/testing/selftests/kselftest_install/run_kselftest.sh \
-t net:altnames.sh
# ...
# ./altnames.sh: line 8: ./forwarding/lib.sh: No such file or directory
# RTNETLINK answers: Operation not permitted
# ./altnames.sh: line 73: tests_run: command not found
# ./altnames.sh: line 65: pre_cleanup: command not found
Address the issue leveraging the TEST_INCLUDES infrastructure
provided by commit 2a0683be5b4c ("selftests: Introduce Makefile variable
to list shared bash scripts")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
tools/testing/selftests/net/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
index 211753756bde..7b6918d5f4af 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -97,6 +97,8 @@ TEST_PROGS += vlan_hw_filter.sh
TEST_FILES := settings
TEST_FILES += in_netns.sh lib.sh net_helper.sh setup_loopback.sh setup_veth.sh
+TEST_INCLUDES := forwarding/lib.sh
+
include ../lib.mk
$(OUTPUT)/reuseport_bpf_numa: LDLIBS += -lnuma
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] selftests: net: include forwarding lib
2024-02-07 9:42 [PATCH net-next] selftests: net: include forwarding lib Paolo Abeni
@ 2024-02-09 21:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-02-09 21:00 UTC (permalink / raw)
To: Paolo Abeni; +Cc: netdev, davem, edumazet, kuba, shuah, linux-kselftest
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 7 Feb 2024 10:42:45 +0100 you wrote:
> The altnames test uses the forwarding/lib.sh and that dependency
> currently causes failures when running the test after install:
>
> make -C tools/testing/selftests/ TARGETS=net install
> ./tools/testing/selftests/kselftest_install/run_kselftest.sh \
> -t net:altnames.sh
> # ...
> # ./altnames.sh: line 8: ./forwarding/lib.sh: No such file or directory
> # RTNETLINK answers: Operation not permitted
> # ./altnames.sh: line 73: tests_run: command not found
> # ./altnames.sh: line 65: pre_cleanup: command not found
>
> [...]
Here is the summary with links:
- [net-next] selftests: net: include forwarding lib
https://git.kernel.org/netdev/net-next/c/876e32473d1d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-09 21:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-07 9:42 [PATCH net-next] selftests: net: include forwarding lib Paolo Abeni
2024-02-09 21:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).