From: liweihang <liweihang@huawei.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>,
liangwenpeng <liangwenpeng@huawei.com>,
"Richard Cochran" <richardcochran@gmail.com>
Subject: Re: [PATCH net-next 1/8] net: phy: add a blank line after declarations
Date: Tue, 15 Jun 2021 06:12:42 +0000 [thread overview]
Message-ID: <17675f18295848d384e360197648dfd9@huawei.com> (raw)
In-Reply-To: YMNz3RnzhPak7XIT@lunn.ch
On 2021/6/11 22:32, Andrew Lunn wrote:
> On Fri, Jun 11, 2021 at 02:36:52PM +0800, Weihang Li wrote:
>> From: Wenpeng Liang <liangwenpeng@huawei.com>
>>
>> There should be a blank line after declarations.
>>
>> Cc: Richard Cochran <richardcochran@gmail.com>
>> Signed-off-by: Wenpeng Liang <liangwenpeng@huawei.com>
>> Signed-off-by: Weihang Li <liweihang@huawei.com>
>> ---
>> drivers/net/phy/bcm87xx.c | 4 ++--
>> drivers/net/phy/dp83640.c | 1 +
>> drivers/net/phy/et1011c.c | 6 ++++--
>> drivers/net/phy/mdio_bus.c | 1 +
>> drivers/net/phy/qsemi.c | 1 +
>> 5 files changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/phy/bcm87xx.c b/drivers/net/phy/bcm87xx.c
>> index 4ac8fd1..3135634 100644
>> --- a/drivers/net/phy/bcm87xx.c
>> +++ b/drivers/net/phy/bcm87xx.c
>> @@ -54,9 +54,9 @@ static int bcm87xx_of_reg_init(struct phy_device *phydev)
>> u16 reg = be32_to_cpup(paddr++);
>> u16 mask = be32_to_cpup(paddr++);
>> u16 val_bits = be32_to_cpup(paddr++);
>> - int val;
>> u32 regnum = mdiobus_c45_addr(devid, reg);
>> - val = 0;
>> + int val = 0;
>> +
>
> This does a little bit more than add a blank line. Please mention it
> in the commit message.
>
> This is to do with trust. If you say you are just added blank lines,
> the review can be very quick because you cannot break anything with
> just blank lines. But as soon as i see more than just blank lines, i
> can no longer trust your description, and i need to look much harder
> at your changes.
I see, thanks for the patient guidance.
>
>> --- a/drivers/net/phy/et1011c.c
>> +++ b/drivers/net/phy/et1011c.c
>> @@ -46,7 +46,8 @@ MODULE_LICENSE("GPL");
>>
>> static int et1011c_config_aneg(struct phy_device *phydev)
>> {
>> - int ctl = 0;
>> + int ctl;
>> +
>> ctl = phy_read(phydev, MII_BMCR);
>> if (ctl < 0)
>> return ctl;
>
> Since you made this change, you could go one step further
>
> int ctl = phy_read(phydev, MII_BMCR);
Sure.
>
>> @@ -60,9 +61,10 @@ static int et1011c_config_aneg(struct phy_device *phydev)
>>
>> static int et1011c_read_status(struct phy_device *phydev)
>> {
>> + static int speed;
>> int ret;
>> u32 val;
>> - static int speed;
>> +
>
> This is an O.K. change, but again, more than adding a blank line.
>
> Andrew>
OK, I will describe that in the commit description.
Thanks
Weihang
next prev parent reply other threads:[~2021-06-15 6:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 6:36 [PATCH net-next 0/8] net: phy: fix some coding-style issues Weihang Li
2021-06-11 6:36 ` [PATCH net-next 1/8] net: phy: add a blank line after declarations Weihang Li
2021-06-11 14:31 ` Andrew Lunn
2021-06-15 6:12 ` liweihang [this message]
2021-06-11 6:36 ` [PATCH net-next 2/8] net: phy: correct format of block comments Weihang Li
2021-06-11 14:36 ` Andrew Lunn
2021-06-15 6:18 ` liweihang
2021-06-11 6:36 ` [PATCH net-next 3/8] net: phy: delete repeated word " Weihang Li
2021-06-11 14:39 ` Andrew Lunn
2021-06-15 6:21 ` liweihang
2021-06-11 6:36 ` [PATCH net-next 4/8] net: phy: fixed formatting issues with braces Weihang Li
2021-06-11 14:41 ` Andrew Lunn
2021-06-16 6:39 ` liweihang
2021-06-11 6:36 ` [PATCH net-next 5/8] net: phy: fixed space alignment issues Weihang Li
2021-06-11 15:30 ` Andrew Lunn
2021-06-15 6:24 ` liweihang
2021-06-11 6:36 ` [PATCH net-next 6/8] net: phy: print the function name by __func__ instead of an fixed string Weihang Li
2021-06-11 16:05 ` Andrew Lunn
2021-06-15 6:26 ` liweihang
2021-06-16 8:14 ` liweihang
2021-06-11 6:36 ` [PATCH net-next 7/8] net: phy: remove unnecessary line continuation Weihang Li
2021-06-11 16:06 ` Andrew Lunn
2021-06-15 6:26 ` liweihang
2021-06-11 6:36 ` [PATCH net-next 8/8] net: phy: use '__packed' instead of '__attribute__((__packed__))' Weihang Li
2021-06-11 16:07 ` Andrew Lunn
2021-06-14 14:28 ` David Laight
2021-06-16 6:17 ` liweihang
2021-06-16 8:47 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17675f18295848d384e360197648dfd9@huawei.com \
--to=liweihang@huawei.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=liangwenpeng@huawei.com \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).