From: liweihang <liweihang@huawei.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>,
liangwenpeng <liangwenpeng@huawei.com>
Subject: Re: [PATCH net-next 6/8] net: phy: print the function name by __func__ instead of an fixed string
Date: Wed, 16 Jun 2021 08:14:13 +0000 [thread overview]
Message-ID: <bc0300eb01494e2b9b190c5d3ac7bc80@huawei.com> (raw)
In-Reply-To: YMOJrv0ZRGCP26F7@lunn.ch
On 2021/6/12 0:05, Andrew Lunn wrote:
>> @@ -188,7 +188,7 @@ int mdio_driver_register(struct mdio_driver *drv)
>> struct mdio_driver_common *mdiodrv = &drv->mdiodrv;
>> int retval;
>>
>> - pr_debug("mdio_driver_register: %s\n", mdiodrv->driver.name);
>> + pr_debug("%s: %s\n", __func__, mdiodrv->driver.name);
> It would be nice to make this
>
> dev_dbg(&mdiodev->dev, "%s: %s\n", __func__, mdiodrv->driver.name);
>
> Andrew
>
There is no way to get mdiodev from a pointer to mdio_driver, I don't think
there's a direct relationship between them. So I will keep using pr_debug :)
Thanks
Weihang
next prev parent reply other threads:[~2021-06-16 8:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 6:36 [PATCH net-next 0/8] net: phy: fix some coding-style issues Weihang Li
2021-06-11 6:36 ` [PATCH net-next 1/8] net: phy: add a blank line after declarations Weihang Li
2021-06-11 14:31 ` Andrew Lunn
2021-06-15 6:12 ` liweihang
2021-06-11 6:36 ` [PATCH net-next 2/8] net: phy: correct format of block comments Weihang Li
2021-06-11 14:36 ` Andrew Lunn
2021-06-15 6:18 ` liweihang
2021-06-11 6:36 ` [PATCH net-next 3/8] net: phy: delete repeated word " Weihang Li
2021-06-11 14:39 ` Andrew Lunn
2021-06-15 6:21 ` liweihang
2021-06-11 6:36 ` [PATCH net-next 4/8] net: phy: fixed formatting issues with braces Weihang Li
2021-06-11 14:41 ` Andrew Lunn
2021-06-16 6:39 ` liweihang
2021-06-11 6:36 ` [PATCH net-next 5/8] net: phy: fixed space alignment issues Weihang Li
2021-06-11 15:30 ` Andrew Lunn
2021-06-15 6:24 ` liweihang
2021-06-11 6:36 ` [PATCH net-next 6/8] net: phy: print the function name by __func__ instead of an fixed string Weihang Li
2021-06-11 16:05 ` Andrew Lunn
2021-06-15 6:26 ` liweihang
2021-06-16 8:14 ` liweihang [this message]
2021-06-11 6:36 ` [PATCH net-next 7/8] net: phy: remove unnecessary line continuation Weihang Li
2021-06-11 16:06 ` Andrew Lunn
2021-06-15 6:26 ` liweihang
2021-06-11 6:36 ` [PATCH net-next 8/8] net: phy: use '__packed' instead of '__attribute__((__packed__))' Weihang Li
2021-06-11 16:07 ` Andrew Lunn
2021-06-14 14:28 ` David Laight
2021-06-16 6:17 ` liweihang
2021-06-16 8:47 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc0300eb01494e2b9b190c5d3ac7bc80@huawei.com \
--to=liweihang@huawei.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=liangwenpeng@huawei.com \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).