From: Florent Fourcot <florent.fourcot@wifirst.fr> To: Eric Dumazet <edumazet@google.com>, Heiner Kallweit <hkallweit1@gmail.com> Cc: Charles DAYMAND <charles.daymand@wifirst.fr>, netdev <netdev@vger.kernel.org> Subject: Re: [PATCH net] r8169: fix multicast tx issue with macvlan interface Date: Mon, 27 Apr 2020 23:12:01 +0200 Message-ID: <17fd01b4-8d4e-5c91-c51e-688a97c0da54@wifirst.fr> (raw) In-Reply-To: <CANn89iKA8MAef-XfkbLG3W+3=qUx4pqmKuWPBfrxAcupohLkyA@mail.gmail.com> Hello Eric, Hello Heiner, Just for a small follow-up on your questions and current status on our side for this strange topic: * As explained by Charles, the setup includes a mix of macvlan + vlan. So 802.1q frames are not a typo in the topic (in our real case, the second macvlan interface is sent to a network namespace, but it does not matter for the current issue). * We tested the same setup with other networking driver (bnx2, tg3) with tx-checksum enabled (exactly same configuration than the failing one on r8169 for checksum offloading), and it's perfectly working. * Packets are seen as valid by tcpdump on the sender (buggy) host. * Multicast *and* unicast packets are buggy. We detected it first on multicast (since the relevant hardware was sending RIP packets), but all tcp/udp packets are corrupted. ICMP packets are valid. * We expected as well a "simple" checksum failure, but it does not look so simple. Something, on our opinion probably the driver or hardware, is corrupting the packet. * Experimental patches from Heiner are not solving issue. * We have the same behavior on at least RTL8168d/8111d, RTL8169sc/8110sc and RTL8168h/8111h variants. As proposed by Heiner, we will try to debug step by step packet path inside the kernel to find where it's become corrupted. But it looks time consuming for people like us, not really experts in driver development. If you have any tips or ideas concerning this topic, it could help us a lot. Best regards, -- Florent.
next prev parent reply index Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-27 9:08 Charles Daymand 2020-03-27 9:39 ` Heiner Kallweit 2020-03-27 17:41 ` Heiner Kallweit 2020-03-27 18:52 ` Eric Dumazet 2020-03-27 19:17 ` Heiner Kallweit 2020-03-27 19:42 ` Eric Dumazet [not found] ` <CAFJtzm03QpjGRs70tth26BdUFN_o8zsJOccbnA58ma+2uwiGcg@mail.gmail.com> 2020-03-31 13:48 ` Charles DAYMAND 2020-03-31 14:07 ` Heiner Kallweit 2020-04-06 14:12 ` Charles DAYMAND 2020-04-06 22:16 ` Heiner Kallweit 2020-04-06 23:20 ` Eric Dumazet 2020-04-07 6:22 ` Heiner Kallweit 2020-04-07 22:40 ` Heiner Kallweit 2020-04-10 9:53 ` Charles DAYMAND 2020-04-13 18:06 ` Heiner Kallweit 2020-04-13 18:20 ` Eric Dumazet 2020-04-15 11:55 ` Charles Daymand 2020-05-12 18:37 ` Heiner Kallweit 2020-04-27 21:12 ` Florent Fourcot [this message] 2020-04-30 16:50 ` Heiner Kallweit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=17fd01b4-8d4e-5c91-c51e-688a97c0da54@wifirst.fr \ --to=florent.fourcot@wifirst.fr \ --cc=charles.daymand@wifirst.fr \ --cc=edumazet@google.com \ --cc=hkallweit1@gmail.com \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Netdev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \ netdev@vger.kernel.org public-inbox-index netdev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.netdev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git