From: Charles Daymand <charles.daymand@wifirst.fr> To: netdev@vger.kernel.org Cc: Charles Daymand <charles.daymand@wifirst.fr> Subject: [PATCH net] r8169: fix multicast tx issue with macvlan interface Date: Fri, 27 Mar 2020 10:08:00 +0100 Message-ID: <20200327090800.27810-1-charles.daymand@wifirst.fr> (raw) During kernel upgrade testing on our hardware, we found that macvlan interface were no longer able to send valid multicast packet. tcpdump run on our hardware was correctly showing our multicast packet but when connecting a laptop to our hardware we didn't see any packets. Bisecting turned up commit 93681cd7d94f "r8169: enable HW csum and TSO" activates the feature NETIF_F_IP_CSUM which is responsible for the drop of packet in case of macvlan interface. Note that revision RTL_GIGA_MAC_VER_34 was already a specific case since TSO was keep disabled. Deactivating NETIF_F_IP_CSUM using ethtool is correcting our multicast issue, but we believe that this hardware issue is important enough to keep tx checksum off by default on this revision. The change is deactivating the default value of NETIF_F_IP_CSUM for this specific revision. Fixes: 93681cd7d94f ("r8169: enable HW csum and TSO") Signed-off-by: Charles Daymand <charles.daymand@wifirst.fr> --- net/drivers/net/ethernet/realtek/r8169_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/drivers/net/ethernet/realtek/r8169_main.c b/net/drivers/net/ethernet/realtek/r8169_main.c index a9bdafd15a35..3b69135fc500 100644 --- a/net/drivers/net/ethernet/realtek/r8169_main.c +++ b/net/drivers/net/ethernet/realtek/r8169_main.c @@ -5591,6 +5591,9 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) dev->vlan_features &= ~(NETIF_F_ALL_TSO | NETIF_F_SG); dev->hw_features &= ~(NETIF_F_ALL_TSO | NETIF_F_SG); dev->features &= ~(NETIF_F_ALL_TSO | NETIF_F_SG); + if (tp->mac_version == RTL_GIGA_MAC_VER_34) { + dev->features &= ~NETIF_F_IP_CSUM; + } } dev->hw_features |= NETIF_F_RXALL; -- 2.20.1
next reply index Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-27 9:08 Charles Daymand [this message] 2020-03-27 9:39 ` Heiner Kallweit 2020-03-27 17:41 ` Heiner Kallweit 2020-03-27 18:52 ` Eric Dumazet 2020-03-27 19:17 ` Heiner Kallweit 2020-03-27 19:42 ` Eric Dumazet [not found] ` <CAFJtzm03QpjGRs70tth26BdUFN_o8zsJOccbnA58ma+2uwiGcg@mail.gmail.com> 2020-03-31 13:48 ` Charles DAYMAND 2020-03-31 14:07 ` Heiner Kallweit 2020-04-06 14:12 ` Charles DAYMAND 2020-04-06 22:16 ` Heiner Kallweit 2020-04-06 23:20 ` Eric Dumazet 2020-04-07 6:22 ` Heiner Kallweit 2020-04-07 22:40 ` Heiner Kallweit 2020-04-10 9:53 ` Charles DAYMAND 2020-04-13 18:06 ` Heiner Kallweit 2020-04-13 18:20 ` Eric Dumazet 2020-04-15 11:55 ` Charles Daymand 2020-05-12 18:37 ` Heiner Kallweit 2020-04-27 21:12 ` Florent Fourcot 2020-04-30 16:50 ` Heiner Kallweit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200327090800.27810-1-charles.daymand@wifirst.fr \ --to=charles.daymand@wifirst.fr \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Netdev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \ netdev@vger.kernel.org public-inbox-index netdev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.netdev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git