From: Josh Hunt <johunt@akamai.com>
To: jonas.bonn@netrounds.com, pabeni@redhat.com
Cc: Michael Zhivich <mzhivich@akamai.com>,
davem@davemloft.net, john.fastabend@gmail.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: Packet gets stuck in NOLOCK pfifo_fast qdisc
Date: Tue, 30 Jun 2020 12:14:50 -0700 [thread overview]
Message-ID: <1849b74f-163c-8cfa-baa5-f653159fefd4@akamai.com> (raw)
In-Reply-To: <20200623134259.8197-1-mzhivich@akamai.com>
On 6/23/20 6:42 AM, Michael Zhivich wrote:
>> From: Jonas Bonn <jonas.bonn@netrounds.com>
>> To: Paolo Abeni <pabeni@redhat.com>,
>> "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
>> LKML <linux-kernel@vger.kernel.org>,
>> "David S . Miller" <davem@davemloft.net>,
>> John Fastabend <john.fastabend@gmail.com>
>> Subject: Re: Packet gets stuck in NOLOCK pfifo_fast qdisc
>> Date: Fri, 11 Oct 2019 02:39:48 +0200
>> Message-ID: <465a540e-5296-32e7-f6a6-79942dfe2618@netrounds.com> (raw)
>> In-Reply-To: <95c5a697932e19ebd6577b5dac4d7052fe8c4255.camel@redhat.com>
>>
>> Hi Paolo,
>>
>> On 09/10/2019 21:14, Paolo Abeni wrote:
>>> Something alike the following code - completely untested - can possibly
>>> address the issue, but it's a bit rough and I would prefer not adding
>>> additonal complexity to the lockless qdiscs, can you please have a spin
>>> a it?
>>
>> We've tested a couple of variants of this patch today, but unfortunately
>> it doesn't fix the problem of packets getting stuck in the queue.
>>
>> A couple of comments:
>>
>> i) On 5.4, there is the BYPASS path that also needs the same treatment
>> as it's essentially replicating the behavour of qdisc_run, just without
>> the queue/dequeue steps
>>
>> ii) We are working a lot with the 4.19 kernel so I backported to the
>> patch to this version and tested there. Here the solution would seem to
>> be more robust as the BYPASS path does not exist.
>>
>> Unfortunately, in both cases we continue to see the issue of the "last
>> packet" getting stuck in the queue.
>>
>> /Jonas
>
> Hello Jonas, Paolo,
>
> We have observed the same problem with pfifo_fast qdisc when sending periodic small
> packets on a TCP flow with multiple simultaneous connections on a 4.19.75
> kernel. We've been able to catch it in action using perf probes (see trace
> below). For qdisc = 0xffff900d7c247c00, skb = 0xffff900b72c334f0,
> it takes 200270us to traverse the networking stack on a system that's not otherwise busy.
> qdisc only resumes processing when another enqueued packet comes in,
> so the packet could have been stuck indefinitely.
>
> proc-19902 19902 [032] 580644.045480: probe:pfifo_fast_dequeue_end: (ffffffff9b69d99d) qdisc=0xffff900d7c247c00 skb=0xffff900bfc294af0 band=2 atomic_qlen=0
> proc-19902 19902 [032] 580644.045480: probe:pfifo_fast_dequeue: (ffffffff9b69d8c0) qdisc=0xffff900d7c247c00 skb=0xffffffff9b69d8c0 band=2
> proc-19927 19927 [014] 580644.045480: probe:tcp_transmit_skb2: (ffffffff9b6dc4e5) skb=0xffff900b72c334f0 sk=0xffff900d62958040 source=0x4b4e dest=0x9abe
> proc-19902 19902 [032] 580644.045480: probe:pfifo_fast_dequeue_end: (ffffffff9b69d99d) qdisc=0xffff900d7c247c00 skb=0x0 band=3 atomic_qlen=0
> proc-19927 19927 [014] 580644.045481: probe:ip_finish_output2: (ffffffff9b6bc650) net=0xffffffff9c107c80 sk=0xffff900d62958040 skb=0xffff900b72c334f0 __func__=0x0
> proc-19902 19902 [032] 580644.045481: probe:sch_direct_xmit: (ffffffff9b69e570) skb=0xffff900bfc294af0 q=0xffff900d7c247c00 dev=0xffff900d6a140000 txq=0xffff900d6a181180 root_lock=0x0 validate=1 ret=-1 again=155
> proc-19927 19927 [014] 580644.045481: net:net_dev_queue: dev=eth0 skbaddr=0xffff900b72c334f0 len=115
> proc-19902 19902 [032] 580644.045482: probe:pfifo_fast_dequeue: (ffffffff9b69d8c0) qdisc=0xffff900d7c247c00 skb=0xffffffff9b69d8c0 band=1
> proc-19927 19927 [014] 580644.045483: probe:pfifo_fast_enqueue: (ffffffff9b69d9f0) skb=0xffff900b72c334f0 qdisc=0xffff900d7c247c00 to_free=18446622925407304000
> proc-19902 19902 [032] 580644.045483: probe:pfifo_fast_dequeue_end: (ffffffff9b69d99d) qdisc=0xffff900d7c247c00 skb=0x0 band=3 atomic_qlen=0
> proc-19927 19927 [014] 580644.045483: probe:pfifo_fast_enqueue_end: (ffffffff9b69da9f) skb=0xffff900b72c334f0 qdisc=0xffff900d7c247c00 to_free=0xffff91d0f67ab940 atomic_qlen=1
> proc-19902 19902 [032] 580644.045484: probe:__qdisc_run_2: (ffffffff9b69ea5a) q=0xffff900d7c247c00 packets=1
> proc-19927 19927 [014] 580644.245745: probe:pfifo_fast_enqueue: (ffffffff9b69d9f0) skb=0xffff900d98fdf6f0 qdisc=0xffff900d7c247c00 to_free=18446622925407304000
> proc-19927 19927 [014] 580644.245745: probe:pfifo_fast_enqueue_end: (ffffffff9b69da9f) skb=0xffff900d98fdf6f0 qdisc=0xffff900d7c247c00 to_free=0xffff91d0f67ab940 atomic_qlen=2
> proc-19927 19927 [014] 580644.245746: probe:pfifo_fast_dequeue: (ffffffff9b69d8c0) qdisc=0xffff900d7c247c00 skb=0xffffffff9b69d8c0 band=0
> proc-19927 19927 [014] 580644.245746: probe:pfifo_fast_dequeue_end: (ffffffff9b69d99d) qdisc=0xffff900d7c247c00 skb=0xffff900b72c334f0 band=2 atomic_qlen=1
> proc-19927 19927 [014] 580644.245747: probe:pfifo_fast_dequeue: (ffffffff9b69d8c0) qdisc=0xffff900d7c247c00 skb=0xffffffff9b69d8c0 band=2
> proc-19927 19927 [014] 580644.245747: probe:pfifo_fast_dequeue_end: (ffffffff9b69d99d) qdisc=0xffff900d7c247c00 skb=0xffff900d98fdf6f0 band=2 atomic_qlen=0
> proc-19927 19927 [014] 580644.245748: probe:pfifo_fast_dequeue: (ffffffff9b69d8c0) qdisc=0xffff900d7c247c00 skb=0xffffffff9b69d8c0 band=2
> proc-19927 19927 [014] 580644.245748: probe:pfifo_fast_dequeue_end: (ffffffff9b69d99d) qdisc=0xffff900d7c247c00 skb=0x0 band=3 atomic_qlen=0
> proc-19927 19927 [014] 580644.245749: qdisc:qdisc_dequeue: dequeue ifindex=5 qdisc handle=0x0 parent=0xF txq_state=0x0 packets=2 skbaddr=0xffff900b72c334f0
> proc-19927 19927 [014] 580644.245749: probe:sch_direct_xmit: (ffffffff9b69e570) skb=0xffff900b72c334f0 q=0xffff900d7c247c00 dev=0xffff900d6a140000 txq=0xffff900d6a181180 root_lock=0x0 validate=1 ret=-1 again=155
> proc-19927 19927 [014] 580644.245750: net:net_dev_start_xmit: dev=eth0 queue_mapping=14 skbaddr=0xffff900b72c334f0 vlan_tagged=0 vlan_proto=0x0000 vlan_tci=0x0000 protocol=0x0800 ip_summed=3 len=115 data_len=0 network_offset=14 transport_offset_valid=1 transport_offset=34 tx_flags=0 gso_size=0 gso_segs=1 gso_type=0x1
>
> I was wondering if you had any more luck in finding a solution or workaround for this problem
> (that is, aside from switching to a different qdisc)?
>
> Thanks,
> ~ Michael
>
Jonas/Paolo
Do either of you know if there's been any development on a fix for this
issue? If not we can propose something.
Thanks
Josh
next prev parent reply other threads:[~2020-06-30 20:09 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 6:46 Packet gets stuck in NOLOCK pfifo_fast qdisc Jonas Bonn
2019-10-09 19:14 ` Paolo Abeni
2019-10-10 6:27 ` Jonas Bonn
2019-10-11 0:39 ` Jonas Bonn
2020-06-23 13:42 ` Michael Zhivich
2020-06-30 19:14 ` Josh Hunt [this message]
2020-07-01 7:53 ` Jonas Bonn
2020-07-01 16:05 ` Cong Wang
2020-07-01 19:58 ` Cong Wang
2020-07-01 22:02 ` Josh Hunt
2020-07-02 6:14 ` Jonas Bonn
2020-07-02 9:45 ` Paolo Abeni
2020-07-02 18:08 ` Josh Hunt
2020-07-07 14:18 ` Paolo Abeni
2020-07-08 20:16 ` Cong Wang
2020-07-09 9:20 ` Paolo Abeni
2020-07-08 20:33 ` Zhivich, Michael
2020-08-20 7:43 ` Jike Song
2020-08-20 18:13 ` Josh Hunt
[not found] ` <20200822032800.16296-1-hdanton@sina.com>
2020-08-25 2:18 ` Fengkehuan Feng
[not found] ` <20200825032312.11776-1-hdanton@sina.com>
2020-08-25 7:14 ` Fengkehuan Feng
[not found] ` <20200825162329.11292-1-hdanton@sina.com>
2020-08-26 2:38 ` Kehuan Feng
[not found] ` <CACS=qqKptAQQGiMoCs1Zgs9S4ZppHhasy1AK4df2NxnCDR+vCw@mail.gmail.com>
[not found] ` <5f46032e.1c69fb81.9880c.7a6cSMTPIN_ADDED_MISSING@mx.google.com>
2020-08-27 6:56 ` Kehuan Feng
[not found] ` <20200827125747.5816-1-hdanton@sina.com>
2020-08-28 1:45 ` Kehuan Feng
2020-09-03 5:01 ` Cong Wang
2020-09-03 8:39 ` Paolo Abeni
2020-09-03 17:43 ` Cong Wang
2020-09-04 5:07 ` John Fastabend
2020-09-10 20:15 ` Cong Wang
2020-09-10 21:07 ` John Fastabend
2020-09-10 21:40 ` Paolo Abeni
2021-04-02 19:25 ` Jiri Kosina
2021-04-02 19:33 ` Josh Hunt
[not found] ` <20210403003537.2032-1-hdanton@sina.com>
2021-04-03 12:23 ` Jiri Kosina
2021-04-06 0:55 ` Yunsheng Lin
2021-04-06 7:06 ` Michal Kubecek
2021-04-06 10:13 ` Juergen Gross
2021-04-06 12:17 ` Yunsheng Lin
2021-04-06 1:49 ` Cong Wang
2021-04-06 2:46 ` Yunsheng Lin
2021-04-06 7:31 ` Michal Kubecek
2021-04-06 12:24 ` Yunsheng Lin
[not found] ` <20200903101957.428-1-hdanton@sina.com>
2020-09-04 3:20 ` Kehuan Feng
2020-09-10 20:19 ` Cong Wang
2020-09-14 2:10 ` Yunsheng Lin
2020-09-17 19:52 ` Cong Wang
2020-09-18 2:06 ` Kehuan Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1849b74f-163c-8cfa-baa5-f653159fefd4@akamai.com \
--to=johunt@akamai.com \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=jonas.bonn@netrounds.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mzhivich@akamai.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).