* hns3: Compilation of hns3_enet.c is triggered without changes
@ 2018-12-29 13:10 Stefan Wahren
2019-01-02 10:44 ` John Garry
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Wahren @ 2018-12-29 13:10 UTC (permalink / raw)
To: Yisen Zhuang, Salil Mehta; +Cc: netdev
Hi,
during development i noticed that hns3_enet.c is compiled even without any changes to this file.
I think the reason for this is the usage of VERMAGIC_STRING in this file. So it would be nice if you could somehow replace this define.
Kind regards
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: hns3: Compilation of hns3_enet.c is triggered without changes
2018-12-29 13:10 hns3: Compilation of hns3_enet.c is triggered without changes Stefan Wahren
@ 2019-01-02 10:44 ` John Garry
0 siblings, 0 replies; 2+ messages in thread
From: John Garry @ 2019-01-02 10:44 UTC (permalink / raw)
To: Stefan Wahren, Yisen Zhuang, Salil Mehta; +Cc: netdev, Linuxarm, linux-kernel
On 29/12/2018 13:10, Stefan Wahren wrote:
> Hi,
>
> during development i noticed that hns3_enet.c is compiled even without any changes to this file.
>
> I think the reason for this is the usage of VERMAGIC_STRING in this file. So it would be nice if you could somehow replace this define.
>
> Kind regards
> Stefan
>
>
I reported this issue internally some time ago. Apparently it is
required to reference VERMAGIC_STRING, but I don't know why.
I see that this driver has similar issue:
https://elixir.bootlin.com/linux/latest/source/drivers/net/ethernet/netronome/nfp/nfp_main.c#L34
Another annoying thing I find is the amount of references to UTS_RELEASE
(which also causes rebuilds), like:
https://elixir.bootlin.com/linux/latest/source/drivers/base/firmware_loader/main.c#L281
Can't we just make a static string for these, to save the rebuilding the
dependent modules?
Thanks,
John
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-02 10:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-29 13:10 hns3: Compilation of hns3_enet.c is triggered without changes Stefan Wahren
2019-01-02 10:44 ` John Garry
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).