netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Jonas Bonn <jonas@norrbonn.se>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: davem@davemloft.net
Subject: Re: [PATCH 2/5] rtnetlink: skip namespace change if already effect
Date: Tue, 5 Nov 2019 16:42:31 +0100	[thread overview]
Message-ID: <1a6ff19a-36f5-ec3e-3616-5dc142635223@6wind.com> (raw)
In-Reply-To: <20191105081112.16656-3-jonas@norrbonn.se>

Le 05/11/2019 à 09:11, Jonas Bonn a écrit :
> RTM_SETLINK uses IFA_TARGET_NETNSID both as a selector for the device to
> act upon and as a selection of the namespace to move a device in the
> current namespace to.  As such, one ends up in the code path for setting
> the namespace every time one calls setlink on a device outside the
> current namespace.  This has the unfortunate side effect of setting the
> 'modified' flag on the device for every pass, resulting in Netlink
> notifications even when nothing was changed.
> 
> This patch just makes the namespace switch dependent upon the namespace
> the device currently resides in.
> 
> Signed-off-by: Jonas Bonn <jonas@norrbonn.se>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>

  reply	other threads:[~2019-11-05 15:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05  8:11 [PATCH 0/5] Add namespace awareness to Netlink methods Jonas Bonn
2019-11-05  8:11 ` [PATCH 1/5] rtnetlink: allow RTM_SETLINK to reference other namespaces Jonas Bonn
2019-11-05 15:41   ` Nicolas Dichtel
2019-11-05  8:11 ` [PATCH 2/5] rtnetlink: skip namespace change if already effect Jonas Bonn
2019-11-05 15:42   ` Nicolas Dichtel [this message]
2019-11-05  8:11 ` [PATCH 3/5] rtnetlink: allow RTM_NEWLINK to act upon interfaces in arbitrary namespaces Jonas Bonn
2019-11-05 15:43   ` Nicolas Dichtel
2019-11-05  8:11 ` [PATCH 4/5] net: ipv4: allow setting address on interface outside current namespace Jonas Bonn
2019-11-05 15:47   ` Nicolas Dichtel
2019-11-05  8:11 ` [PATCH 5/5] net: namespace: allow setting NSIDs " Jonas Bonn
2019-11-05 15:49   ` Nicolas Dichtel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a6ff19a-36f5-ec3e-3616-5dc142635223@6wind.com \
    --to=nicolas.dichtel@6wind.com \
    --cc=davem@davemloft.net \
    --cc=jonas@norrbonn.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).