From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: Jonas Bonn <jonas@norrbonn.se>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: davem@davemloft.net
Subject: Re: [PATCH 4/5] net: ipv4: allow setting address on interface outside current namespace
Date: Tue, 5 Nov 2019 16:47:44 +0100 [thread overview]
Message-ID: <ae1d28b3-f62f-c58e-d478-980f47fe4fea@6wind.com> (raw)
In-Reply-To: <20191105081112.16656-5-jonas@norrbonn.se>
Le 05/11/2019 à 09:11, Jonas Bonn a écrit :
> This patch allows an interface outside of the current namespace to be
> selected when setting a new IPv4 address for a device. This uses the
> IFA_TARGET_NETNSID attribute to select the namespace in which to search
> for the interface to act upon.
>
> Signed-off-by: Jonas Bonn <jonas@norrbonn.se>
> ---
[snip]
> @@ -945,10 +961,11 @@ static int inet_rtm_newaddr(struct sk_buff *skb, struct nlmsghdr *nlh,
>
> if (ret < 0) {
> inet_free_ifa(ifa);
> - return ret;
> + err = ret;
> + goto out;
> }
> }
> - return __inet_insert_ifa(ifa, nlh, NETLINK_CB(skb).portid,
> + err = __inet_insert_ifa(ifa, nlh, NETLINK_CB(skb).portid,
> extack);
if (err < 0)
goto out;
?
else err is set to 0 later.
> } else {
> u32 new_metric = ifa->ifa_rt_priority;
> @@ -956,8 +973,10 @@ static int inet_rtm_newaddr(struct sk_buff *skb, struct nlmsghdr *nlh,
> inet_free_ifa(ifa);
>
> if (nlh->nlmsg_flags & NLM_F_EXCL ||
> - !(nlh->nlmsg_flags & NLM_F_REPLACE))
> - return -EEXIST;
> + !(nlh->nlmsg_flags & NLM_F_REPLACE)) {
> + err = -EEXIST;
> + goto out;
> + }
> ifa = ifa_existing;
>
> if (ifa->ifa_rt_priority != new_metric) {
> @@ -971,7 +990,14 @@ static int inet_rtm_newaddr(struct sk_buff *skb, struct nlmsghdr *nlh,
> &check_lifetime_work, 0);
> rtmsg_ifa(RTM_NEWADDR, ifa, nlh, NETLINK_CB(skb).portid);
> }
> - return 0;
> +
> + err = 0;
here.
Regards,
Nicolas
next prev parent reply other threads:[~2019-11-05 15:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 8:11 [PATCH 0/5] Add namespace awareness to Netlink methods Jonas Bonn
2019-11-05 8:11 ` [PATCH 1/5] rtnetlink: allow RTM_SETLINK to reference other namespaces Jonas Bonn
2019-11-05 15:41 ` Nicolas Dichtel
2019-11-05 8:11 ` [PATCH 2/5] rtnetlink: skip namespace change if already effect Jonas Bonn
2019-11-05 15:42 ` Nicolas Dichtel
2019-11-05 8:11 ` [PATCH 3/5] rtnetlink: allow RTM_NEWLINK to act upon interfaces in arbitrary namespaces Jonas Bonn
2019-11-05 15:43 ` Nicolas Dichtel
2019-11-05 8:11 ` [PATCH 4/5] net: ipv4: allow setting address on interface outside current namespace Jonas Bonn
2019-11-05 15:47 ` Nicolas Dichtel [this message]
2019-11-05 8:11 ` [PATCH 5/5] net: namespace: allow setting NSIDs " Jonas Bonn
2019-11-05 15:49 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae1d28b3-f62f-c58e-d478-980f47fe4fea@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=davem@davemloft.net \
--cc=jonas@norrbonn.se \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).