From: Cristian Marussi <cristian.marussi@arm.com>
To: Shuah Khan <skhan@linuxfoundation.org>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: "open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: Linux 5.4 - bpf test build fails
Date: Tue, 24 Sep 2019 16:52:56 +0100 [thread overview]
Message-ID: <1d1bbc01-5cf4-72e6-76b3-754d23366c8f@arm.com> (raw)
In-Reply-To: <742ecabe-45ce-cf6e-2540-25d6dc23c45f@linuxfoundation.org>
Hi Shuah
On 24/09/2019 16:26, Shuah Khan wrote:
> Hi Alexei and Daniel,
>
> bpf test doesn't build on Linux 5.4 mainline. Do you know what's
> happening here.
>
>
> make -C tools/testing/selftests/bpf/
side question, since I'm writing arm64/ tests.
my "build-testcases" following the KSFT docs are:
make kselftest
make TARGETS=arm64 kselftest
make -C tools/testing/selftests/
make -C tools/testing/selftests/ INSTALL_PATH=<install-path> install
make TARGETS=arm64 -C tools/testing/selftests/
make TARGETS=arm64 -C tools/testing/selftests/ INSTALL_PATH=<install-path> install
./kselftest_install.sh <install-path>
(and related clean targets...)
but definitely NOT
make -C tools/testing/selftests/arm64
(for simplicity....due to the subdirs structure under tools/testing/selftests/arm64/)
am I wrong ?
Thanks
Cristian
>
> -c progs/test_core_reloc_ptr_as_arr.c -o - || echo "clang failed") | \
> llc -march=bpf -mcpu=generic -filetype=obj -o
> /mnt/data/lkml/linux_5.4/tools/testing/selftests/bpf/test_core_reloc_ptr_as_arr.o
> progs/test_core_reloc_ptr_as_arr.c:25:6: error: use of unknown builtin
> '__builtin_preserve_access_index' [-Wimplicit-function-declaration]
> if (BPF_CORE_READ(&out->a, &in[2].a))
> ^
> ./bpf_helpers.h:533:10: note: expanded from macro 'BPF_CORE_READ'
> __builtin_preserve_access_index(src))
> ^
> progs/test_core_reloc_ptr_as_arr.c:25:6: warning: incompatible integer to
> pointer conversion passing 'int' to parameter of type 'const void *'
> [-Wint-conversion]
> if (BPF_CORE_READ(&out->a, &in[2].a))
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ./bpf_helpers.h:533:10: note: expanded from macro 'BPF_CORE_READ'
> __builtin_preserve_access_index(src))
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1 warning and 1 error generated.
> llc: error: llc: <stdin>:1:1: error: expected top-level entity
> clang failed
>
> Also
>
> make TARGETS=bpf kselftest fails as well. Dependency between
> tools/lib/bpf and the test. How can we avoid this type of
> dependency or resolve it in a way it doesn't result in build
> failures?
>
> thanks,
> -- Shuah
>
next prev parent reply other threads:[~2019-09-24 15:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 15:26 Linux 5.4 - bpf test build fails Shuah Khan
2019-09-24 15:43 ` Yonghong Song
2019-09-24 15:48 ` Shuah Khan
2019-09-24 18:49 ` Daniel Borkmann
2019-09-24 18:56 ` Shuah Khan
2019-09-24 19:19 ` Daniel Borkmann
2019-09-24 19:48 ` Shuah Khan
2019-09-24 15:52 ` Cristian Marussi [this message]
2019-09-24 16:03 ` Shuah Khan
2019-09-24 16:39 ` Shuah Khan
2019-09-24 17:29 ` Cristian Marussi
2019-09-24 18:07 ` Tim.Bird
2019-09-24 18:23 ` Shuah Khan
2019-09-25 8:52 ` Cristian Marussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d1bbc01-5cf4-72e6-76b3-754d23366c8f@arm.com \
--to=cristian.marussi@arm.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).