From: Shuah Khan <skhan@linuxfoundation.org>
To: Cristian Marussi <cristian.marussi@arm.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>
Cc: "open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: Linux 5.4 - bpf test build fails
Date: Tue, 24 Sep 2019 10:39:23 -0600 [thread overview]
Message-ID: <a603ee8e-b0af-6506-0667-77269b0951b2@linuxfoundation.org> (raw)
In-Reply-To: <34a9bd63-a251-0b4f-73b6-06b9bbf9d3fa@linuxfoundation.org>
On 9/24/19 10:03 AM, Shuah Khan wrote:
> On 9/24/19 9:52 AM, Cristian Marussi wrote:
>> Hi Shuah
>>
>> On 24/09/2019 16:26, Shuah Khan wrote:
>>> Hi Alexei and Daniel,
>>>
>>> bpf test doesn't build on Linux 5.4 mainline. Do you know what's
>>> happening here.
>>>
>>>
>>> make -C tools/testing/selftests/bpf/
>>
>> side question, since I'm writing arm64/ tests.
>>
>> my "build-testcases" following the KSFT docs are:
>>
>> make kselftest
>> make TARGETS=arm64 kselftest
>> make -C tools/testing/selftests/
>> make -C tools/testing/selftests/ INSTALL_PATH=<install-path> install
>> make TARGETS=arm64 -C tools/testing/selftests/
>> make TARGETS=arm64 -C tools/testing/selftests/
>> INSTALL_PATH=<install-path> install
>> ./kselftest_install.sh <install-path>
Cristian,
That being said, I definitely want to see this list limited to
a few options.
One problem is that if somebody wants to do just a build, there
is no option from the main makefile. I have sent support for that
a few months ago and the patch didn't got lost it appears. I am
working on resending those patches. The same is true for install.
I sent in a patch for that a while back and I am going to resend.
These will make it easier for users.
I would really want to get to supporting only these options:
These are supported now:
make kselftest
make TARGETS=arm64 kselftest (one or more targets)
Replace the following:
make -C tools/testing/selftests/ with
make kselftes_build option from main makefile
Replace this:
make -C tools/testing/selftests/ INSTALL_PATH=<install-path> install
with
make kselftest_install
That way we can support all the use-cases from the main Makefile
thanks,
-- Shuah
next prev parent reply other threads:[~2019-09-24 16:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 15:26 Linux 5.4 - bpf test build fails Shuah Khan
2019-09-24 15:43 ` Yonghong Song
2019-09-24 15:48 ` Shuah Khan
2019-09-24 18:49 ` Daniel Borkmann
2019-09-24 18:56 ` Shuah Khan
2019-09-24 19:19 ` Daniel Borkmann
2019-09-24 19:48 ` Shuah Khan
2019-09-24 15:52 ` Cristian Marussi
2019-09-24 16:03 ` Shuah Khan
2019-09-24 16:39 ` Shuah Khan [this message]
2019-09-24 17:29 ` Cristian Marussi
2019-09-24 18:07 ` Tim.Bird
2019-09-24 18:23 ` Shuah Khan
2019-09-25 8:52 ` Cristian Marussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a603ee8e-b0af-6506-0667-77269b0951b2@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=cristian.marussi@arm.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).