From: David Ahern <dsahern@gmail.com>
To: Ido Schimmel <idosch@idosch.org>, netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, roopa@nvidia.com,
sharpd@nvidia.com, mlxsw@nvidia.com,
Ido Schimmel <idosch@nvidia.com>
Subject: Re: [RFC PATCH net 1/2] nexthop: Do not flush blackhole nexthops when loopback goes down
Date: Sun, 28 Feb 2021 16:40:13 -0700 [thread overview]
Message-ID: <1db96a26-9500-aa3d-16ce-2774e6dcc5f2@gmail.com> (raw)
In-Reply-To: <20210228142613.1642938-2-idosch@idosch.org>
On 2/28/21 7:26 AM, Ido Schimmel wrote:
> From: Ido Schimmel <idosch@nvidia.com>
>
> As far as user space is concerned, blackhole nexthops do not have a
> nexthop device and therefore should not be affected by the
> administrative or carrier state of any netdev.
>
> However, when the loopback netdev goes down all the blackhole nexthops
> are flushed. This happens because internally the kernel associates
> blackhole nexthops with the loopback netdev.
That was not intended, so definitely a bug.
>
> This behavior is both confusing to those not familiar with kernel
> internals and also diverges from the legacy API where blackhole IPv4
> routes are not flushed when the loopback netdev goes down:
>
> # ip route add blackhole 198.51.100.0/24
> # ip link set dev lo down
> # ip route show 198.51.100.0/24
> blackhole 198.51.100.0/24
>
> Blackhole IPv6 routes are flushed, but at least user space knows that
> they are associated with the loopback netdev:
>
> # ip -6 route show 2001:db8:1::/64
> blackhole 2001:db8:1::/64 dev lo metric 1024 pref medium
>
> Fix this by only flushing blackhole nexthops when the loopback netdev is
> unregistered.
>
> Fixes: ab84be7e54fc ("net: Initial nexthop code")
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> Reported-by: Donald Sharp <sharpd@nvidia.com>
> ---
> net/ipv4/nexthop.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c
> index f1c6cbdb9e43..743777bce179 100644
> --- a/net/ipv4/nexthop.c
> +++ b/net/ipv4/nexthop.c
> @@ -1399,7 +1399,7 @@ static int insert_nexthop(struct net *net, struct nexthop *new_nh,
>
> /* rtnl */
> /* remove all nexthops tied to a device being deleted */
> -static void nexthop_flush_dev(struct net_device *dev)
> +static void nexthop_flush_dev(struct net_device *dev, unsigned long event)
> {
> unsigned int hash = nh_dev_hashfn(dev->ifindex);
> struct net *net = dev_net(dev);
> @@ -1411,6 +1411,10 @@ static void nexthop_flush_dev(struct net_device *dev)
> if (nhi->fib_nhc.nhc_dev != dev)
> continue;
>
> + if (nhi->reject_nh &&
> + (event == NETDEV_DOWN || event == NETDEV_CHANGE))
> + continue;
> +
> remove_nexthop(net, nhi->nh_parent, NULL);
> }
> }
> @@ -2189,11 +2193,11 @@ static int nh_netdev_event(struct notifier_block *this,
> switch (event) {
> case NETDEV_DOWN:
> case NETDEV_UNREGISTER:
> - nexthop_flush_dev(dev);
> + nexthop_flush_dev(dev, event);
> break;
> case NETDEV_CHANGE:
> if (!(dev_get_flags(dev) & (IFF_RUNNING | IFF_LOWER_UP)))
> - nexthop_flush_dev(dev);
> + nexthop_flush_dev(dev, event);
> break;
> case NETDEV_CHANGEMTU:
> info_ext = ptr;
>
LGTM. I suggest submitting without the RFC.
Reviewed-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2021-02-28 23:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-28 14:26 [RFC PATCH net 0/2] nexthop: Do not flush blackhole nexthops when loopback goes down Ido Schimmel
2021-02-28 14:26 ` [RFC PATCH net 1/2] " Ido Schimmel
2021-02-28 23:40 ` David Ahern [this message]
2021-03-01 8:27 ` Ido Schimmel
2021-02-28 14:26 ` [RFC PATCH net 2/2] selftests: fib_nexthops: Test " Ido Schimmel
2021-02-28 23:41 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1db96a26-9500-aa3d-16ce-2774e6dcc5f2@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@nvidia.com \
--cc=sharpd@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).