From: David Ahern <dsahern@gmail.com>
To: Ido Schimmel <idosch@idosch.org>, netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, roopa@nvidia.com,
sharpd@nvidia.com, mlxsw@nvidia.com,
Ido Schimmel <idosch@nvidia.com>
Subject: Re: [RFC PATCH net 2/2] selftests: fib_nexthops: Test blackhole nexthops when loopback goes down
Date: Sun, 28 Feb 2021 16:41:09 -0700 [thread overview]
Message-ID: <75d794f7-e0f2-503e-b858-f60114706fe2@gmail.com> (raw)
In-Reply-To: <20210228142613.1642938-3-idosch@idosch.org>
On 2/28/21 7:26 AM, Ido Schimmel wrote:
> From: Ido Schimmel <idosch@nvidia.com>
>
> Test that blackhole nexthops are not flushed when the loopback device
> goes down.
>
>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
> tools/testing/selftests/net/fib_nexthops.sh | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/tools/testing/selftests/net/fib_nexthops.sh b/tools/testing/selftests/net/fib_nexthops.sh
> index 4c7d33618437..d98fb85e201c 100755
> --- a/tools/testing/selftests/net/fib_nexthops.sh
> +++ b/tools/testing/selftests/net/fib_nexthops.sh
> @@ -1524,6 +1524,14 @@ basic()
> run_cmd "$IP nexthop replace id 2 blackhole dev veth1"
> log_test $? 2 "Blackhole nexthop with other attributes"
>
> + # blackhole nexthop should not be affected by the state of the loopback
> + # device
> + run_cmd "$IP link set dev lo down"
> + check_nexthop "id 2" "id 2 blackhole"
> + log_test $? 0 "Blackhole nexthop with loopback device down"
> +
> + run_cmd "$IP link set dev lo up"
> +
> #
> # groups
> #
>
Thanks for adding a test.
Reviewed-by: David Ahern <dsahern@gmail.com>
prev parent reply other threads:[~2021-02-28 23:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-28 14:26 [RFC PATCH net 0/2] nexthop: Do not flush blackhole nexthops when loopback goes down Ido Schimmel
2021-02-28 14:26 ` [RFC PATCH net 1/2] " Ido Schimmel
2021-02-28 23:40 ` David Ahern
2021-03-01 8:27 ` Ido Schimmel
2021-02-28 14:26 ` [RFC PATCH net 2/2] selftests: fib_nexthops: Test " Ido Schimmel
2021-02-28 23:41 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75d794f7-e0f2-503e-b858-f60114706fe2@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@nvidia.com \
--cc=sharpd@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).