* [PATCH] mptcp: print new line in mptcp_seq_show() if mptcp isn't in use
@ 2020-12-04 8:36 Jianguo Wu
2020-12-04 15:21 ` Florian Westphal
0 siblings, 1 reply; 4+ messages in thread
From: Jianguo Wu @ 2020-12-04 8:36 UTC (permalink / raw)
To: netdev; +Cc: mathew.j.martineau, pabeni, fw, davem
From: Jianguo Wu <wujianguo@chinatelecom.cn>
Signed-off-by: Jianguo Wu <wujianguo@chinatelecom.cn>
---
net/mptcp/mib.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/mptcp/mib.c b/net/mptcp/mib.c
index 84d1194..b921cbd 100644
--- a/net/mptcp/mib.c
+++ b/net/mptcp/mib.c
@@ -67,6 +67,7 @@ void mptcp_seq_show(struct seq_file *seq)
for (i = 0; mptcp_snmp_list[i].name; i++)
seq_puts(seq, " 0");
+ seq_putc(seq, '\n');
return;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mptcp: print new line in mptcp_seq_show() if mptcp isn't in use
2020-12-04 8:36 [PATCH] mptcp: print new line in mptcp_seq_show() if mptcp isn't in use Jianguo Wu
@ 2020-12-04 15:21 ` Florian Westphal
2020-12-04 16:59 ` Jakub Kicinski
0 siblings, 1 reply; 4+ messages in thread
From: Florian Westphal @ 2020-12-04 15:21 UTC (permalink / raw)
To: Jianguo Wu; +Cc: netdev, mathew.j.martineau, pabeni, fw, davem
Jianguo Wu <wujianguo106@163.com> wrote:
> From: Jianguo Wu <wujianguo@chinatelecom.cn>
A brief explanation would have helped.
This is for net tree.
> Signed-off-by: Jianguo Wu <wujianguo@chinatelecom.cn>
Fixes: fc518953bc9c8d7d ("mptcp: add and use MIB counter infrastructure")
Acked-by: Florian Westphal <fw@strlen.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mptcp: print new line in mptcp_seq_show() if mptcp isn't in use
2020-12-04 15:21 ` Florian Westphal
@ 2020-12-04 16:59 ` Jakub Kicinski
2020-12-05 7:40 ` Jianguo Wu
0 siblings, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2020-12-04 16:59 UTC (permalink / raw)
To: Florian Westphal; +Cc: Jianguo Wu, netdev, mathew.j.martineau, pabeni, davem
On Fri, 4 Dec 2020 16:21:19 +0100 Florian Westphal wrote:
> Jianguo Wu <wujianguo106@163.com> wrote:
> > From: Jianguo Wu <wujianguo@chinatelecom.cn>
>
> A brief explanation would have helped.
Yes, please post a v2 with a sentence describing the problem and output
before and after the change.
> This is for net tree.
By which we mean please tag v2 as [PATCH net v2] in the subject.
> > Signed-off-by: Jianguo Wu <wujianguo@chinatelecom.cn>
>
> Fixes: fc518953bc9c8d7d ("mptcp: add and use MIB counter infrastructure")
> Acked-by: Florian Westphal <fw@strlen.de>
And please make sure to add these to your patch before posting so
Florian doesn't have to resend them.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mptcp: print new line in mptcp_seq_show() if mptcp isn't in use
2020-12-04 16:59 ` Jakub Kicinski
@ 2020-12-05 7:40 ` Jianguo Wu
0 siblings, 0 replies; 4+ messages in thread
From: Jianguo Wu @ 2020-12-05 7:40 UTC (permalink / raw)
To: Jakub Kicinski, Florian Westphal
Cc: netdev, mathew.j.martineau, pabeni, davem
OK,I will post v2 soon, thanks!
在 2020/12/5 0:59, Jakub Kicinski 写道:
> On Fri, 4 Dec 2020 16:21:19 +0100 Florian Westphal wrote:
>> Jianguo Wu <wujianguo106@163.com> wrote:
>>> From: Jianguo Wu <wujianguo@chinatelecom.cn>
>>
>> A brief explanation would have helped.
>
> Yes, please post a v2 with a sentence describing the problem and output
> before and after the change.
>
>> This is for net tree.
>
> By which we mean please tag v2 as [PATCH net v2] in the subject.
>
>>> Signed-off-by: Jianguo Wu <wujianguo@chinatelecom.cn>
>>
>> Fixes: fc518953bc9c8d7d ("mptcp: add and use MIB counter infrastructure")
>> Acked-by: Florian Westphal <fw@strlen.de>
>
> And please make sure to add these to your patch before posting so
> Florian doesn't have to resend them.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-05 11:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-04 8:36 [PATCH] mptcp: print new line in mptcp_seq_show() if mptcp isn't in use Jianguo Wu
2020-12-04 15:21 ` Florian Westphal
2020-12-04 16:59 ` Jakub Kicinski
2020-12-05 7:40 ` Jianguo Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).