netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* re commit d4f73c8e459d355e10051174d859ffd0ef5764c0
@ 2011-08-15 12:12 Jiri Pirko
  2011-08-19  5:03 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Jiri Pirko @ 2011-08-15 12:12 UTC (permalink / raw)
  To: romieu; +Cc: netdev, davem, stephan.baerwolf

Hi Francois.

Looking at mentioned commit, Not sure if the functionality is correct.
Your patch message says:

The non-tagged interface is filtered out as soon as a tagged
(!= 0) interface is created. Its traffic appears again when an
zero-tagged interface is created.

I would presume non-tagged packet would not be filtered any time.
Removing "WORD_REG_BITS_ON(MCFG_RTGOPT, &regs->MCFG);" should probably
do the trick.

Thanks.

Jirka


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: re commit d4f73c8e459d355e10051174d859ffd0ef5764c0
  2011-08-15 12:12 re commit d4f73c8e459d355e10051174d859ffd0ef5764c0 Jiri Pirko
@ 2011-08-19  5:03 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-08-19  5:03 UTC (permalink / raw)
  To: jpirko; +Cc: romieu, netdev, stephan.baerwolf

From: Jiri Pirko <jpirko@redhat.com>
Date: Mon, 15 Aug 2011 14:12:14 +0200

> Hi Francois.
> 
> Looking at mentioned commit, Not sure if the functionality is correct.

Francois is away on vacation so it may take some time for him to reply
to this.  Just FYI...

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-08-19  5:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-15 12:12 re commit d4f73c8e459d355e10051174d859ffd0ef5764c0 Jiri Pirko
2011-08-19  5:03 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).