* [PATCH 1/1] net/can/af_can.c: Change del_timer to del_timer_sync
@ 2011-08-31 9:57 Rajan Aggarwal
2011-08-31 17:28 ` Oliver Hartkopp
2011-09-15 19:07 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Rajan Aggarwal @ 2011-08-31 9:57 UTC (permalink / raw)
To: Oliver Hartkopp, Urs Thuermann, David S. Miller; +Cc: netdev
From: Rajan Aggarwal <Rajan Aggarwal rajan.aggarwal85@gmail.com>
This is important for SMP platform to check if timer function is
executing on other CPU with deleting the timer.
Signed-off-by: Rajan Aggarwal <Rajan Aggarwal rajan.aggarwal85@gmail.com>
---
net/can/af_can.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/can/af_can.c b/net/can/af_can.c
index 8ce926d..9b0c32a 100644
--- a/net/can/af_can.c
+++ b/net/can/af_can.c
@@ -857,7 +857,7 @@ static __exit void can_exit(void)
struct net_device *dev;
if (stats_timer)
- del_timer(&can_stattimer);
+ del_timer_sync(&can_stattimer);
can_remove_proc();
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] net/can/af_can.c: Change del_timer to del_timer_sync
2011-08-31 9:57 [PATCH 1/1] net/can/af_can.c: Change del_timer to del_timer_sync Rajan Aggarwal
@ 2011-08-31 17:28 ` Oliver Hartkopp
2011-09-15 19:07 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Oliver Hartkopp @ 2011-08-31 17:28 UTC (permalink / raw)
To: Rajan Aggarwal; +Cc: Urs Thuermann, David S. Miller, netdev
On 31.08.2011 11:57, Rajan Aggarwal wrote:
> From: Rajan Aggarwal <Rajan Aggarwal rajan.aggarwal85@gmail.com>
>
> This is important for SMP platform to check if timer function is
> executing on other CPU with deleting the timer.
>
> Signed-off-by: Rajan Aggarwal <Rajan Aggarwal rajan.aggarwal85@gmail.com>
> ---
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Tnx Rajan.
> net/can/af_can.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net/can/af_can.c b/net/can/af_can.c
> index 8ce926d..9b0c32a 100644
> --- a/net/can/af_can.c
> +++ b/net/can/af_can.c
> @@ -857,7 +857,7 @@ static __exit void can_exit(void)
> struct net_device *dev;
>
> if (stats_timer)
> - del_timer(&can_stattimer);
> + del_timer_sync(&can_stattimer);
>
> can_remove_proc();
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] net/can/af_can.c: Change del_timer to del_timer_sync
2011-08-31 9:57 [PATCH 1/1] net/can/af_can.c: Change del_timer to del_timer_sync Rajan Aggarwal
2011-08-31 17:28 ` Oliver Hartkopp
@ 2011-09-15 19:07 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2011-09-15 19:07 UTC (permalink / raw)
To: rajan.aggarwal85; +Cc: socketcan, urs.thuermann, netdev
From: Rajan Aggarwal <rajan.aggarwal85@gmail.com>
Date: Wed, 31 Aug 2011 15:27:38 +0530
> From: Rajan Aggarwal <Rajan Aggarwal rajan.aggarwal85@gmail.com>
>
> This is important for SMP platform to check if timer function is
> executing on other CPU with deleting the timer.
>
> Signed-off-by: Rajan Aggarwal <Rajan Aggarwal rajan.aggarwal85@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-15 19:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-31 9:57 [PATCH 1/1] net/can/af_can.c: Change del_timer to del_timer_sync Rajan Aggarwal
2011-08-31 17:28 ` Oliver Hartkopp
2011-09-15 19:07 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).