From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Glauber Costa <glommer@parallels.com>
Cc: linux-kernel@vger.kernel.org, paul@paulmenage.org,
lizf@cn.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com,
ebiederm@xmission.com, davem@davemloft.net, gthelen@google.com,
netdev@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 2/7] socket: initial cgroup code.
Date: Sat, 17 Sep 2011 20:52:07 +0300 [thread overview]
Message-ID: <20110917175207.GB1658@shutemov.name> (raw)
In-Reply-To: <1316051175-17780-3-git-send-email-glommer@parallels.com>
On Wed, Sep 14, 2011 at 10:46:10PM -0300, Glauber Costa wrote:
> We aim to control the amount of kernel memory pinned at any
> time by tcp sockets. To lay the foundations for this work,
> this patch adds a pointer to the kmem_cgroup to the socket
> structure.
>
> Signed-off-by: Glauber Costa <glommer@parallels.com>
> CC: David S. Miller <davem@davemloft.net>
> CC: Hiroyouki Kamezawa <kamezawa.hiroyu@jp.fujitsu.com>
> CC: Eric W. Biederman <ebiederm@xmission.com>
> ---
> include/linux/memcontrol.h | 38 ++++++++++++++++++++++++++++++++++++++
> include/net/sock.h | 2 ++
> net/core/sock.c | 3 +++
> 3 files changed, 43 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index 3b535db..be457ce 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -395,5 +395,43 @@ mem_cgroup_print_bad_page(struct page *page)
> }
> #endif
>
> +#ifdef CONFIG_INET
> +#ifdef CONFIG_CGROUP_MEM_RES_CTLR_KMEM
> +#include <net/sock.h>
> +static inline void sock_update_memcg(struct sock *sk)
> +{
> + /* right now a socket spends its whole life in the same cgroup */
> + BUG_ON(sk->sk_cgrp);
> +
> + rcu_read_lock();
> + sk->sk_cgrp = mem_cgroup_from_task(current);
> +
> + /*
> + * We don't need to protect against anything task-related, because
> + * we are basically stuck with the sock pointer that won't change,
> + * even if the task that originated the socket changes cgroups.
> + *
> + * What we do have to guarantee, is that the chain leading us to
> + * the top level won't change under our noses. Incrementing the
> + * reference count via cgroup_exclude_rmdir guarantees that.
> + */
> + cgroup_exclude_rmdir(mem_cgroup_css(sk->sk_cgrp));
> + rcu_read_unlock();
> +}
> +
> +static inline void sock_release_memcg(struct sock *sk)
> +{
> + cgroup_release_and_wakeup_rmdir(mem_cgroup_css(sk->sk_cgrp));
> +}
Do we really need to have these functions in the header?
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-09-17 17:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 1:46 [PATCH v2 0/7] per-cgroup tcp buffer pressure settings Glauber Costa
2011-09-15 1:46 ` [PATCH v2 1/7] Basic kernel memory functionality for the Memory Controller Glauber Costa
2011-09-17 17:45 ` Kirill A. Shutemov
2011-09-18 3:39 ` Glauber Costa
2011-09-18 19:05 ` Kirill A. Shutemov
2011-09-18 19:11 ` Glauber Costa
2011-09-18 20:39 ` Kirill A. Shutemov
2011-09-18 20:40 ` Glauber Costa
2011-09-18 20:43 ` Kirill A. Shutemov
2011-09-15 1:46 ` [PATCH v2 2/7] socket: initial cgroup code Glauber Costa
2011-09-17 17:52 ` Kirill A. Shutemov [this message]
2011-09-18 3:32 ` Glauber Costa
2011-09-18 18:58 ` Kirill A. Shutemov
2011-09-15 1:46 ` [PATCH v2 3/7] foundations of per-cgroup memory pressure controlling Glauber Costa
2011-09-15 1:46 ` [PATCH v2 4/7] per-cgroup tcp buffers control Glauber Costa
2011-09-17 18:11 ` Kirill A. Shutemov
2011-09-17 18:33 ` Cyrill Gorcunov
2011-09-18 3:32 ` Glauber Costa
2011-09-18 18:58 ` Kirill A. Shutemov
2011-09-18 19:42 ` Glauber Costa
2011-09-28 11:58 ` Andrew Wagin
2011-09-28 12:11 ` Glauber Costa
2011-09-15 1:46 ` [PATCH v2 5/7] per-netns ipv4 sysctl_tcp_mem Glauber Costa
2011-09-15 1:46 ` [PATCH v2 6/7] tcp buffer limitation: per-cgroup limit Glauber Costa
2011-09-17 12:12 ` Glauber Costa
2011-09-15 1:46 ` [PATCH v2 7/7] Display current tcp memory allocation in kmem cgroup Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110917175207.GB1658@shutemov.name \
--to=kirill@shutemov.name \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=glommer@parallels.com \
--cc=gthelen@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=netdev@vger.kernel.org \
--cc=paul@paulmenage.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).