* [PATCH] net: make bonding slaves honour master's skb->priority
@ 2011-10-25 4:41 Maciej Żenczykowski
2011-10-25 4:58 ` Jay Vosburgh
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Maciej Żenczykowski @ 2011-10-25 4:41 UTC (permalink / raw)
To: Maciej Żenczykowski; +Cc: netdev, Maciej Żenczykowski
From: Maciej Żenczykowski <maze@google.com>
Change-Id: Ieea6ff9aacacb1eb8c52308c8bfe091acbfc09b2
Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
drivers/net/bonding/bond_main.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 41430ba..2cbc2f8 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -395,7 +395,6 @@ int bond_dev_queue_xmit(struct bonding *bond, struct sk_buff *skb,
struct net_device *slave_dev)
{
skb->dev = slave_dev;
- skb->priority = 1;
skb->queue_mapping = bond_queue_mapping(skb);
--
1.7.3.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] net: make bonding slaves honour master's skb->priority
2011-10-25 4:41 [PATCH] net: make bonding slaves honour master's skb->priority Maciej Żenczykowski
@ 2011-10-25 4:58 ` Jay Vosburgh
2011-10-25 4:58 ` David Miller
2011-10-25 5:04 ` Maciej Żenczykowski
2 siblings, 0 replies; 9+ messages in thread
From: Jay Vosburgh @ 2011-10-25 4:58 UTC (permalink / raw)
To: Maciej Żenczykowski; +Cc: Maciej Żenczykowski, netdev
Maciej Żenczykowski <zenczykowski@gmail.com> wrote:
>From: Maciej Żenczykowski <maze@google.com>
>
>Change-Id: Ieea6ff9aacacb1eb8c52308c8bfe091acbfc09b2
The code change itself is ok, but I'm not sure what this
Change-Id is. With a regular log message, this should be fine to apply.
-J
>Signed-off-by: Maciej Żenczykowski <maze@google.com>
>---
> drivers/net/bonding/bond_main.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>index 41430ba..2cbc2f8 100644
>--- a/drivers/net/bonding/bond_main.c
>+++ b/drivers/net/bonding/bond_main.c
>@@ -395,7 +395,6 @@ int bond_dev_queue_xmit(struct bonding *bond, struct sk_buff *skb,
> struct net_device *slave_dev)
> {
> skb->dev = slave_dev;
>- skb->priority = 1;
>
> skb->queue_mapping = bond_queue_mapping(skb);
>
>--
>1.7.3.1
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] net: make bonding slaves honour master's skb->priority
2011-10-25 4:41 [PATCH] net: make bonding slaves honour master's skb->priority Maciej Żenczykowski
2011-10-25 4:58 ` Jay Vosburgh
@ 2011-10-25 4:58 ` David Miller
2011-10-25 5:02 ` Maciej Żenczykowski
2011-10-25 5:04 ` Maciej Żenczykowski
2 siblings, 1 reply; 9+ messages in thread
From: David Miller @ 2011-10-25 4:58 UTC (permalink / raw)
To: zenczykowski; +Cc: maze, netdev
From: Maciej Żenczykowski <zenczykowski@gmail.com>
Date: Mon, 24 Oct 2011 21:41:00 -0700
> From: Maciej Żenczykowski <maze@google.com>
>
> Change-Id: Ieea6ff9aacacb1eb8c52308c8bfe091acbfc09b2
What are these Change-Id tags? Please don't put these in
your commit message.
I'm dropping this patch, you'll need to resubmit it without
this thing.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] net: make bonding slaves honour master's skb->priority
2011-10-25 4:58 ` David Miller
@ 2011-10-25 5:02 ` Maciej Żenczykowski
0 siblings, 0 replies; 9+ messages in thread
From: Maciej Żenczykowski @ 2011-10-25 5:02 UTC (permalink / raw)
To: David Miller; +Cc: netdev
These are Gerrit (code review system) commit headers, normally I drop
them, I missed that here (they get added automatically by git hooks).
I'll send it again.
Sorry.
- Maciej
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] net: make bonding slaves honour master's skb->priority
2011-10-25 4:41 [PATCH] net: make bonding slaves honour master's skb->priority Maciej Żenczykowski
2011-10-25 4:58 ` Jay Vosburgh
2011-10-25 4:58 ` David Miller
@ 2011-10-25 5:04 ` Maciej Żenczykowski
2011-10-25 13:08 ` Flavio Leitner
2 siblings, 1 reply; 9+ messages in thread
From: Maciej Żenczykowski @ 2011-10-25 5:04 UTC (permalink / raw)
To: Maciej Żenczykowski; +Cc: netdev, Maciej Żenczykowski
From: Maciej Żenczykowski <maze@google.com>
Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
drivers/net/bonding/bond_main.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 41430ba..2cbc2f8 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -395,7 +395,6 @@ int bond_dev_queue_xmit(struct bonding *bond, struct sk_buff *skb,
struct net_device *slave_dev)
{
skb->dev = slave_dev;
- skb->priority = 1;
skb->queue_mapping = bond_queue_mapping(skb);
--
1.7.3.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] net: make bonding slaves honour master's skb->priority
2011-10-25 5:04 ` Maciej Żenczykowski
@ 2011-10-25 13:08 ` Flavio Leitner
2011-10-25 16:25 ` Maciej Żenczykowski
0 siblings, 1 reply; 9+ messages in thread
From: Flavio Leitner @ 2011-10-25 13:08 UTC (permalink / raw)
To: Maciej Żenczykowski; +Cc: Maciej Żenczykowski, netdev
On Mon, 24 Oct 2011 22:04:16 -0700
Maciej Żenczykowski <zenczykowski@gmail.com> wrote:
> From: Maciej Żenczykowski <maze@google.com>
>
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
> ---
> drivers/net/bonding/bond_main.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/bonding/bond_main.c
> b/drivers/net/bonding/bond_main.c index 41430ba..2cbc2f8 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -395,7 +395,6 @@ int bond_dev_queue_xmit(struct bonding *bond,
> struct sk_buff *skb, struct net_device *slave_dev)
> {
> skb->dev = slave_dev;
> - skb->priority = 1;
>
> skb->queue_mapping = bond_queue_mapping(skb);
>
I tripped on it few times and never understood why we
were fixing the priority at this point.
thanks,
Acked-by: Flavio Leitner <fbl@redhat.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] net: make bonding slaves honour master's skb->priority
2011-10-25 13:08 ` Flavio Leitner
@ 2011-10-25 16:25 ` Maciej Żenczykowski
2011-10-25 16:45 ` Jay Vosburgh
0 siblings, 1 reply; 9+ messages in thread
From: Maciej Żenczykowski @ 2011-10-25 16:25 UTC (permalink / raw)
To: Flavio Leitner; +Cc: netdev
> I tripped on it few times and never understood why we
> were fixing the priority at this point.
> thanks,
It looks like ancient code, going all the way back to something like
Linux 2.4.14 (if I recall my git blame session correctly).
I can't think of a good reason for this...
- Maciej
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] net: make bonding slaves honour master's skb->priority
2011-10-25 16:25 ` Maciej Żenczykowski
@ 2011-10-25 16:45 ` Jay Vosburgh
2011-10-25 23:22 ` David Miller
0 siblings, 1 reply; 9+ messages in thread
From: Jay Vosburgh @ 2011-10-25 16:45 UTC (permalink / raw)
To: =?UTF-8?Q?Maciej_=C5=BBenczykowski?=; +Cc: Flavio Leitner, netdev
Maciej Żenczykowski <zenczykowski@gmail.com> wrote:
>> I tripped on it few times and never understood why we
>> were fixing the priority at this point.
>> thanks,
>
>It looks like ancient code, going all the way back to something like
>Linux 2.4.14 (if I recall my git blame session correctly).
>I can't think of a good reason for this...
I believe this line goes back to the beginning, prior to git or
bk. The skb->priority probably meant something different than it does
today.
In any event, I'm fine with the code change. There's still no
actual log message, but if Davem is ok with that I'm ok with it, given
the trivial nature of the change.
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
-J
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] net: make bonding slaves honour master's skb->priority
2011-10-25 16:45 ` Jay Vosburgh
@ 2011-10-25 23:22 ` David Miller
0 siblings, 0 replies; 9+ messages in thread
From: David Miller @ 2011-10-25 23:22 UTC (permalink / raw)
To: fubar; +Cc: zenczykowski, fbl, netdev
From: Jay Vosburgh <fubar@us.ibm.com>
Date: Tue, 25 Oct 2011 09:45:35 -0700
> Maciej Żenczykowski <zenczykowski@gmail.com> wrote:
>
>>> I tripped on it few times and never understood why we
>>> were fixing the priority at this point.
>>> thanks,
>>
>>It looks like ancient code, going all the way back to something like
>>Linux 2.4.14 (if I recall my git blame session correctly).
>>I can't think of a good reason for this...
>
> I believe this line goes back to the beginning, prior to git or
> bk. The skb->priority probably meant something different than it does
> today.
>
> In any event, I'm fine with the code change. There's still no
> actual log message, but if Davem is ok with that I'm ok with it, given
> the trivial nature of the change.
>
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-10-25 23:22 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-25 4:41 [PATCH] net: make bonding slaves honour master's skb->priority Maciej Żenczykowski
2011-10-25 4:58 ` Jay Vosburgh
2011-10-25 4:58 ` David Miller
2011-10-25 5:02 ` Maciej Żenczykowski
2011-10-25 5:04 ` Maciej Żenczykowski
2011-10-25 13:08 ` Flavio Leitner
2011-10-25 16:25 ` Maciej Żenczykowski
2011-10-25 16:45 ` Jay Vosburgh
2011-10-25 23:22 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).