* Re: sky2: only 10Mb/s
[not found] <201110171434.50436.pavel@netsafe.cz>
@ 2011-10-17 15:56 ` Stephen Hemminger
2011-10-17 20:53 ` Pavel Matěja
2011-11-04 22:17 ` [PATCH] sky2: fix regression on Yukon Optima Stephen Hemminger
1 sibling, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2011-10-17 15:56 UTC (permalink / raw)
To: Pavel Mateja; +Cc: netdev
On Mon, 17 Oct 2011 14:34:50 +0200
Pavel Mateja <pavel@netsafe.cz> wrote:
> Hi,
> I tested new kernel and I have found out I have only 10Mb/s link instead of
> 100Mb/s to my router.
> If I did the git bisect right it was caused by commit
> 4fb99cd6ac4fe6d03a334a6f4ebb2bbfc4b479ed which was submitted by you.
>
> My card is (lspci -v):
> 05:00.0 Ethernet controller: Marvell Technology Group Ltd. Yukon Optima
> 88E8059 [PCIe Gigabit Ethernet Controller with AVB] (rev 11)
> Subsystem: ASUSTeK Computer Inc. Device 8439
> Flags: bus master, fast devsel, latency 0, IRQ 80
> Memory at fe6fc000 (64-bit, non-prefetchable) [size=16K]
> I/O ports at b800 [size=256]
> Expansion ROM at fe6c0000 [disabled] [size=128K]
> Capabilities: [48] Power Management version 3
> Capabilities: [5c] MSI: Enable+ Count=1/1 Maskable- 64bit+
> Capabilities: [c0] Express Legacy Endpoint, MSI 00
> Capabilities: [100] Advanced Error Reporting
> Capabilities: [130] Device Serial Number a5-89-6d-ff-ff-30-cf-20
> Kernel driver in use: sky2
>
> I'm quite sure it's related to Yukon Optima because "Ethernet controller:
> Marvell Technology Group Ltd. 88E8056 PCI-E Gigabit Ethernet Controller" in my
> work computer has 100Mb/s with the same kernel and driver.
>
> I got no response on netdev@vger.kernel.org.
> Can you help me?
What is output of dmesg for sky2.
dmesg | grep sky2
The problem is related to PHY setup. Almost all of that is copied from the
vendor driver. It might take a few steps to fix because I don't think I
have one of those cards handy.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: sky2: only 10Mb/s
2011-10-17 15:56 ` sky2: only 10Mb/s Stephen Hemminger
@ 2011-10-17 20:53 ` Pavel Matěja
2011-11-03 12:51 ` Kirill Smelkov
0 siblings, 1 reply; 6+ messages in thread
From: Pavel Matěja @ 2011-10-17 20:53 UTC (permalink / raw)
To: netdev; +Cc: Stephen Hemminger
> > Hi,
> > I tested new kernel and I have found out I have only 10Mb/s link instead
> > of 100Mb/s to my router.
> > If I did the git bisect right it was caused by commit
> > 4fb99cd6ac4fe6d03a334a6f4ebb2bbfc4b479ed which was submitted by you.
> >
> > My card is (lspci -v):
> > 05:00.0 Ethernet controller: Marvell Technology Group Ltd. Yukon Optima
> > 88E8059 [PCIe Gigabit Ethernet Controller with AVB] (rev 11)
> >
> > Subsystem: ASUSTeK Computer Inc. Device 8439
> > Flags: bus master, fast devsel, latency 0, IRQ 80
> > Memory at fe6fc000 (64-bit, non-prefetchable) [size=16K]
> > I/O ports at b800 [size=256]
> > Expansion ROM at fe6c0000 [disabled] [size=128K]
> > Capabilities: [48] Power Management version 3
> > Capabilities: [5c] MSI: Enable+ Count=1/1 Maskable- 64bit+
> > Capabilities: [c0] Express Legacy Endpoint, MSI 00
> > Capabilities: [100] Advanced Error Reporting
> > Capabilities: [130] Device Serial Number a5-89-6d-ff-ff-30-cf-20
> > Kernel driver in use: sky2
> >
> > I'm quite sure it's related to Yukon Optima because "Ethernet controller:
> > Marvell Technology Group Ltd. 88E8056 PCI-E Gigabit Ethernet Controller"
> > in my work computer has 100Mb/s with the same kernel and driver.
> >
> > I got no response on netdev@vger.kernel.org.
> > Can you help me?
>
> What is output of dmesg for sky2.
> dmesg | grep sky2
sky2: driver version 1.28
sky2 0000:05:00.0: PCI INT A -> GSI 51 (level, low) -> IRQ 51
sky2 0000:05:00.0: setting latency timer to 64
sky2 0000:05:00.0: Yukon-2 Optima chip revision 1
sky2 0000:05:00.0: irq 80 for MSI/MSI-X
sky2 0000:05:00.0: eth0: addr 20:cf:30:6d:89:a5
sky2 0000:05:00.0: eth0: enabling interface
sky2 0000:05:00.0: eth0: Link is up at 10 Mbps, full duplex, flow control both
--
Pavel Mateja
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: sky2: only 10Mb/s
2011-10-17 20:53 ` Pavel Matěja
@ 2011-11-03 12:51 ` Kirill Smelkov
0 siblings, 0 replies; 6+ messages in thread
From: Kirill Smelkov @ 2011-11-03 12:51 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Pavel Matěja, netdev
On Mon, Oct 17, 2011 at 10:53:39PM +0200, Pavel Matěja wrote:
> > > Hi,
> > > I tested new kernel and I have found out I have only 10Mb/s link instead
> > > of 100Mb/s to my router.
> > > If I did the git bisect right it was caused by commit
> > > 4fb99cd6ac4fe6d03a334a6f4ebb2bbfc4b479ed which was submitted by you.
> > >
> > > My card is (lspci -v):
> > > 05:00.0 Ethernet controller: Marvell Technology Group Ltd. Yukon Optima
> > > 88E8059 [PCIe Gigabit Ethernet Controller with AVB] (rev 11)
> > >
> > > Subsystem: ASUSTeK Computer Inc. Device 8439
> > > Flags: bus master, fast devsel, latency 0, IRQ 80
> > > Memory at fe6fc000 (64-bit, non-prefetchable) [size=16K]
> > > I/O ports at b800 [size=256]
> > > Expansion ROM at fe6c0000 [disabled] [size=128K]
> > > Capabilities: [48] Power Management version 3
> > > Capabilities: [5c] MSI: Enable+ Count=1/1 Maskable- 64bit+
> > > Capabilities: [c0] Express Legacy Endpoint, MSI 00
> > > Capabilities: [100] Advanced Error Reporting
> > > Capabilities: [130] Device Serial Number a5-89-6d-ff-ff-30-cf-20
> > > Kernel driver in use: sky2
> > >
> > > I'm quite sure it's related to Yukon Optima because "Ethernet controller:
> > > Marvell Technology Group Ltd. 88E8056 PCI-E Gigabit Ethernet Controller"
> > > in my work computer has 100Mb/s with the same kernel and driver.
> > >
> > > I got no response on netdev@vger.kernel.org.
> > > Can you help me?
> >
> > What is output of dmesg for sky2.
> > dmesg | grep sky2
>
> sky2: driver version 1.28
> sky2 0000:05:00.0: PCI INT A -> GSI 51 (level, low) -> IRQ 51
> sky2 0000:05:00.0: setting latency timer to 64
> sky2 0000:05:00.0: Yukon-2 Optima chip revision 1
> sky2 0000:05:00.0: irq 80 for MSI/MSI-X
> sky2 0000:05:00.0: eth0: addr 20:cf:30:6d:89:a5
> sky2 0000:05:00.0: eth0: enabling interface
> sky2 0000:05:00.0: eth0: Link is up at 10 Mbps, full duplex, flow control both
Similar problem here with 3.1.0 kernel:
# dmesg |grep sky2 (on 3.1.0)
[ 2.417340] sky2: driver version 1.29
[ 2.419844] sky2 0000:02:00.0: PCI INT A -> GSI 19 (level, low) -> IRQ 19
[ 2.422393] sky2 0000:02:00.0: setting latency timer to 64
[ 2.422444] sky2 0000:02:00.0: Yukon-2 Optima chip revision 1
[ 2.425414] sky2 0000:02:00.0: irq 42 for MSI/MSI-X
[ 2.426144] sky2 0000:02:00.0: eth0: addr 1c:c1:de:ae:73:8a
[ 10.836737] sky2 0000:02:00.0: eth0: enabling interface
[ 12.710240] sky2 0000:02:00.0: eth0: Link is up at 10 Mbps, full duplex, flow control rx
it used to setup the link to switch at 1 Gbps with Linux 3.0:
# dmesg |grep sky2 (on 3.0.0)
[ 2.442283] sky2: driver version 1.28
[ 2.444818] sky2 0000:02:00.0: PCI INT A -> GSI 19 (level, low) -> IRQ 19
[ 2.447345] sky2 0000:02:00.0: setting latency timer to 64
[ 2.447397] sky2 0000:02:00.0: Yukon-2 Optima chip revision 1
[ 2.450062] sky2 0000:02:00.0: irq 42 for MSI/MSI-X
[ 2.450712] sky2 0000:02:00.0: eth0: addr 1c:c1:de:ae:73:8a
[ 11.352480] sky2 0000:02:00.0: eth0: enabling interface
[ 13.824540] sky2 0000:02:00.0: eth0: Link is up at 1000 Mbps, full duplex, flow control rx
[ 13.827178] sky2 0000:02:00.0: eth0: Link is up at 1000 Mbps, full duplex, flow control rx
(strangely it puts 2 lines about "link is up")
Reverting 8dc47b9c2c9e9f607268f6bf3e85408123a36bca "sky2: support for
new Optima chipsets (EXPERIMENTAL)" helps.
# lspci -vv -s 02:00.0 (same with both 3.1.0 and 3.0.0)
02:00.0 Ethernet controller: Marvell Technology Group Ltd. 88E8059 PCI-E Gigabit Ethernet Controller (rev 11)
Subsystem: Hewlett-Packard Company Device 1608
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
Latency: 0, Cache Line Size: 64 bytes
Interrupt: pin A routed to IRQ 42
Region 0: Memory at 50100000 (64-bit, non-prefetchable) [size=16K]
Region 2: I/O ports at 2000 [size=256]
Expansion ROM at 50600000 [disabled] [size=128K]
Capabilities: [48] Power Management version 3
Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0+,D1+,D2+,D3hot+,D3cold+)
Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
Capabilities: [50] Vital Product Data
Product Name: Marvell Yukon 88E8059 Gigabit Ethernet Controller
Read-only fields:
[PN] Part number: Yukon 88E8059
[EC] Engineering changes: Rev. 1.0
[MN] Manufacture ID: 4d 61 72 76 65 6c 6c
[SN] Serial number: AbCdEfGAE738A
[CP] Extended capability: 01 10 cc 03
[RV] Reserved: checksum good, 9 byte(s) reserved
Read/write fields:
[RW] Read-write area: 121 byte(s) free
End
Capabilities: [5c] MSI: Enable+ Count=1/1 Maskable- 64bit+
Address: 00000000fee0300c Data: 4169
Capabilities: [c0] Express (v2) Legacy Endpoint, MSI 00
DevCap: MaxPayload 128 bytes, PhantFunc 0, Latency L0s unlimited, L1 unlimited
ExtTag- AttnBtn- AttnInd- PwrInd- RBE+ FLReset-
DevCtl: Report errors: Correctable- Non-Fatal- Fatal- Unsupported-
RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
MaxPayload 128 bytes, MaxReadReq 512 bytes
DevSta: CorrErr+ UncorrErr- FatalErr- UnsuppReq+ AuxPwr+ TransPend-
LnkCap: Port #0, Speed 2.5GT/s, Width x1, ASPM L0s L1, Latency L0 <1us, L1 <32us
ClockPM+ Surprise- LLActRep- BwNot-
LnkCtl: ASPM Disabled; RCB 128 bytes Disabled- Retrain- CommClk-
ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
LnkSta: Speed 2.5GT/s, Width x1, TrErr- Train- SlotClk+ DLActive- BWMgmt- ABWMgmt-
DevCap2: Completion Timeout: Not Supported, TimeoutDis+
DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis-
LnkCtl2: Target Link Speed: 2.5GT/s, EnterCompliance- SpeedDis-, Selectable De-emphasis: -6dB
Transmit Margin: Normal Operating Range, EnterModifiedCompliance- ComplianceSOS-
Compliance De-emphasis: -6dB
LnkSta2: Current De-emphasis Level: -6dB
Kernel driver in use: sky2
Thanks beforehand,
Kirill
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] sky2: fix regression on Yukon Optima
[not found] <201110171434.50436.pavel@netsafe.cz>
2011-10-17 15:56 ` sky2: only 10Mb/s Stephen Hemminger
@ 2011-11-04 22:17 ` Stephen Hemminger
2011-11-04 22:20 ` David Miller
1 sibling, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2011-11-04 22:17 UTC (permalink / raw)
To: Pavel Mateja, David Miller; +Cc: netdev
Changes to support other Optima types, introduced an accidental
regression that caused 88E8059 to come up in 10Mbit/sec.
The Yukon Optima supports a reverse auto-negotiation feature that
was incorrectly setup, and not needed. The feature could be used to
allow wake-on-lan at higher speeds. But doing it correctly would require
other changes to initialization.
Reported-by: Pavel Mateja <pavel@netsafe.cz>
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
---
This version is for current driver organization (post 3.1).
Same fix applies but to drivers/net/sky2.c in -stable.
--- a/drivers/net/ethernet/marvell/sky2.c 2011-11-02 15:38:11.677011133 -0700
+++ b/drivers/net/ethernet/marvell/sky2.c 2011-11-04 15:01:51.310888300 -0700
@@ -366,17 +366,6 @@ static void sky2_phy_init(struct sky2_hw
gm_phy_write(hw, port, PHY_MARV_FE_SPEC_2, spec);
}
} else {
- if (hw->chip_id >= CHIP_ID_YUKON_OPT) {
- u16 ctrl2 = gm_phy_read(hw, port, PHY_MARV_EXT_CTRL_2);
-
- /* enable PHY Reverse Auto-Negotiation */
- ctrl2 |= 1u << 13;
-
- /* Write PHY changes (SW-reset must follow) */
- gm_phy_write(hw, port, PHY_MARV_EXT_CTRL_2, ctrl2);
- }
-
-
/* disable energy detect */
ctrl &= ~PHY_M_PC_EN_DET_MSK;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] sky2: fix regression on Yukon Optima
2011-11-04 22:17 ` [PATCH] sky2: fix regression on Yukon Optima Stephen Hemminger
@ 2011-11-04 22:20 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2011-11-04 22:20 UTC (permalink / raw)
To: shemminger; +Cc: pavel, netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Fri, 4 Nov 2011 15:17:17 -0700
> Changes to support other Optima types, introduced an accidental
> regression that caused 88E8059 to come up in 10Mbit/sec.
>
> The Yukon Optima supports a reverse auto-negotiation feature that
> was incorrectly setup, and not needed. The feature could be used to
> allow wake-on-lan at higher speeds. But doing it correctly would require
> other changes to initialization.
>
> Reported-by: Pavel Mateja <pavel@netsafe.cz>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
> ---
> This version is for current driver organization (post 3.1).
> Same fix applies but to drivers/net/sky2.c in -stable.
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* sky2: only 10Mb/s
@ 2011-10-15 17:58 Pavel Matěja
0 siblings, 0 replies; 6+ messages in thread
From: Pavel Matěja @ 2011-10-15 17:58 UTC (permalink / raw)
To: netdev
Hi,
I tested new kernel and I have found out I have only 10Mb/s link instead of
100Mb/s to my router.
If I did the git bisect right it was caused by commit
4fb99cd6ac4fe6d03a334a6f4ebb2bbfc4b479ed
My card is (lspci -v):
05:00.0 Ethernet controller: Marvell Technology Group Ltd. Yukon Optima
88E8059 [PCIe Gigabit Ethernet Controller with AVB] (rev 11)
Subsystem: ASUSTeK Computer Inc. Device 8439
Flags: bus master, fast devsel, latency 0, IRQ 80
Memory at fe6fc000 (64-bit, non-prefetchable) [size=16K]
I/O ports at b800 [size=256]
Expansion ROM at fe6c0000 [disabled] [size=128K]
Capabilities: [48] Power Management version 3
Capabilities: [5c] MSI: Enable+ Count=1/1 Maskable- 64bit+
Capabilities: [c0] Express Legacy Endpoint, MSI 00
Capabilities: [100] Advanced Error Reporting
Capabilities: [130] Device Serial Number a5-89-6d-ff-ff-30-cf-20
Kernel driver in use: sky2
Can anybody help me?
--
Pavel Mateja
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-11-04 22:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <201110171434.50436.pavel@netsafe.cz>
2011-10-17 15:56 ` sky2: only 10Mb/s Stephen Hemminger
2011-10-17 20:53 ` Pavel Matěja
2011-11-03 12:51 ` Kirill Smelkov
2011-11-04 22:17 ` [PATCH] sky2: fix regression on Yukon Optima Stephen Hemminger
2011-11-04 22:20 ` David Miller
2011-10-15 17:58 sky2: only 10Mb/s Pavel Matěja
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).