From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
torvalds@linux-foundation.org
Cc: davem@davemloft.net, netdev@vger.kernel.org, gospo@redhat.com,
sassmann@redhat.com, Hamish Coleman <hamish@zot.apana.org.au>
Subject: Re: [net-next 03/10] seeq: Move the SEEQ drivers
Date: Fri, 4 Nov 2011 17:24:46 +0000 [thread overview]
Message-ID: <20111104172446.GB12913@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1313134384-7287-4-git-send-email-jeffrey.t.kirsher@intel.com>
Okay, this is the only patch I saw (for the SEEQ drivers), but I notice
that more of the ARM drivers have moved. The result is not nice. Or
even workable.
While looking for my ether1, ether3 and etherh drivers in Kconfig, I
enable every option which is presented to me under the new 'ethernet
drivers' stuff. I'm offered my ether3 driver under the SEEQ stuff -
that's fine. But what about the rest?
Well...
drivers/net/ethernet/intel/Kconfig:
config NET_VENDOR_INTEL
bool "Intel devices"
default y
depends on PCI || PCI_MSI
drivers/net/ethernet/i825xx/Kconfig:
config NET_VENDOR_I825XX
bool "Intel (82586/82593/82596) devices"
default y
depends on NET_VENDOR_INTEL && (ISA || ISA_DMA_API || ARM || \
ARCH_ACORN || MCA || MCA_LEGACY || SNI_RM || SUN3 || \
GSC || BVME6000 || MVME16x || EXPERIMENTAL)
if NET_VENDOR_I825XX
config ARM_ETHER1
tristate "Acorn Ether1 support"
depends on ARM && ARCH_ACORN
This is NOT a PCI driver, yet it has ended up with a requirement for
CONFIG_PCI to be set, which is nonsense for this platform because it
has no PCI.
What about etherh?
drivers/net/ethernet/natsemi/Kconfig:
config NET_VENDOR_NATSEMI
bool "National Semi-conductor devices"
default y
depends on MCA || MAC || MACH_JAZZ || PCI || XTENSA_PLATFORM_XT2000
drivers/net/ethernet/8390/Kconfig:
config NET_VENDOR_8390
bool "National Semi-conductor 8390 devices"
default y
depends on NET_VENDOR_NATSEMI && (AMIGA_PCMCIA || PCI || SUPERH || \
ISA || MCA || EISA || MAC || M32R || MACH_TX49XX || \
MCA_LEGACY || H8300 || ARM || MIPS || ZORRO || PCMCIA || \
EXPERIMENTAL)
if NET_VENDOR_8390
config ARM_ETHERH
tristate "I-cubed EtherH/ANT EtherM support"
depends on ARM && ARCH_ACORN
Again, exactly the same thing.
Thankfully, ARM_AM79C961A is right, so that's two out of five correct.
I've no idea what the right solution is to this complex maze of Kconfig
stuff. Do I through an 'ARM' into the NET_VENDOR_INTEL and
NET_VENDOR_NATSEMI dependencies?
While I realise this is a big change, and bugs like this are likely, it
would've been nice to be copied on more of the patches which affect
drivers I maintain.
next prev parent reply other threads:[~2011-11-04 17:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 7:32 [net-next 00/10] drivers/net organize Ethernet drivers (4th series) Jeff Kirsher
2011-08-12 7:32 ` [net-next 01/10] ewrk3/tulip: Move the DEC - Tulip drivers Jeff Kirsher
2011-08-12 7:32 ` [net-next 02/10] ioc3-eth/meth: Move the SGI drivers Jeff Kirsher
2011-08-18 19:46 ` Ralf Baechle
2011-08-12 7:32 ` [net-next 03/10] seeq: Move the SEEQ drivers Jeff Kirsher
2011-08-18 19:36 ` Ralf Baechle
2011-11-04 17:24 ` Russell King - ARM Linux [this message]
2011-11-04 21:10 ` Jeff Kirsher
2011-11-04 21:35 ` Russell King - ARM Linux
2011-11-04 21:16 ` Joe Perches
2011-11-04 21:25 ` Russell King - ARM Linux
2011-11-04 21:42 ` Jeff Kirsher
2011-08-12 7:32 ` [net-next 04/10] pch_gbe: Move the OKI Semiconductor driver Jeff Kirsher
2011-08-12 7:32 ` [net-next 05/10] skge/sky2/mv643xx/pxa168: Move the Marvell Ethernet drivers Jeff Kirsher
2011-08-12 7:33 ` [net-next 06/10] via-*: Move the VIA drivers Jeff Kirsher
2011-08-12 7:33 ` [net-next 07/10] eth16i: Move the Allied Telesis/Fujitsu drivers Jeff Kirsher
2011-08-12 7:33 ` [net-next 08/10] freescale: Move the Freescale drivers Jeff Kirsher
2011-08-12 7:33 ` [net-next 09/10] ks8*/ksz8*: Move the Micrel drivers Jeff Kirsher
2011-08-12 7:33 ` [net-next 10/10] toshiba: Move the Toshiba drivers Jeff Kirsher
2011-08-12 8:22 ` Jens Osterkamp
2011-08-12 8:20 ` [net-next 00/10] drivers/net organize Ethernet drivers (4th series) David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111104172446.GB12913@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=hamish@zot.apana.org.au \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).