From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Joe Perches <joe@perches.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
torvalds@linux-foundation.org, davem@davemloft.net,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
Hamish Coleman <hamish@zot.apana.org.au>
Subject: Re: [net-next 03/10] seeq: Move the SEEQ drivers
Date: Fri, 4 Nov 2011 21:25:55 +0000 [thread overview]
Message-ID: <20111104212555.GD12913@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1320441367.2113.4.camel@Joe-Laptop>
On Fri, Nov 04, 2011 at 11:16:07PM +0200, Joe Perches wrote:
> On Fri, 2011-11-04 at 17:24 +0000, Russell King - ARM Linux wrote:
> > Okay, this is the only patch I saw (for the SEEQ drivers), but I notice
> > that more of the ARM drivers have moved. The result is not nice. Or
> > even workable.
> >
> > While looking for my ether1, ether3 and etherh drivers in Kconfig, I
> > enable every option which is presented to me under the new 'ethernet
> > drivers' stuff. I'm offered my ether3 driver under the SEEQ stuff -
> > that's fine. But what about the rest?
> []
> > While I realise this is a big change, and bugs like this are likely, it
> > would've been nice to be copied on more of the patches which affect
> > drivers I maintain.
>
> Hi Russell.
>
> What drivers in drivers/net do you maintain?
>
> I believe this is the list in MAINTAINERS for you:
>
> ARM/EBSA110 MACHINE SUPPORT
> F: drivers/net/ethernet/amd/am79c961a.*
> ARM/RISCPC ARCHITECTURE
> F: drivers/net/ethernet/i825xx/ether1*
> F: drivers/net/ethernet/seeq/ether3*
>
> Are there others? If yes, what are they?
If that's what's in mainline, then etherh has been dropped from that
list through this move. It's drivers/net/ethernet/8390/etherh*, so
that needs adding back for "ARM/RISCPC ARCHITECTURE".
It was correct - below seems to be what happened...
commit 115978859272b958366d4a08c99a24f9625fa663
Author: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed Jul 13 15:38:08 2011 -0700
i825xx: Move the Intel 82586/82593/82596 based drivers
@@ -1014,7 +1014,7 @@ F: arch/arm/include/asm/hardware/ioc.h
F: arch/arm/include/asm/hardware/iomd.h
F: arch/arm/include/asm/hardware/memc.h
F: arch/arm/mach-rpc/
-F: drivers/net/arm/ether*
+F: drivers/net/arm/ether3*
That change was probably correct at the time, because this one which
came before it:
commit 644570b830266ff33ff5f3542b9c838f93a55ea6
Author: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Sat Apr 2 06:20:12 2011 -0700
8390: Move the 8390 related drivers
which moved the etherh driver without updating MAINTAINERS for that
change.
next prev parent reply other threads:[~2011-11-04 21:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 7:32 [net-next 00/10] drivers/net organize Ethernet drivers (4th series) Jeff Kirsher
2011-08-12 7:32 ` [net-next 01/10] ewrk3/tulip: Move the DEC - Tulip drivers Jeff Kirsher
2011-08-12 7:32 ` [net-next 02/10] ioc3-eth/meth: Move the SGI drivers Jeff Kirsher
2011-08-18 19:46 ` Ralf Baechle
2011-08-12 7:32 ` [net-next 03/10] seeq: Move the SEEQ drivers Jeff Kirsher
2011-08-18 19:36 ` Ralf Baechle
2011-11-04 17:24 ` Russell King - ARM Linux
2011-11-04 21:10 ` Jeff Kirsher
2011-11-04 21:35 ` Russell King - ARM Linux
2011-11-04 21:16 ` Joe Perches
2011-11-04 21:25 ` Russell King - ARM Linux [this message]
2011-11-04 21:42 ` Jeff Kirsher
2011-08-12 7:32 ` [net-next 04/10] pch_gbe: Move the OKI Semiconductor driver Jeff Kirsher
2011-08-12 7:32 ` [net-next 05/10] skge/sky2/mv643xx/pxa168: Move the Marvell Ethernet drivers Jeff Kirsher
2011-08-12 7:33 ` [net-next 06/10] via-*: Move the VIA drivers Jeff Kirsher
2011-08-12 7:33 ` [net-next 07/10] eth16i: Move the Allied Telesis/Fujitsu drivers Jeff Kirsher
2011-08-12 7:33 ` [net-next 08/10] freescale: Move the Freescale drivers Jeff Kirsher
2011-08-12 7:33 ` [net-next 09/10] ks8*/ksz8*: Move the Micrel drivers Jeff Kirsher
2011-08-12 7:33 ` [net-next 10/10] toshiba: Move the Toshiba drivers Jeff Kirsher
2011-08-12 8:22 ` Jens Osterkamp
2011-08-12 8:20 ` [net-next 00/10] drivers/net organize Ethernet drivers (4th series) David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111104212555.GD12913@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=hamish@zot.apana.org.au \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).