* [PATCH] vmxnet3" make ethtool ops const
@ 2012-01-04 21:58 Stephen Hemminger
2012-01-04 22:05 ` Shreyas Bhatewara
2012-01-05 18:23 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2012-01-04 21:58 UTC (permalink / raw)
To: Shreyas Bhatewara; +Cc: VMware, Inc., netdev
All tables of function pointers should be const to make hacks
more difficult. Compile tested only.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/vmxnet3/vmxnet3_ethtool.c 2011-12-19 09:53:44.815309363 -0800
+++ b/drivers/net/vmxnet3/vmxnet3_ethtool.c 2012-01-04 13:15:22.773586753 -0800
@@ -608,7 +608,7 @@ vmxnet3_set_rss_indir(struct net_device
}
#endif
-static struct ethtool_ops vmxnet3_ethtool_ops = {
+static const struct ethtool_ops vmxnet3_ethtool_ops = {
.get_settings = vmxnet3_get_settings,
.get_drvinfo = vmxnet3_get_drvinfo,
.get_regs_len = vmxnet3_get_regs_len,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vmxnet3" make ethtool ops const
2012-01-04 21:58 [PATCH] vmxnet3" make ethtool ops const Stephen Hemminger
@ 2012-01-04 22:05 ` Shreyas Bhatewara
2012-01-05 18:23 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Shreyas Bhatewara @ 2012-01-04 22:05 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: VMware, Inc., netdev
> All tables of function pointers should be const to make hacks
> more difficult. Compile tested only.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Thanks Stephen.
Acked-by: Shreyas N Bhatewara <sbhatewara@vmware.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vmxnet3" make ethtool ops const
2012-01-04 21:58 [PATCH] vmxnet3" make ethtool ops const Stephen Hemminger
2012-01-04 22:05 ` Shreyas Bhatewara
@ 2012-01-05 18:23 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2012-01-05 18:23 UTC (permalink / raw)
To: shemminger; +Cc: sbhatewara, pv-drivers, netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 4 Jan 2012 13:58:13 -0800
> All tables of function pointers should be const to make hacks
> more difficult. Compile tested only.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-05 18:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-04 21:58 [PATCH] vmxnet3" make ethtool ops const Stephen Hemminger
2012-01-04 22:05 ` Shreyas Bhatewara
2012-01-05 18:23 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).