netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] davinci_mdio: Correct bitmask for clock divider value
@ 2012-02-23  8:07 Christian Riesch
       [not found] ` <1329984478-24090-1-git-send-email-christian.riesch-3mrvs1K0uXizZXS1Dc/lvw@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Riesch @ 2012-02-23  8:07 UTC (permalink / raw)
  To: netdev
  Cc: Cyril Chemparathy, davinci-linux-open-source, linux-arm-kernel,
	Christian Riesch

The CLKDIV bitfield in the MDIO Control Register is a 16 bit field,
therefore the CLKDIV value may range from 0 to 0xffff.

Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
---
 drivers/net/ethernet/ti/davinci_mdio.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
index af8b8fc..2757c7d 100644
--- a/drivers/net/ethernet/ti/davinci_mdio.c
+++ b/drivers/net/ethernet/ti/davinci_mdio.c
@@ -53,7 +53,7 @@ struct davinci_mdio_regs {
 	u32	control;
 #define CONTROL_IDLE		BIT(31)
 #define CONTROL_ENABLE		BIT(30)
-#define CONTROL_MAX_DIV		(0xff)
+#define CONTROL_MAX_DIV		(0xffff)
 
 	u32	alive;
 	u32	link;
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] davinci_mdio: Correct bitmask for clock divider value
       [not found] ` <1329984478-24090-1-git-send-email-christian.riesch-3mrvs1K0uXizZXS1Dc/lvw@public.gmane.org>
@ 2012-02-24  8:24   ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-02-24  8:24 UTC (permalink / raw)
  To: christian.riesch-3mrvs1K0uXizZXS1Dc/lvw
  Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
	davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

From: Christian Riesch <christian.riesch-3mrvs1K0uXizZXS1Dc/lvw@public.gmane.org>
Date: Thu, 23 Feb 2012 09:07:58 +0100

> The CLKDIV bitfield in the MDIO Control Register is a 16 bit field,
> therefore the CLKDIV value may range from 0 to 0xffff.
> 
> Signed-off-by: Christian Riesch <christian.riesch-3mrvs1K0uXizZXS1Dc/lvw@public.gmane.org>

Also applied to net-next.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-02-24  8:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-23  8:07 [PATCH] davinci_mdio: Correct bitmask for clock divider value Christian Riesch
     [not found] ` <1329984478-24090-1-git-send-email-christian.riesch-3mrvs1K0uXizZXS1Dc/lvw@public.gmane.org>
2012-02-24  8:24   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).