* [PATCH] drivers/net/stmmac: seq_file fix memory leak
@ 2012-05-20 23:55 Djalal Harouni
2012-05-21 7:38 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Djalal Harouni @ 2012-05-20 23:55 UTC (permalink / raw)
To: Giuseppe Cavallaro; +Cc: netdev, David Miller
Use single_release() instead of seq_release() to free memory allocated
by single_open().
Signed-off-by: Djalal Harouni <tixxdz@opendz.org>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 48d56da..a27e46c 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -1584,7 +1584,7 @@ static const struct file_operations stmmac_rings_status_fops = {
.open = stmmac_sysfs_ring_open,
.read = seq_read,
.llseek = seq_lseek,
- .release = seq_release,
+ .release = single_release,
};
static int stmmac_sysfs_dma_cap_read(struct seq_file *seq, void *v)
@@ -1656,7 +1656,7 @@ static const struct file_operations stmmac_dma_cap_fops = {
.open = stmmac_sysfs_dma_cap_open,
.read = seq_read,
.llseek = seq_lseek,
- .release = seq_release,
+ .release = single_release,
};
static int stmmac_init_fs(struct net_device *dev)
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/net/stmmac: seq_file fix memory leak
2012-05-20 23:55 [PATCH] drivers/net/stmmac: seq_file fix memory leak Djalal Harouni
@ 2012-05-21 7:38 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-05-21 7:38 UTC (permalink / raw)
To: tixxdz; +Cc: peppe.cavallaro, netdev
From: Djalal Harouni <tixxdz@opendz.org>
Date: Mon, 21 May 2012 00:55:30 +0100
> Use single_release() instead of seq_release() to free memory allocated
> by single_open().
>
> Signed-off-by: Djalal Harouni <tixxdz@opendz.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-21 7:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-20 23:55 [PATCH] drivers/net/stmmac: seq_file fix memory leak Djalal Harouni
2012-05-21 7:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).