* Re: [net-next patch] bnx2x: Change bnx2x_tests_str_arr to static char
2012-06-26 16:11 [net-next patch] bnx2x: Change bnx2x_tests_str_arr to static char Merav Sicron
@ 2012-06-26 14:41 ` Joe Perches
2012-06-27 8:20 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Joe Perches @ 2012-06-26 14:41 UTC (permalink / raw)
To: Merav Sicron; +Cc: davem, netdev, eilong
On Tue, 2012-06-26 at 19:11 +0300, Merav Sicron wrote:
> This patch changes the definition of bnx2x_tests_str_arr from char to static
> char.
[]
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
[]
> @@ -1600,7 +1600,7 @@ static int bnx2x_set_pauseparam(struct net_device *dev,
> return 0;
> }
>
> -char *bnx2x_tests_str_arr[BNX2X_NUM_TESTS_SF] = {
> +static char *bnx2x_tests_str_arr[BNX2X_NUM_TESTS_SF] = {
> "register_test (offline) ",
> "memory_test (offline) ",
> "int_loopback_test (offline)",
Should probably be const too.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [net-next patch] bnx2x: Change bnx2x_tests_str_arr to static char
@ 2012-06-26 16:11 Merav Sicron
2012-06-26 14:41 ` Joe Perches
2012-06-27 8:20 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Merav Sicron @ 2012-06-26 16:11 UTC (permalink / raw)
To: davem, netdev, eilong; +Cc: Merav Sicron
This patch changes the definition of bnx2x_tests_str_arr from char to static
char. This correction will also eliminate the sparse warning created in commit
cf2c1df62e065bfc15e38daf2d3479a56b320f29.
Signed-off-by: Merav Sicron <meravs@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
Hi Dave,
Please consider applying this patch to net-next.
Thanks,
Merav
drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
index 1f8c156..bff3129 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c
@@ -1600,7 +1600,7 @@ static int bnx2x_set_pauseparam(struct net_device *dev,
return 0;
}
-char *bnx2x_tests_str_arr[BNX2X_NUM_TESTS_SF] = {
+static char *bnx2x_tests_str_arr[BNX2X_NUM_TESTS_SF] = {
"register_test (offline) ",
"memory_test (offline) ",
"int_loopback_test (offline)",
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [net-next patch] bnx2x: Change bnx2x_tests_str_arr to static char
2012-06-26 16:11 [net-next patch] bnx2x: Change bnx2x_tests_str_arr to static char Merav Sicron
2012-06-26 14:41 ` Joe Perches
@ 2012-06-27 8:20 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2012-06-27 8:20 UTC (permalink / raw)
To: meravs; +Cc: netdev, eilong
From: "Merav Sicron" <meravs@broadcom.com>
Date: Tue, 26 Jun 2012 19:11:03 +0300
> This patch changes the definition of bnx2x_tests_str_arr from char to static
> char. This correction will also eliminate the sparse warning created in commit
> cf2c1df62e065bfc15e38daf2d3479a56b320f29.
>
> Signed-off-by: Merav Sicron <meravs@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-06-27 8:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-06-26 16:11 [net-next patch] bnx2x: Change bnx2x_tests_str_arr to static char Merav Sicron
2012-06-26 14:41 ` Joe Perches
2012-06-27 8:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).