* [patch -resend] 9p: fix min_t() casting in p9pdu_vwritef()
[not found] <20120627085800.GA3007@mwanda>
@ 2012-06-27 9:01 ` Dan Carpenter
2012-06-27 10:19 ` walter harms
2012-06-27 22:26 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2012-06-27 9:01 UTC (permalink / raw)
To: Eric Van Hensbergen
Cc: David S. Miller, Aneesh Kumar K.V, netdev, linux-kernel, kernel-janitors
I don't think we're actually likely to hit this limit but if we do
then the comparison should be done as size_t. The original code
is equivalent to:
len = strlen(sptr) % USHRT_MAX;
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I was told this patch "has already made it upstream via the v9fs pull."
but it must have been dropped accidentally. Originally sent on Sat,
Jan 15, 2011.
diff --git a/net/9p/protocol.c b/net/9p/protocol.c
index 9ee48cb..3d33ecf 100644
--- a/net/9p/protocol.c
+++ b/net/9p/protocol.c
@@ -368,7 +368,7 @@ p9pdu_vwritef(struct p9_fcall *pdu, int proto_version, const char *fmt,
const char *sptr = va_arg(ap, const char *);
uint16_t len = 0;
if (sptr)
- len = min_t(uint16_t, strlen(sptr),
+ len = min_t(size_t, strlen(sptr),
USHRT_MAX);
errcode = p9pdu_writef(pdu, proto_version,
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch -resend] 9p: fix min_t() casting in p9pdu_vwritef()
2012-06-27 9:01 ` [patch -resend] 9p: fix min_t() casting in p9pdu_vwritef() Dan Carpenter
@ 2012-06-27 10:19 ` walter harms
2012-06-27 10:36 ` Dan Carpenter
2012-06-27 22:26 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: walter harms @ 2012-06-27 10:19 UTC (permalink / raw)
To: Dan Carpenter
Cc: Eric Van Hensbergen, David S. Miller, Aneesh Kumar K.V, netdev,
kernel-janitors
Am 27.06.2012 11:01, schrieb Dan Carpenter:
> I don't think we're actually likely to hit this limit but if we do
> then the comparison should be done as size_t. The original code
> is equivalent to:
> len = strlen(sptr) % USHRT_MAX;
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> I was told this patch "has already made it upstream via the v9fs pull."
> but it must have been dropped accidentally. Originally sent on Sat,
> Jan 15, 2011.
>
> diff --git a/net/9p/protocol.c b/net/9p/protocol.c
> index 9ee48cb..3d33ecf 100644
> --- a/net/9p/protocol.c
> +++ b/net/9p/protocol.c
> @@ -368,7 +368,7 @@ p9pdu_vwritef(struct p9_fcall *pdu, int proto_version, const char *fmt,
> const char *sptr = va_arg(ap, const char *);
> uint16_t len = 0;
> if (sptr)
> - len = min_t(uint16_t, strlen(sptr),
> + len = min_t(size_t, strlen(sptr),
> USHRT_MAX);
>
> errcode = p9pdu_writef(pdu, proto_version,
this will result in
uint16_t = size_t
i would expect compilers to complains since uint16 < size_t (most times). In this special case
it seems more easy write it. also ushort seems ambitious since uint16_t need not to be ushort.
so my idea would look like this:
len=strlen
if (len>65535) len=65535;
p9pdu_writef(...,(unint16_t)len);
just my 2 cents,
wh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch -resend] 9p: fix min_t() casting in p9pdu_vwritef()
2012-06-27 10:19 ` walter harms
@ 2012-06-27 10:36 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2012-06-27 10:36 UTC (permalink / raw)
To: walter harms
Cc: Eric Van Hensbergen, David S. Miller, Aneesh Kumar K.V, netdev,
kernel-janitors
On Wed, Jun 27, 2012 at 12:19:26PM +0200, walter harms wrote:
>
>
> Am 27.06.2012 11:01, schrieb Dan Carpenter:
> > I don't think we're actually likely to hit this limit but if we do
> > then the comparison should be done as size_t. The original code
> > is equivalent to:
> > len = strlen(sptr) % USHRT_MAX;
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > I was told this patch "has already made it upstream via the v9fs pull."
> > but it must have been dropped accidentally. Originally sent on Sat,
> > Jan 15, 2011.
> >
> > diff --git a/net/9p/protocol.c b/net/9p/protocol.c
> > index 9ee48cb..3d33ecf 100644
> > --- a/net/9p/protocol.c
> > +++ b/net/9p/protocol.c
> > @@ -368,7 +368,7 @@ p9pdu_vwritef(struct p9_fcall *pdu, int proto_version, const char *fmt,
> > const char *sptr = va_arg(ap, const char *);
> > uint16_t len = 0;
> > if (sptr)
> > - len = min_t(uint16_t, strlen(sptr),
> > + len = min_t(size_t, strlen(sptr),
> > USHRT_MAX);
> >
> > errcode = p9pdu_writef(pdu, proto_version,
>
> this will result in
> uint16_t = size_t
> i would expect compilers to complains since uint16 < size_t
> (most times). In this special case it seems more easy write it.
> also ushort seems ambitious since uint16_t need not to be
> ushort. so my idea would look like this:
>
> len=strlen
> if (len>65535) len=65535;
> p9pdu_writef(...,(unint16_t)len);
>
No. I'm sorry, what you're saying is complete nonsense. The whole
point of min_t() is that you can cast to both sides to what you want
before you do the compare.
Obviously I wouldn't submit a patch that introduces a compile
warning. :/
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch -resend] 9p: fix min_t() casting in p9pdu_vwritef()
2012-06-27 9:01 ` [patch -resend] 9p: fix min_t() casting in p9pdu_vwritef() Dan Carpenter
2012-06-27 10:19 ` walter harms
@ 2012-06-27 22:26 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2012-06-27 22:26 UTC (permalink / raw)
To: dan.carpenter; +Cc: ericvh, aneesh.kumar, netdev, linux-kernel, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 27 Jun 2012 12:01:41 +0300
> I don't think we're actually likely to hit this limit but if we do
> then the comparison should be done as size_t. The original code
> is equivalent to:
> len = strlen(sptr) % USHRT_MAX;
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-06-27 22:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20120627085800.GA3007@mwanda>
2012-06-27 9:01 ` [patch -resend] 9p: fix min_t() casting in p9pdu_vwritef() Dan Carpenter
2012-06-27 10:19 ` walter harms
2012-06-27 10:36 ` Dan Carpenter
2012-06-27 22:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).